On Wed, May 18, 2016 at 10:41 PM, Chad innocentkiller@gmail.com wrote:
On Wed, May 18, 2016 at 8:35 AM Daniel Kinzler daniel.kinzler@wikimedia.de wrote:
Am 13.05.2016 um 18:23 schrieb Greg Grossmeier:
<quote name="Addshore" date="2016-05-13" time="16:48:47 +0100"> > Gerrit also has drafts...
Drafts are only visible to the author, unfortunately.
And anyone the author adds as a reviewer. Works nicely in my experience.
Which I guess is nice if you really only want a specific group of people to see it, but it keeps the casual reviewer from chiming in.
This is why they seemed useful for security patches at first, except that they're disclosable over `git fetch` if you know where to look.
So yeah, I'm convinced they're defective by design as they're both too secret and not secret enough at the same time.
For non-security patches, discovery isnt a problem. They are cookie-licked bugs, and should already been discoverable via a link on a Phabricator task. If there is no Phabricator task, they are an unloved patch for an undefined problem. Hiding them as a draft un-licks them.
But that depends on https://phabricator.wikimedia.org/T63124 , and probably an upgrade of Gerrit, which will take forever because of the plan to switch to using Phabricator for code review.