On 07/11/2014 06:12 AM, Thomas Mulhall wrote:
Hi we are upgrading jquery cookie from an early alpha version of 1.1 to 1.2. Please start upgrading your code to be compatible with jquery cookie 1.2. There is just one deprecations to notice and that is $.cookie('foo', null) is now deprecated. And replace it with Adding $.removeCookie('foo') for deleting a cookie. We are slowly upgrading to version 1.4.1 but one step at a time because it is. And please also follow this change log github.com/carhartl/jquery-cookie/blob/master/CHANGELOG.md so that we can upgrade to 1.4.1.
This refers to two changes:
* https://gerrit.wikimedia.org/r/#/c/145000/ - This will probably be merged shortly. The only breaking change mentioned is that $.cookie( 'key', undefined ) no longer works. The documented (https://github.com/carhartl/jquery-cookie/blob/faa09dc38bd3c791212e8fca67ee6...) way to do this for the version we use is $.cookie( 'key', null )
There should also be an update to mw.cookie, either in 145000, or a follow-up chained on that.
After those change(s) are merged) (upgrading to 1.2, and updating mw.cookie to use removeCookie), code using jQuery Cookie should either: ** Update to mw.cookie (it is possible to use unprefixed keys if needed for backwards-copmatibility reasons) ** Or if still using jQuery Cookie directly, use removeCookie.
* https://gerrit.wikimedia.org/r/#/c/139686/ - Upgrades to jQuery Cookie 1.4.1. Not possible until all code using $.cookie( 'key', null ) has been migrated.
Matt Flaschen