On 01/15/2013 06:58 AM, Nikola Smolenski wrote:
In my opinion, if the typo is trivial (f.e. someone typed "fo" instead of "of"), there is no need to -1 the commit, however if the typo pertains to a crucial element of the commit (f.e. someone typed "fixed wkidata bug") perhaps it should, since otherwise people who search through commit messages won't be able to find commits that contain word "wikidata".
I agree. Well said. A minor mistake like that that doesn't affect grepping isn't worth a -1, since it doesn't affect the readability of the code itself.
Matt Flaschen