"Rob Church" robchur@gmail.com wrote in message news:e92136380612131311x24e8cf0cpe0ad70aeaf678b87@mail.gmail.com...
On 13/12/06, Dave Grogan dgrogan@gmail.com
wrote:
The spellchecker needs a hook near the end of getEditToolbar that is passed the toolbar variable. The extension adds a spellcheck button to the toolbar.
You couldn't just use the existing JavaScript-based support functions for adding custom edit buttons?
Or look at how http://www.mediawiki.org/wiki/Extension:Add_Button does it.
Track Changes needs ArticleSaveComplete to also pass $revisionId (id of the newly-saved revision) and a flag that determines whether the content of the article changed.
That sounds sane enough to me.
I was under the impression that the article was never saved if the content hasn't changed, and therefore the hook wouldn't trigger in that situation anyway.
Also, $revisionID should be available through the article object that is already passed to the hook. If not, then that is where it should be added, not as an extra hook parameter.
Track changes needs SkinTemplateTabs to pass in revid and oldid so that it can display oldid if specified in the query string or revid if it
was:
$oldid = $wgRequest->getVal( 'oldid' ); global $wgArticle; $revid = $wgArticle ? $wgArticle->getLatest() : 0;
Not very clear about this point. Can you elaborate?
- Mark Clements (HappyDog)