Sorry, yes I have extensions that create the index which seem to be getting the full title text. It does look like it was an oversight.
I guess I'll just keep hacking the file!
Cheers,
Alex
On Fri, Aug 22, 2008 at 5:35 PM, Brion Vibber brion@wikimedia.org wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Alex Powell wrote:
Every release of MW since 1.10 I've been making a tweak to the rebuildtextindex.php to replace line 60 with the following code:
[snip]
I have no idea how the best way to get this into the main code base is,
but
I'm pretty sure as it stands its wrong in everyone's eyes - since the namespace information is currently lost. Ideally SearchUpdate would be refactored to take a namespace parameter, but this at least allows it to
be
retrieved intact.
Every call to SearchUpdate from Article and Title passes in the title text portion without the namespace, and even if you included the namespace on the title text, SearchUpdate itself discards it in its constructor!
The namespace information is kept in the page table, in the page_namespace field.
At some point we'll want to refactor SearchUpdate along with the search backend classes to ensure everything does their index updates in a cleaner way.
- -- brion
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEUEARECAAYFAkiu6tgACgkQwRnhpk1wk46N3wCYm4NtQOOWfMiKPv1R1MGmTUo7 QgCfR+z9OXnElW/SmSzTz3ddwACt7gk= =KqVv -----END PGP SIGNATURE-----
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l