Hi MZMcBride,
On 13 October 2013 16:41, MZMcBride z@mzmcbride.com wrote:
It uses OAuth to identify the user to prevent abuse, and the OAuth identified user will be listed as committer name in the commit. The username shown as 'owner' in Gerrit will still be 'Gerrit patch uploader'.
This part is a little confusing to me. Is it possible (or desirable) to integrate with wikitech/Labs/Gerrit/Git usernames instead? Integrating with mediawiki.org feels a bit strange.
I have thought of one method -- the uploader could create an ssh key for the user, store it (somewhere, probably in a cookie) and ask the user to add the corresponding public key to the list of accepted public keys. This has the advantage of fixing the ownership issue (as the patch would be owned by the uploading user). However, the user would then still have to create a wikitech account, log in to gerrit, and add an SSH key. The main advantage of using mw.o is that is uses SUL, which means that basically anyone who wants to upload a patch probably already has an account.
Possible enhancements:
- allow file upload of a patch;
This is something on my to-do list, but I have to fiddle a bit with Flask to see how I can handle files.
- "upload an patch" --> "upload a patch"; and
- perhaps set patch input text area to use a monospace font and/or a code
editor.
Fixed! (although the textarea already was monospace for me, but it's now explicit in CSS)
Thanks for your comments :-)
Merlijn