On 12/08/2009, at 1:16 AM, Chad wrote:
On the whole "new code" front. Can we all /please/ remember that we're writing PHP5 here. Visibility on all new functions and variables should also be a must.
I honestly don't think this is that important. We should err on the side of public, not private or protected.
Very frequently, I've had to change visibility on functions because somebody hasn't anticipated a case where a class function might be usefully called from outside that class.
-- Andrew Garrett agarrett@wikimedia.org http://werdn.us/