On Tue, May 27, 2008 at 10:42 AM, catrope@svn.wikimedia.org wrote:
- Refactor Title::isValidMoveOperation() and Title::moveTo() to return an array of arrays like Title::getUserPermissionsErrors() does; other functions used by the write API have undergone similar refactoring earlier
There is absolutely no point in using all this ugly array nesting if you never use arrays with more than one element. The entire idea of using arrays (ugly as all this nesting gets) is that you can return all errors that occur, instead of just returning the first error you notice. You only ever handle arrays of one element here, and in fact you explicitly ignore all others:
call_user_func_array(array($this, 'showForm'), $error[0]);
That really sort of defeats the point.