Wikitech-l August 2021

wikitech-l@lists.wikimedia.org

39 participants
50 discussions

Removing methods in the Article class without deprecation
by Daimona 17 Aug '21

17 Aug '21

Hello all, Next week we will remove the following methods without deprecation: - Article::delete() - Article::confirmDelete() - ImagePage::delete() This is part of an ongoing refactoring of deletion-related code. The methods above are currently bloated: beyond deleting an article, they're responsible for building the UI, checking permissions, handling errors etc. The relevant UI-related code is being moved to DeleteAction, so use that if you need to do something with the UI. Maintaining BC in the old methods is challenging, due to how many things this code does, and how much code is being moved around. According to codesearch, these methods are only used by a test in WikibaseLexeme (which has been temporarily disabled). Thus, we decided to remove them without deprecation after this week's train. Please reply to this email if you're affected by this and don't know how to fix. Best regards, -- https://meta.wikimedia.org/wiki/User:Daimona_Eaytoy "Daimona" is not my real name -- he/him

1 0

🚂🌈 Summary of 1.37.0-wmf.18 train deployment
by Tyler Cipriani 17 Aug '21

17 Aug '21

This email is a summary of the Wikimedia production deployment of 1.37.0-wmf.18. - Conductor: Jeena Huneidi - Backup: Mukunda Modell - Blocker task: T281159 <https://phabricator.wikimedia.org/T281159> - Status: Live on all wikis <https://versions.toolforge.org/> *📊Stats* - 244 patches ▁▄█▅▄ - 1 rollback ▁▁███ - 1 day of delay (going to group0) ██▁▁█ - 6 blockers ▄▁▁▆█ 🚂🌈 Big WikiLove to the folks who helped out: - Timo Tijhof - James D. Forrester - Tacsipacsi - Lucas Werkmeister - Jon Robson - RhinosF1 - KartikMistry - abi_ - Zabe Until the next train, – Your local WikiMotive congregants

1 0

Help in my tasks in Gerrit
by jp64902＠gmail.com 15 Aug '21

15 Aug '21

Could someone help me with something related to gerrit.wikimedia.org? My <a href="https://gerrit.wikimedia.org/r/dashboard/self">dashboard</a> has 6 changes that need code review, which is important because they are requests from Phabricator . So could someone experienced review the code for my requested changes? Thank you in advance!

3 5

reviewer for extension
by tdvit＠mail.com 14 Aug '21

14 Aug '21

4 4

Goto for microoptimisation
by Tim Starling 14 Aug '21

14 Aug '21

For performance sensitive tight loops, such as parsing and HTML construction, to get the best performance it's necessary to think about what PHP is doing on an opcode by opcode basis. Certain flow control patterns cannot be implemented efficiently in PHP without using "goto". The current example in Gerrit 708880 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/708880/5/includes/Html.ph…> comes down to: if ( $x == 1 ) { action1(); } else { action_not_1(); } if ( $x == 2 ) { action2(); } else { action_not_2(); } If $x==1 is true, we know that the $x==2 comparison is unnecessary and is a waste of a couple of VM operations. It's not feasible to just duplicate the actions, they are not as simple as portrayed here and splitting them out to a separate function would incur a function call overhead exceeding the proposed benefit. I am proposing if ( $x == 1 ) { action1(); goto not_2; // avoid unnecessary comparison $x == 2 } else { action_not_1(); } if ( $x == 2 ) { action2(); } else { not_2: action_not_2(); } I'm familiar with the cultivated distaste for goto. Some people are just parotting the textbook or their preferred authority, and others are scarred by experience with other languages such as old BASIC dialects. But I don't think either rationale really holds up to scrutiny. I think goto is often easier to read than workarounds for the lack of goto. For example, maybe you could do the current example with break: do { do { if ( $x === 1 ) { action1(); break; } else { action_not_1(); } if ( $x === 2 ) { action2(); break 2; } } while ( false ); action_not_2(); } while ( false ); But I don't think that's an improvement for readability. You can certainly use goto in a way that makes things unreadable, but that goes for a lot of things. I am requesting that goto be considered acceptable for micro-optimisation. When performance is not a concern, abstractions can be introduced which restructure the code so that it flows in a more conventional way. I understand that you might do a double-take when you see "goto" in a function. Unfamiliarity slows down comprehension. That's why I'm suggesting that it only be used when there is a performance justification. -- Tim Starling

10 11

🚂🌈 Summary of 1.37.0-wmf.17 train deployment
by Mukunda Modell 13 Aug '21

13 Aug '21

This email is a belated summary of the Wikimedia production deployment of 1.37.0-wmf.17. Dan Duvall was the train conductor last week. I was the backup conductor. Blocker task: https://phabricator.wikimedia.org/T281158 The new version is live on all sites: https://versions.toolforge.org/ 🎶 Optional: For optimal enjoyment, queue up a fine track by They Might Be Giants <https://s3.amazonaws.com/TMBG_pod/TMBGPodcast57a.mp3> for your listening pleasure while you dive into these stats: == 📊 Stats == * 287 patches ↓ * 16 backports <https://phabricator.wikimedia.org/source/mediawiki/compare/?head=wmf%2F1.37…> * 1 rollback (for ~3hours) ↑ * 0 days of delay * 5 blockers added, 3 resolved, 2 removed ↑ ** RESOLVED: *** T287988 PHP Warning: Class __PHP_Incomplete_Class has no unserializer <https://phabricator.wikimedia.org/T287988> *** T288191 substituting {{#tag:ref}} tags and templates; and pipe tricks fail in Page namespace <https://phabricator.wikimedia.org/T288191> *** T288288 1.37.0-wmf.17 deployment moved footer from bottom of the page to left column in Monobook <https://phabricator.wikimedia.org/T288288> == 🚂🌈 == 1 task was mentioned, which is not a train blocker but remains open: * T287410 ResourceLoaderSkinModule: Skins should not use the legacy styling feature <https://phabricator.wikimedia.org/T287410> Thank you to everyone who helped out whether in a big way or a small one. Special thanks goes to the owners of these phabricator usernames: * dduvall * Jdlrobson * Jdforrester-WMF * Ladsgroup * Urbanecm * DannyS712 * Krinkle * Legoktm * Tpt * Xover * jouncebot * Jdforrester-WMF Yes I know James is mentioned twice. There really aren't enough thank-yous for all that James does. – The Trainbow Bunch

5 4

Get ready for the Wikimania Hackathon 2021!
by Srishti Sethi 12 Aug '21

12 Aug '21

Hello everyone, We hope that you are ready and are excited for the upcoming 24hrs Wikimania Hackathon :) This will be a virtual space for you to experiment, work on technical projects, and have discussions with fellow Wikimedians! *Day and hours* Hackathon will start at 5:00 am UTC on August 13th, Friday (the first day of Wikimania), and run until August 14th, Saturday, 4:59 am UTC. You are welcome to continue hacking on other days of Wikimania. There will be a final showcase on the last day, August 17th, with more information coming soon on the social channels. *Activities* An open schedule is up on the Hackathon's subpage on the Wikimania wiki: < https://wikimania.wikimedia.org/wiki/2021:Hackathon/Schedule> [1]. There are still some free slots, and you are welcome to reserve one for a session. We will be using two virtual hacking rooms powered by Jitsi; links to join are on the schedule page. For projects and a complete list of activities, check out the Phabricator workboard: < https://phabricator.wikimedia.org/project/view/5402/> [2] *Newcomer activities* For those of you who are a newcomer to the event or Wikmedia’s technical ecosystem, we have put together three Q&A sessions and a list of resources for you to get started. *Networking* See a list of who is attending, topics they are interested in, and how you can contact them: < https://wikimania.wikimedia.org/wiki/2021:Hackathon/Participants> [3]. Please add yourself to this list, and also see a complete list of social channels and read about the code of conduct for Wikimedia's technical spaces that will be in effect in all these channels: < https://wikimania.wikimedia.org/wiki/2021:Hackathon#Social_channels> [4]. If you have any questions, ask on the Hackathon's talk page: < https://wikimania.wikimedia.org/wiki/2021_talk:Hackathon> [5]. We look forward to meeting you in less than a day :) Cheers, Srishti On behalf of the Wikimania Hackathon organizing team [1] https://wikimania.wikimedia.org/wiki/2021:Hackathon/Schedule [2] https://phabricator.wikimedia.org/project/view/5402/ [3] https://wikimania.wikimedia.org/wiki/2021:Hackathon/Participants [4] https://wikimania.wikimedia.org/wiki/2021:Hackathon#Social_channels [5] https://wikimania.wikimedia.org/wiki/2021_talk:Hackathon *Srishti Sethi* Senior Developer Advocate Wikimedia Foundation <https://wikimediafoundation.org/>

1 0

Phabricator database master maintenance - Thursday 12th August
by Manuel Arostegui 12 Aug '21

12 Aug '21

Hello, On Thursday 12th August at 06:00 AM UTC we'll switch our phabricator database master to a different host ( https://phabricator.wikimedia.org/T288197) There'll be 1 or 2 minutes of read-only time. Writes will be blocked, reads will continue as usual. Sorry for the inconveniences. Manuel.

1 1

Support for Automating Source Code Documentation
by Felipe Ebert 09 Aug '21

09 Aug '21

Hi, I am currently working on designing a bot to support open-source software development: the idea is that the bot can analyze code review comments, detect those related to explaining the reasons behind the implementation choices and suggest these reasons as source code comments. As the first step of this design process we would like to ask developers involved in code reviews to answer a survey (we expect it to take not more than 25 minutes): https://forms.office.com/r/9nD4HtNbTK Thanks in advance, -- Felipe Ebert Eindhoven University of Technology, The Netherlands

1 0

Gadget AjQuickDelete
by Dhaval S. Vyas 08 Aug '21

08 Aug '21

Hi, I had imported gadget AJQuickDelete from commons to gu.wiki a few years back, which worked perfectly well until I updated it last month. Not it has disappeared from the navigation bar. Can someone please help me by looking in to it? Thanks, Dhaval

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Wikitech-l August 2021