Wikitech-l June 2020

wikitech-l@lists.wikimedia.org

66 participants
72 discussions

Skins: Deprecation of various hooks and introducing SkinMustache
by Jon Robson 01 Jul '20

01 Jul '20

Hello, TLDR: The following hooks are deprecated in 1.35: SkinTemplateBuildNavUrlsNav_urlsAfterPermalink, SkinTemplatePreventOtherActiveTabs, SkinTemplateTabAction, BaseTemplateAfterPortlet, SkinTemplateToolboxEnd, BaseTemplateToolbox, SkinTemplateOutputPageBeforeExe. The longer version: As part of the desktop improvements project <http://mediawiki.org/wiki/Desktop%20improvements> we've been making some exciting changes in MediaWiki's skin architecture. This has involved migrating away from the BaseTemplate PHP class to Mustache as the render engine for Vector. In 1.36, the Vector skin plans to use the new SkinMustache class <https://github.com/wikimedia/mediawiki/blob/master/includes/skins/SkinMusta…> and do away with the BaseTemplate class. This meant that we had to deprecate various BaseTemplate hooks, providing more suitable generic alternatives in the shared Skin.php layer. We also took the opportunity to reduce the number of active hooks that operate in the skin layer for developer sanity. >From now on it is intended that any skin modifications are done *prior *to rendering. The renderer whether it is BaseTemplate or SkinMustache will simply render the data that's been provided. As a result of this I have various changes to report! The *SidebarBeforeOutput <https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Hooks/SidebarBefor…> *hook now can be used to modify the toolbox and languages portals. Previously these sidebar menus had their own bespoke hooks. The SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook <https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateBuildNavUrlsNav_url…> is deprecated and can be replaced with the new and improved SidebarBeforeOutput hook. The SkinTemplatePreventOtherActiveTabs and SkinTemplateTabAction hooks <https://phabricator.wikimedia.org/T253814>were seldom used and replaced with SkinTemplateNavigation::Universal . All BaseTemplate hooks should now be considered deprecated per T253809 <https://phabricator.wikimedia.org/T253809>. - BaseTemplateAfterPortlet <https://www.mediawiki.org/wiki/Manual:Hooks/BaseTemplateAfterPortlet> is replaced with the template-rendering agnostic SkinAfterPortlet <https://www.mediawiki.org/wiki/Manual:Hooks/SkinAfterPortlet> - SkinTemplateToolboxEnd <https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateToolboxEnd>is replaced with the new and improved version of SidebarBeforeOutput - BaseTemplateToolbox <https://www.mediawiki.org/wiki/Manual:Hooks/BaseTemplateToolbox> is replaced with the new and improved version of SidebarBeforeOutput Finally a big one: The SkinTemplateOutputPageBeforeExec hook is now deprecated <https://phabricator.wikimedia.org/T60137>. Previously this hook could do a lot of things and often in ways that were hard to reason with. For example, previously this hook was used alongside other hooks to add items to the footer and to override skin internals to display portals that were normally hidden. We looked through all the use cases for this hook and are confident we've caught the most confident use cases. Migration depends on what it was previously used for but are documented on mediawiki.org <https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateOutputPageBeforeExe…>. It's possible there are other use cases, we missed and if so we plan to cover those during the 1.36 release. If you are an extension developer and have any questions about migration please feel free to ping me on the associated Phabricator ticket or hook talk page, we will be happy to improve the documentation and help you find the right way to upgrade your code. As we go into 1.36 we plan to make changes that simplify MediaWiki skin development and make the ecosystem friendlier to frontend developers and make skins easier to maintain. In fact, in future, it will be possible to write skins without a single line of PHP. If you are excited or intrigued by these changes and want to get involved in the conversations I urge you to subscribe to our board. <https://phabricator.wikimedia.org/project/board/4795/> I'm particularly interested in hearing from developers who are keen to make skins in the new ecosystem. Your input and creativity would be much appreciated. Feel free to drop me a private mail or engage in open conversations. In addition to all the extension developers who helped review changes to their hook contracts, I would like to especially thank the following people for getting us to this landmark: Ammarpad, Timo, Volker and Mainframe98. I'd like to give a specific shout out for Ammarpad who has been a huge driving force here, preventing various bugs from occurring and swiftly responding to many of the unexpected regressions that we encountered during this work. We couldn't have done this without you! Thanks for reading! Jon

2 1

Gerrit upgrade on Saturday, 27th of June
by Christian Aistleitner 01 Jul '20

01 Jul '20

[Apologies for cross-posting] Hi, TL;DR: We will take our Gerrit instance at gerrit.wikimeda.org offline on Saturday, 27th of June from 17:00--22:00 UTC (hopefully much shorter) to upgrade to the latest Gerrit v3.2.2. (10:00--15:00 San Francisco time, and 19:00--24:00 Central European time) --------------------------------- We're currently running Gerrit v2.15, which is no longer supported and we will upgrade to Gerrit v3.2 on Saturday 27th of June. This new version brings lots of improvements. The most noticeable change is probably the UI overhaul. The (default) "old UI" gets removed and the "new UI" has been completely revamped. It's much more modern looking and easier to use. And it also became far more usable on mobile phones. But the new version of course also comes with fixes and additions around the ssh interface, and the HTTP API. Since this is such a big upgrade, we want to give you a chance to look at it beforehand. You can test at https://gerrit-test.wikimedia.org/ It holds a copy of our Gerrit data as of 15th of June, and it runs the new Gerrit v3.2.2. We'll keep tuning things there during this week, so it might get an occasional restart. But look around and test the new UI, the HTTP API, etc. If you run into issues or discover bugs, please open tickets in Phabricator and set the Gerrit 3.x upgrade task (T254158) as parent. Note that this test Gerrit instance is already hooked up with our Phabricator. If you upload / merge / abandon / etc changes with a `Bug: Tnnnn` footer, you'll get comments on the corresponding tasks in Gerrit. So please use our test task T775 for your experiments. As everything, also this upgrade comes with a few downsides: * The new UI no longer works on Internet Explorer (currently ~0.02% of Gerrit's web requests). Microsoft's Edge browser works though. So if you are still using Internet Explorer, please consider switching to a different browser. * Users of git-review need to use at least version 1.27 (released September 2018). Otherwise uploading changes will fail. * Your git should be at least version 2.2.0 (released November 2014) to take advantage of the new, much simpler commit-msg hook. Keeping my fingers crossed for a painless update, Christian with lots of helping hands from RelEng, and SRE

8 11

1.39.0-wmf.39 train is blocked (Flow/Sidebar issue)
by Antoine Musso 30 Jun '20

30 Jun '20

Hello, The 1.39.0-wmf.39 is blocked, immediately after deploying it to group0 wikis, Flow topics ended up being error pages. When browsing a topic page, there are two issues bubbling up in logstash: >From VectorTemplate->buildSidebar() * /srv/mediawiki/php-1.35.0-wmf.39/includes/language/Message.php:261 $key must be a string or an array >From Skin->buildSidebar / ElectronPdfServiceHooks::onSidebarBeforeOutput * /srv/mediawiki/php-1.35.0-wmf.39/extensions/ElectronPdfService/src/ElectronPdfServiceHooks.php:62 PHP Notice: Undefined index: print Which as I understand it causes an exception. The breaking bug is: https://phabricator.wikimedia.org/T256761 -- Antoine "hashar" Musso Release Engineering

1 1

Upcoming Search Platform Office Hours—July 1st, 2020
by Trey Jones 30 Jun '20

30 Jun '20

The Search Platform Team <https://www.mediawiki.org/wiki/Wikimedia_Search_Platform> usually holds office hours the first Wednesday of each month. Come talk to us about anything related to Wikimedia search! Feel free to add your items to the Etherpad Agenda for the next meeting. Details for our next meeting: Date: Wednesday, July 1st, 2020 Time: 15:00-16:00 GMT / 08:00-09:00 PDT / 11:00-12:00 EDT / 17:00-18:00 CEST Etherpad: https://etherpad.wikimedia.org/p/Search_Platform_Office_Hours Google Meet link: https://meet.google.com/vyc-jvgq-dww Join by phone in the US: +1 786-701-6904 PIN: 262 122 849# Hope to talk to you in a week! —Trey Trey Jones Sr. Software Engineer, Search Platform Wikimedia Foundation UTC-4 / EDT

1 1

Debian Jessie base Wikimedia container image being phased out
by Alexandros Kosiaris 30 Jun '20

30 Jun '20

Hello everyone, In the interest of proceeding with the deprecation of Jessie in our infrastructure, SRE ServiceOps will stop maintaining and eventually remove the base Debian Jessie OCI container image[1], also known as wikimedia-jessie, from our docker registry. If you rely on this image in any way, you are strongly urged to move to our Debian Stretch or Buster images, which will continue to be maintained for some time (for more information see https://wikitech.wikimedia.org/wiki/Operating_system_upgrade_policy). A tentative timeline follows: * 2020-07-02. https://gerrit.wikimedia.org/r/c/operations/puppet/+/587529 will be merged. This will mean the image will no longer be receiving any kind of updates but will still be possible to be pulled from the registry. Workflows are not expected to break. * 2020-08-03. Removal of all the image tags and versions of the above image will happen. That will mean that the image will no longer be able to be pulled from the registry. If you have any workflows that rely on pulling this image from the registry, they are expected to break on this date. Images that have already been published and are based on the Jessie image however will not be touched and will still be pullable. If you have a workflow that will break after the 2020-08-03 mark and are unable to alter it, please reach out to us. Following the above, we will also investigate whether removing image versions and tags that depend on the removed image makes sense. Note that this is the first time we remove a base image from our registry and as such we are building knowledge and experience around this. [1] https://tools.wmflabs.org/dockerregistry/wikimedia-jessie/tags/ Regards, -- Alexandros Kosiaris Principal Site Reliability Engineer Wikimedia Foundation

1 0

Announcing goodbot - A chatbot for Wikimedia’s Zulip
by Pavithra Eswaramoorthy 29 Jun '20

29 Jun '20

Hello everyone! We are super excited to introduce two new bots for Wikimedia’s Zulip<https://wikimedia.zulipchat.com> - goodbot and ircbot! Wikimedia has been using Zulip<https://zulipchat.com/>, an open source communication platform, for supporting participants in Wikimedia’s outreach programs. Read more about how we are building a community in this blog post: https://techblog.wikimedia.org/2020/05/04/using-zulip-an-open-source-tool-f…. As a part of Google Summer of Code<https://summerofcode.withgoogle.com/> 2020, QEDK<https://www.mediawiki.org/wiki/User:QEDK> is working towards developing bots to make the Zulip experience better for participants, mentors and administrators. Goodbot is a chatbot that sends welcome messages to newly joined participants and helps answer some questions about the different outreach programs like Google Summer of Code, Outreachy and Season of Docs. You can chat with it on any Wikimedia Zulip stream. Ircbot bridges all communication between the #technical-support<https://wikimedia.zulipchat.com/#streams/technical-support> stream on Zulip and the IRC channel #wikimedia-tech. It allows the participant community on Zulip to interact with the broader Wikimedia community that is primarily active on IRC. You can see ircbot active in both the aforementioned channels. You can learn more about the future plans for the project in the GSoC proposal here: https://phabricator.wikimedia.org/T247879 and keep track of the progress in the bi-weekly reports recorded here: https://www.mediawiki.org/wiki/User:QEDK We would love to hear your thoughts and feedback on the bots. Please reach out to us on Zulip: https://wikimedia.zulipchat.com/ or on GitHub: https://github.com/qedk/goodbot. :) Thanks and cheers, The goodbot team

1 0

New design for Stable interface policy
by Krinkle 28 Jun '20

28 Jun '20

Based on recent CRs and feedback I've redesigned the recently updated Stable interface policy. Old: https://www.mediawiki.org/w/index.php?title=Stable_interface_policy&oldid=3… New: https://www.mediawiki.org/wiki/User:Krinkle/Stable_interface_policy I hope this is more approachable and easier to navigate from the various perspectives and use cases where you might need it (e.g. when reviewing code, writing code in core, writing code in an extension, planning out the deprecation roadmap for a feature, etc.). This page is currently a draft because during the rewrite I noticed a few minor inconsistencies and open questions in the nominal text. These are being fleshed out through an RFC at < https://phabricator.wikimedia.org/T255803>. Once we've decided on those details, I'll publish the new design to the canonical page. -- Timo

1 0

TechCom Radar 2020-06-24
by Daniel Kinzler 26 Jun '20

26 Jun '20

Hi all, Here are the minutes from this week's TechCom meeting: Last Call: Amendment to the Stable interface policy (T255803) * Ticket: https://phabricator.wikimedia.org/T255803 * No big change in substance from the policy adopted in March * Draft policy: https://www.mediawiki.org/wiki/User:Krinkle/Stable_interface_policy * Description of: https://www.mediawiki.org/wiki/User:Krinkle/Stable_interface_policy/Changes * The new policy is on Last Call until July 8th. If you have any concerns about the draft, please comment on the ticket. If no concerns remain unaddressed by July 8, the draft will be adopted as the new policy. Approved: Drop support for IE 8 (T248061) * https://phabricator.wikimedia.org/T248061 * Support for IE 8 will be maintained for the upcoming 1.35 release * Code needed for IE 8 support can be dropped from master (and Wikimedia sites) after 1.35 * has been branched in July. No office hours scheduled for next week. You can also find our meeting minutes at <https://www.mediawiki.org/wiki/Wikimedia_Technical_Committee/Minutes> See also the TechCom RFC board <https://phabricator.wikimedia.org/tag/mediawiki-rfcs/>. If you prefer you can subscribe to our newsletter here <https://www.mediawiki.org/wiki/Newsletter:TechCom_Radar> -- Daniel Kinzler Principal Software Engineer, Core Platform Wikimedia Foundation

1 0

Logging everyone out
by Tim Starling 26 Jun '20

26 Jun '20

Everyone on Wikimedia wikis will shortly be logged out and will have to log back in again. We are resetting all sessions because we believe that, due to a configuration error, session cookies may have been sent in cacheable responses. Some users reported that they saw the site as if they were logged in as someone else. We believe that the number of affected users was very small. However, we believe that resetting all sessions is a prudent measure to ensure that the impact is limited. There are several layers of protection against something like this happening, and we don't yet know how all of them failed, but we have made a configuration change which should be sufficient to prevent it from happening again. -- Tim Starling

2 3

Deployments next week (2020-06-29)
by Tyler Cipriani 25 Jun '20

25 Jun '20

Hi All, Next week is a bit of a shortened week as US Independence Day is observed on 2020-07-03 (next Friday). I've updated the Wikitech deployment calendar <https://wikitech.wikimedia.org/wiki/Deployments> to reflect that we normally discourage deploying on the last working day of any week (aside from emergencies <https://wikitech.wikimedia.org/wiki/Deployments/Emergencies>). The deployment train for 1.35.0-wmf.39 <https://phabricator.wikimedia.org/T254176> will also be running on a shortened schedule: - Tue, 30 Jun, EU Train Window, 13:00 UTC: Group0 <https://noc.wikimedia.org/conf/highlight.php?file=dblists/group0.dblist> - Wed, 01 Jul, EU Train Window, 13:00 UTC: Group <https://noc.wikimedia.org/conf/highlight.php?file=dblists/group1.dblist> 1 <https://noc.wikimedia.org/conf/highlight.php?file=dblists/group1.dblist> - Wed, 01 Jul, US Train Window, 19:00 UTC: All Wikis <https://noc.wikimedia.org/conf/highlight.php?file=dblists/all.dblist> Thanks! -- Tyler

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Wikitech-l June 2020