How do you get patches merged when you don't actually know anyone to
review it?
Sometimes you just get lucky, but sometimes you add a bunch of people, a
few others even wander in and +1 it, you ask a few people with core +2
to take a look, and then you're still waiting on a product owner to
maybe even comment at all and you can't get anyone to actually merge it
months later.
The patch I'm referring to right now is this:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Interwiki/+/501820
It adds another global inheritance feature, this time for interlanguage
links, where they can just be set once on a single wiki and other wikis
in the farm can likewise just use those instead of local ones. Separate
setting from the global interwikis because ones that would share this
will be a smaller subset than would share general interwikis.
Normally we'd just merge each other's patches in-team or go get an
actual product owner to review it, but there are a couple of problems
with this:
* The patch was co-authored by Jack Phoenix and me (and I defined the
design in the first place), so neither of us can meaningfully review
it any further than we already have. No one else has +2 here.
* We don't know any product owners (in fact we're not even sure if
there are any product owners), so we can't get them to review it.
Given the total lack of comment, normally we might just declare this
as 'nobody cares' after awhile and charge ahead regardless, but:
* Nobody else we know with general +2 is willing to merge it without
weigh-in from the product owners/actually has any time to review it
in the first place, either.
Basically, uh, can anyone else help us with this? Any of this? Given the
nature of the patch we really do kind of need it merged so it can get
translations.
-I
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi,
I (with Reedy's help) recently started work on librarizing MediaWiki's
IP class into a separate composer package (wikimedia/ip-utils[1]). The
main motivation was so that the Parsoid PHP port could use it[2].
However, I ran into an unexpected hitch[3], as it seems we're using
the IP class before the composer autoloader is even intialized. Here's
the basic initialization in Setup.php:
- - AutoLoader.php (MediaWiki's)
- - Defines.php
- - DefaultSettings.php
- $wgServer = WebRequest::detectServer()
- Calls IP::splitHostAndPort()
- - GlobalFunctions.php
- - vendor/autoload.php (composer's)
My understanding is that composer's autoloader runs late so extensions
registering themselves using it can add their stuff to the necessary
globals.
And we call WebRequest::detectServer() in DefaultSettings.php so that
in LocalSettings.php people can use the value of $wgServer for other
stuff.
I see 3 main ways to move forward:
1. Move vendor/autoload.php earlier in Setup.php, potentially breaking
extensions that still rely on composer autoloading for initialization.
2. Set $wgServer = false or something in DefaultSettings.php, and then
fill it in later in Setup.php *after* the composer autoloader has been
loaded, potentially breaking anyone relying on the value of $wgServer
in LocalSettings.php.
3. (status quo) not librarize code that runs before composer
autoloader initialization. :(
Advice/input welcome.
[1] https://packagist.org/packages/wikimedia/ip-utils
[2]
https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/77064cfff717
6493a2828bb4f95f397dfce7d659/src/Utils/Title.php#46
[3] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519089/
- -- Legoktm
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0S1oQACgkQ8QX4EBsF
Jpufrg/+J9RUUxRAtgJLEkyACE6GREis0eyEIZnWmMr3s9YpFPoqtWocFrUk6Wsn
W7d9Oda/8CW0/d894gGMn8LWIj9oWq2gMPWzCVFpg8uu3r4967qxBp+ba29uMOJw
Qpw6DhXtPvVAeUCy8P38Y5vM7TGmV+J1T5jDY21zimT1dRrJsI1KD+u/Ue3nYy/y
B1ic3i7vJfhYErdhHgN98ETXfXOaDx4rgd2N7PLjVNx3IYCC8LNiR8wSLuydfdbk
PLTT1bA2qi0h2wgcEr7Qtq9YstVotq8899rgKLtGDBwQi3qGNcdOgQGEMFDVfjfO
CsiWocj6s4oc3ScVj+Eb9xtvIqhNx+oRbWE1vKd4TmtSdyzpv6xadV60tq5qNFEY
I0cBDOWU5UFNHbvbyjK4dqIDEVhJ6LiEgLVBOj81U27s8mR4Dv/yFB3eac0ROk7p
gaEeOjfhtVU558XfpEsmu1H05VJT3kXNxK8y0UQOjy11SErzsXv6vDzyzLDJM/W7
WF0I4nyjeqVsBjLBN9li+5AnU3cAKVOCfZ+/aRYyg89Du//nJRjm+4lxnuPrGlaG
ES/nVUnkDZ9Yc/xA1yacm3Ytx9hpoY1mIZgxxxveyeU1KsNXAZ2BOGA2T7kU4yUw
Uyg+byYwI+1uVOjAVd3BInGV2R2/GmeIn9FOpthBaw8wcz0Y/8c=
=tU4+
-----END PGP SIGNATURE-----
The beta cluster will be intermittently unavailable tomorrow due to WMCS
maintenance. See forwarded message for details.
Thanks!
-- Tyler
----- Forwarded message from Andrew Bogott <abogott(a)wikimedia.org> -----
>Date: Wed, 17 Jul 2019 15:51:57 -0500
>From: Andrew Bogott <abogott(a)wikimedia.org>
>To: Release Engineering <releng(a)lists.wikimedia.org>
>Subject: [RelEng] deployment-prep outage this Friday
>
> On Friday I'm going to move many of the VMs in deployment-prep to new
> hardware. The effect of this will be rolling, intermittent outages
> throughout the project as different pieces are offline.
>
> I'll be starting in my morning, around 14:00 UTC (7AM Pacific Time). The
> total process will take several hours.
>
>
> -Andrew
>
>
> _______________________________________________
> RelEng mailing list
> RelEng(a)lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/releng
----- End forwarded message -----
Hi all,
Please have a look at https://phabricator.wikimedia.org/phame/post/view/169/changes_and_improveme… <https://phabricator.wikimedia.org/phame/post/view/169/changes_and_improveme…> regarding some significant changes and improvements to the PHP testing tools included with MediaWiki.
Your feedback and contributions are most welcome, either here, on phab, or on IRC (Amir1 and kostajh in #wikimedia-codehealth). One of us should be around during the technical advice IRC meeting tomorrow as well if you have questions about how to port your tests, run Amir’s script, or have suggestions / feedback.
Sincerely,
Kosta & Amir
Sorry for cross-posting!
Reminder: Technical Advice IRC meeting this week **Wednesday 3-4 pm UTC**
on #wikimedia-tech.
Questions can be asked in English and German!
The Technical Advice IRC Meeting (TAIM) is a weekly support event for
volunteer developers. Every Wednesday, two full-time developers are
available to help you with all your questions about Mediawiki, gadgets,
tools and more! This can be anything from "how to get started" over "who
would be the best contact for X" to specific questions on your project.
If you know already what you would like to discuss or ask, please add your
topic to the next meeting:
https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
Hope to see you there!
--
Raz Shuty
Engineering Manager
Wikimedia Deutschland e. V. | Tempelhofer Ufer 23-24 | 10963 Berlin
Phone: +49 (0)30 219 158 26-0
https://wikimedia.de
Imagine a world, in which every single human being can freely share in the
sum of all knowledge. That‘s our commitment.
Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/029/42207.