I made this RFC: https://phabricator.wikimedia.org/T240307
TL;DR: we'll have one interface per hook, and that interface will be
used for both calling and handling the hook.
It may seem like overkill, but on closer analysis, it actually seems
to work pretty nicely. There will be a place for doc comments,
arguments will be type-hinted, and smart code editors will be able to
show the hook documentation when you call or handle it.
The main open questions are:
* Where to put the many core interfaces: together or grouped by module?
* Should we split up the core HookRunner class by module? It contains
one line of boilerplate code per hook.
Existing hook handling classes in extensions can be converted to the
proposed system by:
* Changing all the handlers from static to non-static functions.
* Adding the necessary "implements" clause.
* Renaming any methods that do not already match the onHookName() pattern.
* Tweaking extension.json slightly.
I'm going on vacation soon, so I'll be aiming to move this to last
call early in the new year.
-- Tim Starling
Hi,
I've implemented two new diff themes in Gerrit's old UI. They are meant to
address the following two issues:
1. The default diff theme used in Gerrit places dark red and purple text on
a dark red background (in removed code). This can be hard to read.
Especially on a yellow-tinted monitor (e.g. Red shift, Night shift, Flux,
etc.).
2. The general use of green/red while readable, is hard to distinguish for
certain types of color-blindness.
== Theme 1: "elegant"
(Screenshot at https://phabricator.wikimedia.org/T232893)
This theme adopts the MediaWiki diff styles (yellow and blue). Which means:
* It only colours the background of the intra-line characters that were
added/changed/removed.
* The rest of the line uses a clean white background, thus providing full
colour contrast for all other syntax-highlighted code.
* The boundary of the added/removed blocks is indicated by a border (not by
absence of a background shade).
* The unchanged code lines are lightly shaded in grey (instead of the
default where these lesser important lines are given a bright white
background).
In other words, just like MediaWiki :)
== Theme 2: "eclipse"
(Screenshot at https://phabricator.wikimedia.org/T232893)
* The background greens and reds are lighter overall, stronger colour
contrast. The background reds have moved closer to orange, the greens have
moved closer toward cyan/blue.
Overall this theme is still very close to the default Gerrit theme, and
might be a good option if you've found the readability a concern but would
rather not make as much of a radical change (yet :D).
== How to change my diff theme?
>From any diff in Gerrit:
1. Click the gear icon in the top-right corner.
2. Select a Theme. (This provides a live preview!)
3. Press "Save" if you like it.
Alternatively, you can change it (without live preview) from the Settings
page:
https://gerrit.wikimedia.org/r/#/settings/diff-preferences
== What about the new UI?
The new UI already has better colour contrast in its diff styles, with
lighter background reds and greens by default.
Unfortunately the new UI has removed both the ability to theme the syntax
highlighting, as well as the ability to theme the diff colours on top of
that. Neither is changeable in the new UI currently.
For the time being I'm a hold out in the old UI as I'm unable to use review
dashboards in the new UI (until we upgrade to 2.16). Meanwhile this is
beneficial to myself and anyone else in a similar hold out.
-- Timo
Hi,
for HTML version see
https://www.mediawiki.org/wiki/Scrum_of_scrums/2019-12-11
Željko
--
= 2019-12-11 =
== Callouts ==
* Release Engineering - December 23-January 3rd - No deploys (including
train), Holiday break
* Search Platform is blocked by Structured Data: Data dumps for SDC:
[[phab:T221917]]
== Product ==
=== iOS native app ===
* Updates:
**Working on interim bug fix release 6.5.1 [[phab:project/view/4414]]
**Development on 6.6 [[phab:project/view/4273]]
***Mobile-html
***more bug fixes
=== Android native app ===
* Updates:
**Suggested Edits V3 is in Production.
**Currently working on mobile-html. Work is 70% done.
***Started looking into Machine vision APIs
=== Web ===
* Updates:
** Summary: same as last week. Planning for desktop improvements and
tapering off of advanced mode.
** [[Reading/Web/Desktop_Improvements|Desktop Improvements Project (Vector
/ DIP)]]:
*** Planning, research, and task creation
*** [[phab:T239248|<nowiki>Divide VectorTemplate into components</nowiki>]]
** Page previews (Popups):
*** [[phab:T236589|<nowiki>Page Previews Storybook not available on
doc.wikimedia.org and documentation a bit broken</nowiki>]]
** Mobile website (MinervaNeue / MobileFrontend):
*** [[Reading/Web/Advanced_mobile_contributions|Advanced mode]]:
**** [[phab:T232652|<nowiki>Add History to article toolbar for all
logged-in users</nowiki>]]
**** [[phab:T232594|<nowiki>Add article and discussion tabs to all
logged-in users on mobile</nowiki>]]
**** [[phab:T232653|<nowiki>Updates to user pages for all logged-in
users</nowiki>]]
**** [[phab:T230695|<nowiki>Render talk page as a tab (rather than a
modal)</nowiki>]]
*** Miscellaneous:
**** [[phab:T225213|<nowiki>Main Menu should work without JavaScript to be
more accessible and a better user experience</nowiki>]]
**** [[phab:T214045|<nowiki> Drawers should be removed from DOM after
close</nowiki>]]
**** [[phab:T239304|<nowiki>MinervaNeue: Desktop mode has invisible menu
button</nowiki>]]
**** [[phab:T238681|<nowiki>History icon not completely visible in smaller
screen devices</nowiki>]]
**** [[phab:T210808|<nowiki>Mark the MobileView API as deprecated</nowiki>]]
=== Product Infrastructure ===
* Updates:
** BUOD: Patch for EventLogging [[phab:T238544]]
** BUOD: Patch for error logging client [[phab:T235189]]
** Maps: investigated populate_admin error and deployed potential fix
[[phab:T240227]]
** Proton: Profiling continues with buster images for node
** MachineVIsion: Added no-JS fallback to Special:SuggestedTags
** MachineVision: Added frontend event logging to Special:SuggestedTags
** MachineVision: Updated suggestion query for performance
** MachineVision: Tweaked user approval/rejection vote validation behavior
** Push notifications: Researched approaches and software
=== Structured Data ===
* Blocking:
** dumps of MediaInfo items, see [[phab:T239905]]
** Search Platform - Data dumps for SDC: [[phab:T221917]]
* Updates:
** work continues on new input data types for statements on File page and UW
** tech talk today at 1800 UTC
=== Inuka ===
* Updates:
** Wikipedia KaiOS app: table of content [[phab:T234618]]
** Wikipedia KaiOS app: article links selection [[phab:T234625]]
=== UI Standardization ===
* Updates:
** OOUI v0.36.1 in preparation, with a hotfix for v0.36.0, which rollout we
stopped for reason of breaking backwards-compatibility in one case.
** Design Style Guide: Polishing base components in components section
== Technology ==
=== Fundraising Tech ===
* Updates:
** Have a pretty convincing explanation for apparent CentralNotice
impression inconsistencies (new campaign fallback feature changed reporting
of status codes)
** Fixing issues with new recurring donations features
** Optimizing donation imports from queue and from matching gifts
spreadsheets
=== Engineering Productivity ===
==== Release Engineering ====
* Blocking:
** Site Reliability Engineering - Requesting follow-up from Releng team
regarding Gerrit/Zuul Prometheus metrics [[gerrit:479139]]
* Updates:
** Train Health
*** Last week: 1.35.0-wmf.8 - [[phab:T233856]] - group1 + group2
*** This week: 1.35.0-wmf.10 - [[phab:T233858]]
*** Next week: 1.35.0-wmf.11 - [[phab:T233859]]
=== Scoring Platform ===
* Updates:
** Improvements to cawiki and euwiki deployed!
** Limits requests to 50 rev_ids per
** Model info now uses consistent ordering
** Advanced editquality support for Norwegian Wikipedia incoming --> Growth
** Built a machine-readable WikiProject taxonomy. See
https://github.com/halfak/wikitax
=== Search Platform ===
* Blocked by:
** Structured Data: Data dumps for SDC: [[phab:T221917]]
* Updates:
** "Wikidata Query Service Updater" should have 'bot' in the user agent to
indicate is a tool - [[phab:T238106]]
* Stuff no one else cares about:
** NullPointerException in wdqs-updater after last deployment
[[phab:T239131]]
=== Site Reliability Engineering ===
* Blocked by:
** Requesting follow-up from Releng team regarding Gerrit/Zuul Prometheus
metrics [[gerrit:479139]]
* Updates:
** Wrapping up goals/OKRs for the end of the quarter.
Hi Everyone,
It's time for Wikimedia Tech Talks 2019 Episode 11! This talk will take
place on *11 December 2019 at 6 PM UTC.*
Title: Structured Data on Commons
Speaker: Cormac Parle, Senior Software Engineer
Summary:
The talk will cover Structured Data on Commons:
- what structured is
- the structured data we store for a media file on commons
- where we store it
- how it helps with search
- the UI and the API calls we use to manipulate it
The link to the Youtube Livestream can be found here:
https://www.youtube.com/watch?v=U9LmFAkDnx0
During the live talk, you are invited to join the discussion on IRC at
#wikimedia-office
You can watch past Tech Talks here:
https://www.mediawiki.org/wiki/Tech_talks
If you are interested in giving your own tech talk, you can learn more
here:
https://www.mediawiki.org/wiki/Project:Calendar/How_to_schedule_an_event#Te…
Note: Please feel free to distribute this email to any lists that you feel
are appropriate!
Many kindnesses,
Sarah R. Rodlund
Technical Writer, Developer Advocacy
<https://meta.wikimedia.org/wiki/Developer_Advocacy>
srodlund(a)wikimedia.org
The 1.35.0-wmf.8 version of MediaWiki is blocked[0].
The train was tentatively unblocked on Friday. Details can be read
here:
* After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the
database: Unknown error"
- https://phabricator.wikimedia.org/T239877
The new version can't proceed to group2 [1] until this (new) issue is
resolved:
* "PHP Notice: Undefined index: key" and similar in Cite.php and
ReferenceStack.php
- https://phabricator.wikimedia.org/T240248
If this issues is resolved, we will attempt to roll wmf.8 forward to all
wikis today, in order that wmf.10 can proceed as usual on Tuesday.
Thank you for your help with this issue!
-- Your frazzled train drudge
[0]. <https://phabricator.wikimedia.org/T233856>
[1]. <https://tools.wmflabs.org/versions/>
Hello everyone,
On Monday this week, we enabled Parsoid/PHP everywhere for all products
(Visual Editor, Mobile Content Service, Structured Discussions aka Flow,
Content Translation) but two (Wikitext Linter, Language Variant support).
Those last two were being supported by Parsoid/JS.
However, about 30 minutes back, we disabled database updates for wikitext
lints by turning off Parsoid/JS for the wikitext linter. You can read the
details in https://phabricator.wikimedia.org/T240057 but we took the
decision in order to help mitigate cluster load issues (
https://phabricator.wikimedia.org/T239983 if you have access to the phab
task ).
This is a temporary measure and we expect to be able to enable wikitext
linter updates something in the coming week (optimistically) assuming the
mediawiki train can roll out this week.
Not to bury the lede or anything (late on a Friday evening in the US
timezones), but we have now effectively switched over from Parsoid/JS to
Parsoid/PHP on the Wikimedia cluster. Once we have moved over language
variant support from Parsoid/JS to Parsoid/PHP and wrapped up any other
loose ends and tied a neat bow around it all, we'll be publishing a blog
post about the Parsoid/PHP porting and rollout process.
Subbu (on behalf of the Parsing team).
Hi All,
On* 5, December 2019, 8 PM UTC*, we'll welcome Camille Fournier for a
special edition of Wikimedia Tech talks! Camille will share insights from
her career and discuss her book, “The Manager’s Path: A Guide for Tech
Leaders Navigating Growth and Change
<https://www.amazon.com/Managers-Path-Leaders-Navigating-Growth-ebook/dp/B06…>
.”
Camille Fournier is the head of Platform Engineering at Two Sigma, a
financial company in New York City. Prior to joining Two Sigma, she was
the Chief Technology Officer of Rent the Runway
<https://www.renttherunway.com/>, a transformative brand that offers
unprecedented access to designer fashion, disrupting the way millions of
women get dressed.
She is an Open Source contributor and project committee member for both
Apache ZooKeeper and the Dropwizard web framework. Prior to working for
Rent the Runway, Camille served as a software engineer at Microsoft, and
most recently, spent several years as a technical specialist at Goldman
Sachs, creating distributed systems for managing risk analysis and firmwide
infrastructure.
She has a BS in Computer Science from Carnegie Mellon University and an MS
in Computer Science from the University of Wisconsin-Madison. Camille is a
well-respected voice within the tech community, speaking on a variety of
topics such as engineering leadership, distributed systems, scaling teams,
and technical architecture.
You can view the talk live and ask questions here:
https://www.youtube.com/watch?v=mNtFUt0vR58
Questions will also be taken through #wikimedia-office IRC
*Feel free to share this announcement! *
Kindly,
Sarah R. Rodlund
Technical Writer, Developer Advocacy
<https://meta.wikimedia.org/wiki/Developer_Advocacy>
srodlund(a)wikimedia.org
Hello,
CI has jobs to build Debian packages, I have moved them from Jessie to
Buster instances.
Building the package is made in a build environment matching the target
distribution (using cowbuilder), but some operations are executed on the
host. There might be side effect as a result of the upgrade.
For the utilities I can think of:
pbuilder 0.215 > 0.230.4
* which notably cause the building user to have a home directory set to
a non existent path /nonexistent
pristine-tar 1.33 > 1.46
* add support for delta version 3
git-buildpackage 0.6.22 > 0.9.14
If you see any oddity in the debian-glue* CI jobs, please fill a task in
Phabricator against #continuous-integration-infrastructure.
The migration task was:
Migrate debian-glue jobs to Buster instances
https://phabricator.wikimedia.org/T224943
--
Antoine "hashar" Musso
Next Wednesday, December 4th, at 00:00 UTC (4pm San Francisco) there will be
a Phabricator upgrade window that might last up to 2 hours.
While we expect downtime to be much shorter than that Phabricator might be
unreachable in that time frame.
We are switching the production Phabricator server to a buster (Debian
stable) machine.
https://phabricator.wikimedia.org/T238956
--
Daniel Zahn <dzahn(a)wikimedia.org>
Operations Engineer