Starting today, immediately after SWAT, thcipriani noticed a new error in
fatalmonitor which appeared to coincide with running scap. The curious
thing is that scap only affected localization, no code was changed.
At that point I took over for thcipriani and filed an UBN bug:
https://phabricator.wikimedia.org/T168681
The error message:
Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must
be an instance of array, string given in
extensions/Wikidata/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php
on line 141
After monitoring the errors in kibana for a while I noticed a pattern: the
error rate is changing in a very consistent way. The graph of errors makes
an almost perfect sine wave, peaking at about 150 per minute and then
bottoming out at zero. This pattern has repeated all afternoon. It seems
like such a consistent pattern could only be caused by either a) a queued
job or b) an api client. Since the bug is reproducible via the API, I
suspect that it's b.
As of now it I believe this error to be unrelated to any recent code
deployments. The timing might have just been coincidence. If that is the
case then it should not block the train any further, however, Greg made the
call to postpone further deployments until tomorrow.
If you have any input on this error, please comment on the phabricator
task. You can also ping me on IRC, I will be around for much of the evening.
Thanks, that is all I've got for now.
- Mukunda
congrats
Zppix
Volunteer developer for WMF
enwp.org/User:Zppix
On Jun 19, 2017 9:50 AM, "Daniel Kinzler" <daniel.kinzler(a)wikimedia.de>
wrote:
Excellent! Well earned!
Am 19.06.2017 um 10:32 schrieb Antoine Musso:
> On 13/06/2017 04:24, Legoktm wrote:
>> Hi,
>>
>> Ladsgroup filed a request[1] for +2 in mediawiki/* repos that I missed
>> until now, and hadn't been sent to this mailing list. Please comment if
>> you haven't already and I'll close it in a few days.
>>
>> [1] https://phabricator.wikimedia.org/T165860
>>
>> -- Legoktm
>
> Hello,
>
> Amir now has +2 rights in Gerrit for the mediawiki/* repositories.
>
>
--
Daniel Kinzler
Principal Platform Engineer
Wikimedia Deutschland
Gesellschaft zur Förderung Freien Wissens e.V.
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
https://www.mediawiki.org/wiki/Scrum_of_scrums/2017-06-14
= 2017-06-14 =
contact: https://www.mediawiki.org/wiki/Wikimedia_Engineering
== Call-outs ==
* Input requested for MediaWiki extension build processes at
https://phabricator.wikimedia.org/T158980
* Reading Lists RfC https://phabricator.wikimedia.org/T164990
== Audiences ==
=== Readers ===
==== iOS native app ====
* Finishing up 5.5 (Places, Explore feed updates) -
https://phabricator.wikimedia.org/project/view/2602/
** Regression testing & fixing remaining issues
** Submit to the App Store this week
** Upgrading to Xcode 9 and other code cleanup
==== Android native app ====
* New release is out! Crashes very low.
* Current release board theme: reading list syncing UI
** Board: https://phabricator.wikimedia.org/project/view/2763/
* New engineer hiring process underway.
==== Reading Web ====
* Your input is requested in `wikitech-l] How does a build process look
like for a mediawiki extension repository?` regarding building client side
assets(https://phabricator.wikimedia.org/T158980)
* INFO: Disable images functionality will be removed from MobileFrontend (
https://phabricator.wikimedia.org/T109870)
==== Reading Infrastructure ====
* Limit video transforms to videos to not affect audio
* read-html endpoint + coming up with plan to lazy load reference
information
* Providing support to Reading Web for the OCG replacement work
* Reading Lists RfC happening in a few hours:
https://phabricator.wikimedia.org/T164990
==== Multimedia ====
* No blockers, not blocking
* 3D work proceeding apace, discussions with community to come - estimated
to be pushed out next quarter
* We have an eye on the MP3 discussions, but nothing currently pressing -
no current rollout plan that I know of
* Hiring process also continuing
=== Discovery ===
* No update.
=== Community Tech ===
* Starting work on HTML5 section IDs
* Testing/bugfixes for LoginNotify before wider deployment
* Rewriting XTools
* Preparing CodeMirror for deployment
** Blocked on design (https://phabricator.wikimedia.org/T165541)
=== Contributors ===
==== Editing ====
* Blocked by: None.
* Blocking: None known.
==== Parsing ====
* Linter will be re-enabled on large wikis this week
* Red link support is now on beta cluster. Now undertaking rt testing to
ensure we haven't broken anything + will run visual diff testing later
tonight. If nothing broken, will deploy to production next week.
* Final reviews in progress for language variant support in Parsoid
* We are hiring!
https://boards.greenhouse.io/wikimedia/jobs/722082?gh_src=jseinu1#.WUFhljeQ…
--
please spread the word (and please ask them to read the JD and requirements
;-)).
==== Collaboration ====
* Blocked by: None.
* Blocking: None known.
* Updates
** Change to URL handling for RC Filters
** A lot of in-progress work on RC Filters that's not merged yet
==== Language ====
* Blocked: Services to reply on,
https://github.com/wikimedia/restbase/pull/796
* Updates:
** ContentTranslation OOjs UI work continue.
** fra-cat and spa-ita Apertium pairs updated.
==== Contributors Design ====
* This week:
** Cleaning-up WikimediaUI Style Guide workboard
** Overhauling “Icons” section at style guide
https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_icons.html
** Early-on patches for “Components” section
** Further work on integrating WikimediaUI Base
https://phabricator.wikimedia.org/source/wikimedia-ui-base/ into
WikimediaUI theme of OOjs UI
== Technology ==
=== Analytics ===
* Redundant Announcement: RCStream clients using socket.io will be
deprecated on July 7th, we pinged everyone and offered help to move to
EventStreams, but if anyone knows stragglers point them to us
* Ongoing:
- ** purging EventLogging data: most schemas done
- ** preparing for Kafka upgrade
- ** setting up project-wide unique devices for internal access: jobs
productionized
- ** first version of wikistats 2.0: using Crossfilter as the main data
model
=== Cloud Services ===
* No update.
=== Fundraising Tech ===
* Blocked by: Nothing
* Blocking: None we know of
* Deployed Banner Sequence feature to Central Notice Monday, looking good
so far
* More CiviCRM <-> 3rd party mailhaus integration
* Moving more stuff from MediaWiki extension to better-organized library
* Better error handling for potential inadvertently duplicated donations
=== MediaWiki Platform ===
* No update.
=== Performance ===
* No update.
=== Release Engineering ===
* Blocked by: None
* Blocking: None?
* Updates:
** Chad working on MW 1.29 release
https://phabricator.wikimedia.org/project/view/2400/
** 1.30.0-wmf.5 rolling out this week
https://phabricator.wikimedia.org/T167533
** Phab now has "types" of task. See e.g.
https://phabricator.wikimedia.org/T167893
=== Research ===
* Blocked by:
* Blocking:
* Updates:
** New service request filed for Recommendation API
*** https://phabricator.wikimedia.org/T167664
=== Scoring Platform ===
* Blocked by:
* Blocking:
* Updates:
** ORES had an intermittent outage on 13 June
*** https://wikitech.wikimedia.org/wiki/Incident_documentation/20170613-ORES
=== Search Platform ===
* Formerly known as half of "Discovery"
* Chinese and Hebrew analyzers deployed, waiting for plugin deployment (
https://phabricator.wikimedia.org/T167057) and reindex, working on Japanese
* Working on upgrade to Elastic 5.3.2 (perf issues:
https://phabricator.wikimedia.org/T167636)
* Cross-wiki search being deployed (
https://phabricator.wikimedia.org/T162276)
* Starting load-testing ML-assistend ranking on relforge
* WDQS Mediawiki API service announced -
https://www.wikidata.org/wiki/Wikidata:Project_chat#Mediawiki_API_Service_f…
=== Security ===
* Reviews:
** psy/psysh use on WMF servers
** Verification of whitelisted.yaml / graylisted.yaml
** Auto-approval of low-risk OAuth applications
** Ex:JsonConfig/Ex:Kartographer
=== Services ===
* Blocked by: none
* Blocking: none
* Updates:
** Working on the minikube setup for container-based development
environment
** Automatic blacklisting in Change-Propagation deployed. Only logging
for now
=== Technical Operations ===
* '''Blocked by''':
** No one
* '''Blocking''':
** No one
* '''Updates''':
** HHVM 3.18 has been deployed
== Wikidata ==
* No blockers.
* Call for submissions for WikidataCon:
https://www.wikidata.org/wiki/Wikidata:WikidataCon_2017
* Added a new Lua function: https://phabricator.wikimedia.org/T74815
* Working on the Senses part of the Lexeme UI (using Vue JS including
server side rendering): https://phabricator.wikimedia.org/T163723
* More fine tuning on Constraints Reports. Looking for a way to have a
version controlled Gadget: https://phabricator.wikimedia.org/T167126
* Wikidata support in enhanced RC: https://phabricator.wikimedia.org/T46874
* Populating a new column in our giant wb_terms table:
https://phabricator.wikimedia.org/T162533
== German Technical Wishlist ==
* No blockers.
* Preparing the current round of wishes for voting:
https://de.wikipedia.org/wiki/Wikipedia:Technische_W%C3%BCnsche
https://www.mediawiki.org/wiki/Scrum_of_scrums/2017-06-21
*= 2017-06-21 =*
contact: https://www.mediawiki.org/wiki/Wikimedia_Engineering
== Callouts ==
* Could use some input from performance and/or cloud people as to the
efficacy of 3d2png on the beta cluster - currently planning to upload ~1000
STL files at around 400kb each and thumbnail them to see what the load hit
is like. https://phabricator.wikimedia.org/T166699
* Beginning to look at improving HTML summaries for purpose of "page
previews" feature. Likely to need help/input from services
https://phabricator.wikimedia.org/T113094
* CommTech would love feedback on https://phabricator.wikimedia.org/T152540
* codfw row A switch upgrade Thurs 29th
https://phabricator.wikimedia.org/T168462
* Thumbor deployed to wikipedias, commons next week
https://phabricator.wikimedia.org/T121388
* restbase2001 is depooled for experiments and it should stay depooled
* some input on https://phabricator.wikimedia.org/T159922 and
https://phabricator.wikimedia.org/T166188 would be welcome
* feedback welcome on https://phabricator.wikimedia.org/T133178
== Audiences ==
=== Readers ===
==== iOS native app ====
* Released 5.5 (Places, Explore feed updates) -
https://phabricator.wikimedia.org/project/view/2602/
* 5.5.1 (bug fixes & enhancements) -
https://phabricator.wikimedia.org/project/view/2789/
* 5.6 (dark mode, on this day) -
https://phabricator.wikimedia.org/project/view/2701/
* No blockers
==== Android native app ====
* Still working on reading list syncing UI, not immediately
blocked/blocking as far as we know.
** Board: https://phabricator.wikimedia.org/project/view/2763/
* New engineer hiring process is underway.
==== Reading Web ====
* Removed ability for users to disable images. Ops there is a VCL change
https://phabricator.wikimedia.org/T109870
* Beginning to look at improving HTML summaries for purpose of "page
previews" feature. Likely to need help/input from services (
https://phabricator.wikimedia.org/T113094
==== Reading Infrastructure ====
* read-html endpoint in code review
* upcoming: add scripts to measure payload sizes + lazy loading of
references
* testing OCG replacement candidates
* broke and fixed recentchanges (T167922)
==== Multimedia ====
* Not blocking, not blocked
* Could use some input from performance and/or cloud people as to the
efficacy of 3d2png on the beta cluster - currently planning to upload ~1000
STL files at around 400kb each and thumbnail them to see what the load hit
is like. https://phabricator.wikimedia.org/T166699
==== Discovery ====
* Blocked by:
* Blocking:
* Work proceeds on style/vector tile schema changes -
https://phabricator.wikimedia.org/T153282 and many sub-issues
* Debugging stalled map updates on production -
https://phabricator.wikimedia.org/T168241
=== Community Tech ===
* Blocked by: Would love feedback on
https://phabricator.wikimedia.org/T152540 regarding HTML5 section IDs
* XTools rewrite (http://tools.wmflabs.org/xtools-dev/)
* CodeMirror - soon to be deployed as a Beta Feature on Test Wikipedia
* LoginNotify - Adding notifications for successful logins from an unknown
device
* HTML5 section IDs - stalled
=== Contributors ===
==== Parsing ====
* Blocked by:
** https://gerrit.wikimedia.org/r/#/c/350830/ has been stuck in review
queue for a while now (Krinkle last took a look at it)
* Blocking:
* Updates
** Linter extension was reenabled on all wikis.
** Redlink annotations were attempted to be deployed, but canaries alerted
us to some title normalization issues that are being looked into. Should go
out next week (or two, if we need a patch to ride the MediaWiki train)
** Pig Latin merged in core: other work on language variant support to land
soon in Parsoid (and hopefully VE as well)
==== Collaboration ====
* Blocked by:
* Blocking:
* Updates
** RC Filters front-end improvements
*** RCFilters: Add edit tags drop down
*** RCFilters: Always replaceState the URL ({{phabricator|T167919}})
*** RCFilters: Add 'views' concept and a namespace view to RCFilters
({{phabricator|T159942}}, {{phabricator|T163521}}, {{phabricator|T164130}})
*** RCFilters: Make frontend URL follow backend rules and add
'urlversion=2' ({{phabricator|T166907}}, {{phabricator|T166972}},
{{phabricator|T166974}})
*** RCFilters: Send form info even for empty checkboxes
** RC Filters back-end improvements
*** ChangesListSpecialPage: Add urlversion and make urlversion=2 ignore
defaults ({{phabricator|T166906}})
** Other small RC-related changes
** PageTriage - Don't show the 'Possible issues' section in the info flyout
if it is empty ({{phabricator|T147220}})
** Some minor Flow fixes
==== Language ====
* Blocked by: None
* Blocking: None
* Updates:
** CX OOjsUI work continue.
== Technology ==
=== Analytics ===
* Again -- Redundant Announcement: RCStream clients using socket.io will be
deprecated on July 7th, we pinged everyone and offered help to move to
EventStreams, but if anyone knows stragglers point them to us
* Blocked by: --
* Blocking: --
* Ongoing
- ** purging EventLogging data: Performance issues coworked with DBAs
- ** Ongoing work on Webrequest tagging helping functions
- ** wikistats 2.0: Development continues
=== Research ===
* Blocked by: none
* Blocking: none
* Updates:
** Reader survey for 14 wikis scheduled for Thursday, 22 June
*** Will run for approximately one week, but may (unlikely) need two
*** https://phabricator.wikimedia.org/T131949#3361478
=== Search Platform ===
* Blocked by:
* Blocking:
* Continuing work on ML-assisted search ranking, performance testing
* Fixed breakage in cross-language search due to deploy of sister-wiki
search (https://phabricator.wikimedia.org/T168302)
* Ukrainian, Chinese language analyzers deployed. Swedish got improved
configuration recognizing letters with diacritics as distinct. (
https://phabricator.wikimedia.org/T160562)
* Dasboards migrated to puppet setup (
https://phabricator.wikimedia.org/T161354)
** This also includes reusable puppet module for creating Shiny server:
https://lists.wikimedia.org/pipermail/wikitech-l/2017-June/088374.html
=== Security ===
* Blocked by: none
* Blocking: none
* Reviews:
** psy/psysh use on WMF servers
** Auto-approval of low-risk OAuth applications
** Ex:JsonConfig/Ex:Kartographer
=== Services ===
* Blocked by: none
* Blocking: none
* Updates:
** Having troubles with new version of node cassandra driver
*** restbase2001 is depooled for experiments and it should stay depooled
** Electron PDF service failures
*** Some input on https://phabricator.wikimedia.org/T159922 and
https://phabricator.wikimedia.org/T166188
** Discussing missing support for RESTBase on www.wikimedia.org
*** Feedback welcome on https://phabricator.wikimedia.org/T133178
** Red links support in Parsoid HTML and MCS is coming soon
*** https://phabricator.wikimedia.org/T39902 and
https://phabricator.wikimedia.org/T133221
=== Technical Operations ===
* Blocked by: none
* Blocking: none
* Updates:
** Thumbor deployed to wikipedias, commons next week
https://phabricator.wikimedia.org/T121388
** Minor incident regarding citoid and nih.gov.
https://phabricator.wikimedia.org/T133696#3350683
** WP0 abuse on phabricator https://phabricator.wikimedia.org/T168142
** codfw row A switch upgrade Thurs 29th
https://phabricator.wikimedia.org/T168462
== Wikidata ==
* No blockers.
* Continued working on the Lexeme UI:
https://phabricator.wikimedia.org/T160053
Howdy,
Happy to report that production[1] and development[2] sets of Discovery
Dashboards are up and running again, this time managed by Puppet. (There
was a bug with web proxies and DNS settings that delayed this
announcement.) Theoretically they should be snappier to use now because
there is no longer an extra virtualization (Vagrant) layer and they are
running directly on Labs instances.
R is a software and programming language mainly used for statistical
inference, machine learning, and data wrangling & visualization. RStudio's
Shiny[3] is a framework for developing web applications in R, and it's what
Discovery's dashboards are written in.
The Reading::Discovery::Analysis team (with guidance and help from
Guillaume Lederrey) is proud to announce a new module available in Ops'
Puppet repo: shiny_server[4], which installs & configures RStudio's Shiny
Server[5] for serving R/Shiny applications. The module also provides
resources for installing R packages from CRAN, GitHub, and other remote git
repositories like Gerrit. For a practical example, refer to Discovery
Dashboards base[6] and production[7] profiles.
Cheers,
Mikhail on behalf of Discovery Analysts
[1] https://discovery.wmflabs.org
[2] https://discovery-beta.wmflabs.org/
[3] https://shiny.rstudio.com/
[4] https://github.com/wikimedia/puppet/tree/production/modules/shiny_server
[5] https://www.rstudio.com/products/shiny/shiny-server/
[6]
https://github.com/wikimedia/puppet/blob/production/modules/profile/manifes…
[7]
https://github.com/wikimedia/puppet/blob/production/modules/profile/manifes…
Can you advice how to create equivalent properties to a fresh Wikibase as
exist in Wikidata? Everything cannot be replicated, but having equivalent
IDs would be positive, and as much related information as possible.
Best
Susanna
Hi!
MediaWiki-CodeSniffer 0.9.0 is now available for use in your MediaWiki
extensions and other projects. Here are the notable changes since the
last release:
* Add sniff to enforce "function (" for closures (Kunal Mehta)
* Add usage of && in generic_pass (addshore)
* Disallow `and` and `or` (Kunal Mehta)
* Don't require documentation for constructors without parameters (Kunal
Mehta)
* Don't require documentation for '__toString' (Kunal Mehta)
* Don't require return/throws/param for doc blocks with @inheritDoc
(Kunal Mehta)
* Expand list of standard methods that don't need documentation (Kunal
Mehta)
* Fix FunctionComment.Missing sniff code (Kunal Mehta)
* Fix indentation (Umherirrender)
* Fix WhiteSpace/SpaceAfterClosureSniff (Antoine Musso)
* Make sure all files end with a newline (Kunal Mehta)
* test: ensure consistent report width (Antoine Musso)
* Update for CodeSniffer 3.0 (Kunal Mehta)
* Update squizlabs/PHP_CodeSniffer to 3.0.1 (Reedy)
* Use upstream CharacterBeforePHPOpeningTag sniff (Kunal Mehta)
The 3.0 upstream release should bring in a lot of under-the-hood
improvements, including support for parallel processing!
Note that due to an upstream bug, PHPCS 3.x doesn't work with repos that
have "prepend-autoloader": false set.
I've begun to submit patches to upgrade to the latest version and
automatically fix some of the issues:
<https://gerrit.wikimedia.org/r/#/q/topic:bump-dev-deps+status:open>.
Thanks to everyone who contributed to this release, please file bugs or
feature requests in the MediaWiki-Codesniffer Phabricator project if you
find any.
-- Legoktm
Hi all,
I've been working on enhancing the Theme extension [1] to add a
preference option so that registered users can set their preferred
theme [2], just like how they can set a skin and other such options.
The theme selector is shown on Special:Preferences, below the list of
available skins, and since themes are nothing but a set of CSS
modifications on top of a skin's base CSS, previewing them in real
time is easy. Or so I thought, anyway.
Turns out that this is a bit more complicated than that. I'm loading
the theme-specific CSS module via mw.loader.load(), which seems to
append a <style> tag to the <head> of the page.
To prevent "stacking" of theme CSS and to ensure that themes will
display as intended, I'm using $( 'head style' ).last().remove(); to
remove the last added <style> tag from head. This has the unintended
side-effect that previewing a theme works only once, and after that
the theme CSS is no longer applied because ResourceLoader thinks it
has already been loaded.
What would be the proper way to signal to ResourceLoader, "actually I
need you to load this module again"?
To test out my patch [2], you'll need a skin which supports themes,
such as MonoBook or Vector. Then simply git clone the
mediawiki/extensions/Theme repository, apply the patch on top of that,
load the extension via wfLoadExtension( 'Theme' ); in
LocalSettings.php (you may also need to set $wgDefaultTheme =
'default'; in your LocalSettings.php) and then visit
Special:Preferences and you should see the new "Theme" drop-down menu
there.
[1] https://www.mediawiki.org/wiki/Extension:Theme
[2] https://gerrit.wikimedia.org/r/#/c/359643/
Thanks and regards,
--
Jack Phoenix
MediaWiki developer
Hi,
Ladsgroup filed a request[1] for +2 in mediawiki/* repos that I missed
until now, and hadn't been sent to this mailing list. Please comment if
you haven't already and I'll close it in a few days.
[1] https://phabricator.wikimedia.org/T165860
-- Legoktm