Hey guys!
Google has its own loader called jsapi which typically is included as following:
<script type="text/javascript" src="http://www.google.com/jsapi"></script>
How can I include it using $wgResourceModules to use in my extension?
-----
Yury Katkov, WikiVote
Is it dangerous to call WikiPage->doEdit inside a parser tag callback?
I'm writing a parser tag extension <whatever>, whose callback function is:
public static function myCallback($input, $argv, $parser) {
$t = Title::newFromText('anytitle'); // any article title at all
$p = WikiPage::factory($t);
$p->doEdit('my text', 'my comment');
return 'foo';
}
The doEdit always succeeds (based on its return Status).
But somewhere later, as the parser tag renders, the following error always gets thrown:
Invalid marker: UNIQ586469ef5f8b5a1a-whatever-00000000-QINU
Backtrace:
#0 /var/www/html/w/includes/parser/StripState.php(66): StripState->addItem('general', 'UNIQ586469ef5f...', 'foo')
#1 /var/www/html/w/includes/parser/Parser.php(3844): StripState->addGeneral('UNIQ586469ef5f...', 'foo')
#2 /var/www/html/w/includes/parser/Preprocessor_DOM.php(1150): Parser->extensionSubstitution(Array, Object(PPFrame_DOM))
#3 /var/www/html/w/includes/parser/Parser.php(3038): PPFrame_DOM->expand(Object(PPNode_DOM), 0)
#4 /var/www/html/w/includes/parser/Parser.php(1136): Parser->replaceVariables('<whatever/>')
#5 /var/www/html/w/includes/parser/Parser.php(370): Parser->internalParse('<whatever/>')
#6 /var/www/html/w/includes/WikiPage.php(3110): Parser->parse('<whatever/>', Object(Title), Object(ParserOptions), true, true, 1429350)
#7 /var/www/html/w/includes/PoolCounter.php(209): PoolWorkArticleView->doWork()
#8 /var/www/html/w/includes/Article.php(631): PoolCounterWork->execute()
#9 /var/www/html/w/includes/actions/ViewAction.php(37): Article->view()
#10 /var/www/html/w/includes/Wiki.php(427): ViewAction->show()
#11 /var/www/html/w/includes/Wiki.php(304): MediaWiki->performAction(Object(Article))
#12 /var/www/html/w/includes/Wiki.php(536): MediaWiki->performRequest()
#13 /var/www/html/w/includes/Wiki.php(446): MediaWiki->main()
#14 /var/www/html/w/index.php(75): MediaWiki->run()
#15 {main}
So I am wondering: is it dangerous to call doEdit inside a parser tag's callback?
Is there another way to make a parser tag create an article?
This is MediaWiki 1.20.
Thank you,
DanB
I am posting this to wikitech-l, ee-l, and will cross-post this to https://bugzilla.wikimedia.org/show_bug.cgi?id=35306 because it's important to keep frank discussions in the open.
When I use to loaded words like "back-dooring" etc, I believe that no malice was intended and the discussions so far have been in good faith from all parties. I think people have a valid concern and want it addressed and are wondering honestly how decisions have been made. In particular, my decision to not allow the MassMessage Extension to roll out onto MediaWiki last week, since that occurred during a meeting that didn't even involve or derive have consultation (except ex-post-facto) with any product manager or engineer here.
Here is why I am inijating this thread:
1) https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=83188&old…
2) On Sep 30, 2013, at 4:25 PM, MZMcBride <z(a)mzmcbride.com> wrote:
> Hi Fabrice, Terry, and Howie,
>
> https://bugzilla.wikimedia.org/show_bug.cgi?id=35306#c19 is awaiting feedback (if you have any).
>
> MZ
3) https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=84903&old…
…
We have two separate but related bugs here:
https://bugzilla.wikimedia.org/show_bug.cgi?id=35306https://bugzilla.wikimedia.org/show_bug.cgi?id=52723
bug 35306 is an tracking bug MZMcBride posted for a solution to deal with EdwardsBot. I believe it dates to around the time I was first employed almost two years ago.
bug 52723 is a recent bug to deploy Legoktm's MassMessage extension as a solution to bug 35306, it is less than a month old there has been little public discussion, and until it appeared on the deploy calendar last week, I wasn't even aware of its existence.
The problem with moving on bug 52723 as a solution to bug 35306 is it commits Features Engineering to maintaining an extension that is a stop gap solution with no or very little discussion in a manner that doesn't serve a broad strategic goal about how messages, notifications, etc. should be handled on the wikis. To the first, maybe there is something wrong with my e-mail client, but I have yet to find this discussion on wikitech-l or anywhere outside the bug.
Because of the above, my view is that this solution is being back-doored in and just moves the "technical debt" from one sheet (the community and tool labs) to another that has even less capability. I am biased against that because the latter sheet (WMF Features Engineering) is my responsibility. This is just my view, I'm open for us coming to consensus on a solution for this bug, but what I have seen is not consensus.
It is along these lines that, I asked to remove MassMessage from the deploy calendar when it was added to the deploy calendar without discussion from Features, Design, or Product last week. After discussion during that Friday meeting among the EPMs, I compromised to let it to go out on two test wikis, but not on mediawiki. Nobody made the case that it should go out on mediawiki. I demurred because no person at the WMF, including me as Director of Features Engineering, should fiat a decision when unaware of the status of discussions involved.
But let frank: if this had been a WMF employee writing this extension, it wouldn't have made it to even the test wikis by a country mile. In fact, a lot of extensions have been written by employees and either have extensive discussion, review, and buy-in (e.g. GuidedTours), or have not been deployed (e.g. Etherpad, the org chart, BetaFeatures) even though much more work has been done on them.
I also don't like that WMF resources in Platform and Design are being spent to review something that has had no adequate discussion over in the annual plan, in anyone's 20% time, in any cross-team discussion, or public discussion on wikitech-l (There was a last minute thread in the Design list, I am not on the design list, nor should I be, and the Creative Director is new and the team is just trying to get their sea legs and some consideration to that needs to be done here). Furthermore, after further discussion, nearly all of Product felt I should not have compromised earlier because the following situation might occur: Having gotten it onto "the cluster" people would then move to back-door it into deployment on the basis that it's already on the cluster. Their prediction is occurring right now. This is a bogus argument because nobody agreed this should be on the cluster, it's just that nobody has reviewed it in a thorough enough manner to shout "NO!"
If necessary, I'm going to shout "NO!" at this moment.
Having said that, there is the larger issue of bug 35306 which has been sitting there unsolved for a while as well as the smaller issue of the month's work Legoktm and MZMcBride have already put into Bug 52723 and [[mw:Extension:MassMessage]] possibly going to waste if I keep blocking it. Besides, MZ is sitting there trying to hold everything up on his own shoulders with EdwardsBot, and we all know it.
…
Let me address the functionality overlap with Echo:
LanguageEngineering built their own parallel message/notification system before Echo that lives on Meta today. They commit to supporting their own parallel message/notification system, and I'm okay with it living outside Echo (where it currently does), but there is an understanding that they've basically committed to that work with no support from Features for the duration that it does live outside Echo.
In those lines, I'm glad that Platform has helped out here, but unless Platform is committing to support MassMessage indefinitely into the future and not just provide one-time security and deploy assistance, I'm not okay with them adding to Features work even though they've been super helpful to MZMcBride and Legoktm. If Dan Garry is willing to commit Platform to support MassMessage, I'll think the same precedent we've done with LE applies here.
Furthermore, before *in-echo, outside-echo, use-echo) for a solution to be bug 35306, it needs to actually exhibit product discipline. The WMF gets panned for having a "agile processes" but not actually doing so, but we do have some process and we need to at least apply the same product discipline that we apply everywhere else to this bug.
For example, features in MassMessage and EdwardsBot need to be addressed in a Must-Have, Should-Have, Could-Have, Won't-Have (MoSCoW) framework. Features like "mass delivery from a list" are probably a Must-Have; features like "cross-wiki notification" are probably a should-have, other features like "public over private notifications", "page-centric over user-centric" or "longer stream notifications" are either not a must-have or could have or are should-haves to be done outside Echo by a different service (bot) using the Echo API or some extension thereof. All that is a product issue, and I nor anyone in my team is in product. Those decisions should be done in discussion with the Product team and they should not be disintermediated from it, which they have been.
I understand that many people would like to see a solution to Bug 35306 would be great to have. I'd like to see a better Signpost notification system and a more generalized solution for newsletter delivery also! I'd also like a pony. But we have already committed resources and continue to commit resources without discussion from the people (Product Design, not Features Engineering) who have been tasked with this responsibility and are very good at these sort of thing. I hope everyone participating on this bug can see that dropping this bomb on a newly hired associate product manager is simply not cool on so many levels.
…
Here is my suggestion:
(This is thinking, not a directive so don't think of this as definitive or final, I'm seeking consensus here.)
First, bug 35306 is a long-standing request. I think it's important we get headway on this, but I hope others will be understanding if it doesn't happen immediately, so long as there is a commitment for this to happen.
(For perspective, Flow was first proposed years ago, and was added to the annual plan almost two years ago before their first actual development sprint was completed (end of this week!). Echo was first deployed almost 8 months ago and is still not out on all the wikis. BetaFeatures has been in discussion for months and is still not deployed, nor is the commitment to maintain inside Features and that has caused a lot of issues. Fixing things right right takes time because consensus takes time and open discussion.)
There is an RfP for student developer time for legoktm for things like this (Finding a solution for Bug 35306 but not [[mw:Extension:MassMessage]] because MassMessage would not be deployed if it was my own engineer). Benny Situ has been spending all his time supporting [[mw:Extension:Echo]] when he should balancing [[mw:Flow]] development time into Echo bug fixes and needs to spend at least one sprint (two weeks) solely getting up to speed on Flow before doing enhancements for [[wm:Echo]]. Furthermore, Echo is not deployed everywhere yet and is still rolling out (though I've been pushing up the timetable on this as I feel we're too slow here), so it can't reach the places that EdwardsBot cat.
After the above happen, I'd like Benny and Kunal to work together to add some of the functionality of EdwardsBot into Echo for mass message delivery. Because of this, I'm moving bug 35306 into Echo as an enhancement and raising it's priority.
In the meantime I'll be OK with leaving MassMessage on test and test2 wikis because the alternative would be to remove it from the cluster entirely. The experiences and code Kunal derives by that can inform the enhancement to Echo, as well as things it already does that find themselves outside Echo (Echo does not and should not post to talk pages). So I figure two stages:
1) wait for some things to happen: legoktm to get an RfP, Echo to be on all wikis, and Benny to do an entire Flow only sprint and balancing his time more effectively wrt Echo.
2) MoSCoW other features of MassMessage/EdwardsBot for integration into Echo
3) Enhance and deploy a first pass to Echo to allow some sort of mass notification from a wiki list
4) Some sort of cross wiki notification enhancement (requires a design pass)
5) Discuss how to implement must-have or should-have features of EdwardsBot that can't live in Echo (permanent log of events)?
6) Add those to plan and be done.
The above can occur independently or in parallel to the above. If Product thinks it cool to commit Platform's constrained engineering resources to deploying and supporting MassMessage Extension forever and use it to take advantage of Echo when the features roll out in some undefined future, consider this thinking moot or at least orthogonal to MassMessage. IMO, it is bad enough that something important like BetaFeatures is without a home, but my answer from Features is "No" for MassMessage. If this was my own engineer, I'd raise hell with them for this and yell at their Product Manager for not being a good steward of Platform's time.
Take care,
terry
terry chay 최태리
Director of Features Engineering
Wikimedia Foundation
“Imagine a world in which every single human being can freely share in the sum of all knowledge. That's our commitment.”
p: +1 (415) 839-6885 x6832
m: +1 (408) 480-8902
e: tchay(a)wikimedia.org
i: http://terrychay.com/
w: http://meta.wikimedia.org/wiki/User:Tychay
aim: terrychay
On Oct 4, the change to "Turn screen.css into screen.less"[1] was merged
and broke the appearance of the installer. It is still usable, but
styling is lost. I opened bug #55589 for this problem.
As much work as we've done with Jenkins, this problem shows a gap in our
testing -- the web-based installer.
As we begin to prepare for the release of 1.22, I'd like people to start
exercising the installer some more. I'm working on finishing up my
solution for bugs #42205 (XML support) and #43817 (short descriptions
for bundled extensions), but I'd like to make sure there isn't anything
missing that I don't know about.
If there are bugs you think I should be aware of before the release --
in the installer or otherwise -- please add me to the CC list and
(optionally) send me a separate email.
Mark.
[1] https://gerrit.wikimedia.org/r/#/c/85920/
On 10/10/2013 01:31 AM, JFC Morfin wrote:
> Thank you for your response. I certainly understand this. My question is
> in your "almost". My interest is in a seemless
> transition/simulteaneousity between the current user/admin experience
> and a NoSQL approach. This is why I am interested in knowing if some
> efforts have been engaged in that area or if I should start from scratch
> a top-down evaluation.
I have been working on a storage API with the intention of supporting
distributed backends (Cassandra initially). Our primary focus is
revision storage for now, but if that works well I don't see a reason
why it can't be expanded to other use cases as well. See
https://www.mediawiki.org/wiki/User:GWicke/Notes/Storage.
I am more interested in storage abstraction than NoSQL per se. The goal
is to have a narrow storage interface and a choice of backends including
NoSQL.
Gabriel
On 10.10.2013, 12:31 JFC wrote:
> Thank you for your response. I certainly understand this. My question
> is in your "almost". My interest is in a seemless
> transition/simulteaneousity between the current user/admin experience
> and a NoSQL approach. This is why I am interested in knowing if some
> efforts have been engaged in that area or if I should start from
> scratch a top-down evaluation.
No seamless transition is possible. Neither is SQL and NoSQL at the
same time. To add CouchDB support, you'll need to fork AND become
incompatible with mainline. This will not be MediaWiki.
--
Best regards,
Max Semenik ([[User:MaxSem]])
On 10.10.2013, 3:51 JFC wrote:
> I would be interested to know if the use of CouchDB or Couchbase has
> been/is being investigated to support MediaWiki as an alternative to
> MySQL, Postress and SQLite?
MediaWiki's data model is all about relations, and DB access is all
about SQL - so adding NoSQL support would equate to a rewrite almost
from grounds up. Of course, we either use or can use NoSQL in some
places like object cache or external storage, which still doesn't
allow us to claim NoSQL support in general.
--
Best regards,
Max Semenik ([[User:MaxSem]])
Hello,
So recently I've been trying to find a method where I could test database
queries on production data. I originally thought Tool Labs might help, but
I found out due to a bug in MySQL you can't perform EXPLAIN queries in the
database replicas. And naturally I don't have access to the actual
production cluster because I'm not on ops.
My last method to try is going to be downloading the enwiki database dump
and setting up my own replica. However, this involves hard drive space that
I don't have.
Basically I want to know if anybody is aware of any other method through
which I can test queries? Thanks in advance.
*-- *
*Tyler Romeo*
Stevens Institute of Technology, Class of 2016
Major in Computer Science