Wikitech-l February 2010

wikitech-l@lists.wikimedia.org

92 participants
73 discussions

Version control
by Max Semenik 07 Feb '10

07 Feb '10

Since there are some talks about migration from SVN anyway[1], I decided to unshelf my essay on this matter.[2] It discusses possible alternatives to Subversion and is in no way complete, everyone is invited to participate in drafting and discussing. Some sections need input of those who have practical experience with those systems, as for example I've never used Bazaar. ------ [1] http://www.mediawiki.org/w/index.php?curid=44222&diff=301482&oldid=301369 [2] http://www.mediawiki.org/wiki/Source_control_considerations -- Max Semenik ([[User:MaxSem]])

4 3

New phpunit tests eat ~1GB of memory
by Ævar Arnfjörð Bjarmason 06 Feb '10

06 Feb '10

Since the tests were ported from t/ to phpunit's phase3/maintenance/tests/ in r61938 and other commits running the tests on my machine takes up to 1GB of memory and grows as it runs more tests. It seems that phpunit uses the same instance of the php interpreter for running all the tests. Is there some way around this? Perhaps phpunit.xml could be tweaked so that it runs a new php for each test? Furthermore when I run `make test' I get this: Time: 03:35, Memory: 1849.25Mb There were 2 failures: 1) LanguageConverterTest::testGetPreferredVariantUserOption Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -tg-latn +tg /home/avar/src/mw/trunk/phase3/maintenance/tests/LanguageConverterTest.php:82 2) Warning No tests found in class "ParserUnitTest". FAILURES! Tests: 686, Assertions: 3431, Failures: 2, Incomplete: 34 But when I run phpunit manually on the test then all tests pass: $ phpunit LanguageConverterTest.php PHPUnit 3.4.5 by Sebastian Bergmann. ......... Time: 23 seconds, Memory: 23.75Mb OK (9 tests, 34 assertions) Also after I get "Tests: 686, Assertions: 3431, Failures: 2, Incomplete: 34" in the first output phpunit doesn't exit and continues hugging my memory. Why is it still running? It has already run all the tests. On Wed, Feb 3, 2010 at 17:35, <ialex(a)svn.wikimedia.org> wrote: > http://www.mediawiki.org/wiki/Special:Code/MediaWiki/61938 > > Revision: 61938 > Author: ialex > Date: 2010-02-03 17:35:59 +0000 (Wed, 03 Feb 2010) > > Log Message: > ----------- > * Port tests from t/inc/ > * Added new tests to XmlTest > > Added Paths: > ----------- > trunk/phase3/tests/LicensesTest.php > trunk/phase3/tests/SanitizerTest.php > trunk/phase3/tests/TimeAdjustTest.php > trunk/phase3/tests/TitleTest.php > trunk/phase3/tests/XmlTest.php > > Added: trunk/phase3/tests/LicensesTest.php > =================================================================== > --- trunk/phase3/tests/LicensesTest.php (rev 0) > +++ trunk/phase3/tests/LicensesTest.php 2010-02-03 17:35:59 UTC (rev 61938) > @@ -0,0 +1,17 @@ > +<?php > + > +/** > + * @group Broken > + */ > +class LicensesTest extends PHPUnit_Framework_TestCase { > + > + function testLicenses() { > + $str = " > +* Free licenses: > +** GFLD|Debian disagrees > +"; > + > + $lc = new Licenses( $str ); > + $this->assertTrue( is_a( $lc, 'Licenses' ), 'Correct class' ); > + } > +} > \ No newline at end of file > > > Property changes on: trunk/phase3/tests/LicensesTest.php > ___________________________________________________________________ > Added: svn:eol-style > + native > > Added: trunk/phase3/tests/SanitizerTest.php > =================================================================== > --- trunk/phase3/tests/SanitizerTest.php (rev 0) > +++ trunk/phase3/tests/SanitizerTest.php 2010-02-03 17:35:59 UTC (rev 61938) > @@ -0,0 +1,71 @@ > +<?php > + > +global $IP; > +require_once( "$IP/includes/Sanitizer.php" ); > + > +class SanitizerTest extends PHPUnit_Framework_TestCase { > + > + function testDecodeNamedEntities() { > + $this->assertEquals( > + "\xc3\xa9cole", > + Sanitizer::decodeCharReferences( 'école' ), > + 'decode named entities' > + ); > + } > + > + function testDecodeNumericEntities() { > + $this->assertEquals( > + "\xc4\x88io bonas dans l'\xc3\xa9cole!", > + Sanitizer::decodeCharReferences( "Ĉio bonas dans l'école!" ), > + 'decode numeric entities' > + ); > + } > + > + function testDecodeMixedEntities() { > + $this->assertEquals( > + "\xc4\x88io bonas dans l'\xc3\xa9cole!", > + Sanitizer::decodeCharReferences( "Ĉio bonas dans l'école!" ), > + 'decode mixed numeric/named entities' > + ); > + } > + > + function testDecodeMixedComplexEntities() { > + $this->assertEquals( > + "\xc4\x88io bonas dans l'\xc3\xa9cole! (mais pas Ĉio dans l'école)", > + Sanitizer::decodeCharReferences( > + "Ĉio bonas dans l'école! (mais pas &#x108;io dans l'&eacute;cole)" > + ), > + 'decode mixed complex entities' > + ); > + } > + > + function testInvalidAmpersand() { > + $this->assertEquals( > + 'a & b', > + Sanitizer::decodeCharReferences( 'a & b' ), > + 'Invalid ampersand' > + ); > + } > + > + function testInvalidEntities() { > + $this->assertEquals( > + '&foo;', > + Sanitizer::decodeCharReferences( '&foo;' ), > + 'Invalid named entity' > + ); > + } > + > + function testInvalidNumberedEntities() { > + $this->assertEquals( UTF8_REPLACEMENT, Sanitizer::decodeCharReferences( "&#88888888888888;" ), 'Invalid numbered entity' ); > + } > + > + function testSelfClosingTag() { > + $GLOBALS['wgUseTidy'] = false; > + $this->assertEquals( > + '<div>Hello world</div>', > + Sanitizer::removeHTMLtags( '<div>Hello world</div />' ), > + 'Self-closing closing div' > + ); > + } > +} > + > > > Property changes on: trunk/phase3/tests/SanitizerTest.php > ___________________________________________________________________ > Added: svn:eol-style > + native > > Added: trunk/phase3/tests/TimeAdjustTest.php > =================================================================== > --- trunk/phase3/tests/TimeAdjustTest.php (rev 0) > +++ trunk/phase3/tests/TimeAdjustTest.php 2010-02-03 17:35:59 UTC (rev 61938) > @@ -0,0 +1,40 @@ > +<?php > + > +class TimeAdjustTest extends PHPUnit_Framework_TestCase { > + > + public function setUp() { > + $this->iniSet( 'precision', 15 ); > + } > + > + # Test offset usage for a given language::userAdjust > + function testUserAdjust() { > + global $wgLocalTZoffset, $wgContLang, $wgUser; > + > + $wgContLang = $en = Language::factory( 'en' ); > + > + # Collection of parameters for Language_t_Offset. > + # Format: date to be formatted, localTZoffset value, expected date > + $userAdjust_tests = array( > + array( 20061231235959, 0, 20061231235959 ), > + array( 20061231235959, 5, 20070101000459 ), > + array( 20061231235959, 15, 20070101001459 ), > + array( 20061231235959, 60, 20070101005959 ), > + array( 20061231235959, 90, 20070101012959 ), > + array( 20061231235959, 120, 20070101015959 ), > + array( 20061231235959, 540, 20070101085959 ), > + array( 20061231235959, -5, 20061231235459 ), > + array( 20061231235959, -30, 20061231232959 ), > + array( 20061231235959, -60, 20061231225959 ), > + ); > + > + foreach( $userAdjust_tests as $data ) { > + $wgLocalTZoffset = $data[1]; > + > + $this->assertEquals( > + strval( $data[2] ), > + strval( $en->userAdjust( $data[0], '' ) ), > + "User adjust {$data[0]} by {$data[1]} minutes should give {$data[2]}" > + ); > + } > + } > +} > > > Property changes on: trunk/phase3/tests/TimeAdjustTest.php > ___________________________________________________________________ > Added: svn:eol-style > + native > > Added: trunk/phase3/tests/TitleTest.php > =================================================================== > --- trunk/phase3/tests/TitleTest.php (rev 0) > +++ trunk/phase3/tests/TitleTest.php 2010-02-03 17:35:59 UTC (rev 61938) > @@ -0,0 +1,17 @@ > +<?php > + > +class TitleTest extends PHPUnit_Framework_TestCase { > + > + function testLegalChars() { > + $titlechars = Title::legalChars(); > + > + foreach ( range( 1, 255 ) as $num ) { > + $chr = chr( $num ); > + if ( strpos( "#[]{}<>|", $chr ) !== false || preg_match( "/[\\x00-\\x1f\\x7f]/", $chr ) ) { > + $this->assertFalse( (bool)preg_match( "/[$titlechars]/", $chr ), "chr($num) = $chr is not a valid titlechar" ); > + } else { > + $this->assertTrue( (bool)preg_match( "/[$titlechars]/", $chr ), "chr($num) = $chr is a valid titlechar" ); > + } > + } > + } > +} > > > Property changes on: trunk/phase3/tests/TitleTest.php > ___________________________________________________________________ > Added: svn:eol-style > + native > > Added: trunk/phase3/tests/XmlTest.php > =================================================================== > --- trunk/phase3/tests/XmlTest.php (rev 0) > +++ trunk/phase3/tests/XmlTest.php 2010-02-03 17:35:59 UTC (rev 61938) > @@ -0,0 +1,115 @@ > +<?php > + > +class XmlTest extends PHPUnit_Framework_TestCase { > + > + function testElementOpen() { > + $this->assertEquals( > + '<element>', > + Xml::element( 'element', null, null ), > + 'Opening element with no attributes' > + ); > + } > + > + function testElementEmpty() { > + $this->assertEquals( > + '<element />', > + Xml::element( 'element', null, '' ), > + 'Terminated empty element' > + ); > + } > + > + function testElementEscaping() { > + $this->assertEquals( > + '<element>hello <there> you & you</element>', > + Xml::element( 'element', null, 'hello <there> you & you' ), > + 'Element with no attributes and content that needs escaping' > + ); > + } > + > + function testElementAttributes() { > + $this->assertEquals( > + '<element key="value" <>="<>">', > + Xml::element( 'element', array( 'key' => 'value', '<>' => '<>' ), null ), > + 'Element attributes, keys are not escaped' > + ); > + } > + > + function testOpenElement() { > + $this->assertEquals( > + '<element k="v">', > + Xml::openElement( 'element', array( 'k' => 'v' ) ), > + 'openElement() shortcut' > + ); > + } > + > + function testCloseElement() { > + $this->assertEquals( '</element>', Xml::closeElement( 'element' ), 'closeElement() shortcut' ); > + } > + > + # > + # textarea > + # > + function testTextareaNoContent() { > + $this->assertEquals( > + '<textarea name="name" id="name" cols="40" rows="5"></textarea>', > + Xml::textarea( 'name', '' ), > + 'textarea() with not content' > + ); > + } > + > + function testTextareaAttribs() { > + $this->assertEquals( > + '<textarea name="name" id="name" cols="20" rows="10"><txt></textarea>', > + Xml::textarea( 'name', '<txt>', 20, 10 ), > + 'textarea() with custom attribs' > + ); > + } > + > + # > + # JS > + # > + function testEscapeJsStringSpecialChars() { > + $this->assertEquals( > + '\\\\\r\n', > + Xml::escapeJsString( "\\\r\n" ), > + 'escapeJsString() with special characters' > + ); > + } > + > + function testEncodeJsVarBoolean() { > + $this->assertEquals( > + 'true', > + Xml::encodeJsVar( true ), > + 'encodeJsVar() with boolean' > + ); > + } > + > + function testEncodeJsVarNull() { > + $this->assertEquals( > + 'null', > + Xml::encodeJsVar( null ), > + 'encodeJsVar() with null' > + ); > + } > + > + function testEncodeJsVarArray() { > + $this->assertEquals( > + '["a", 1]', > + Xml::encodeJsVar( array( 'a', 1 ) ), > + 'encodeJsVar() with array' > + ); > + $this->assertEquals( > + '{"a": "a", "b": 1}', > + Xml::encodeJsVar( array( 'a' => 'a', 'b' => 1 ) ), > + 'encodeJsVar() with associative array' > + ); > + } > + > + function testEncodeJsVarObject() { > + $this->assertEquals( > + '{"a": "a", "b": 1}', > + Xml::encodeJsVar( (object)array( 'a' => 'a', 'b' => 1 ) ), > + 'encodeJsVar() with object' > + ); > + } > +} > > > Property changes on: trunk/phase3/tests/XmlTest.php > ___________________________________________________________________ > Added: svn:eol-style > + native > > > > _______________________________________________ > MediaWiki-CVS mailing list > MediaWiki-CVS(a)lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs >

4 5

Theora video in IE? Use Silverlight!
by David Gerard 06 Feb '10

06 Feb '10

This is clever-ish: http://www.atoker.com/blog/2010/02/04/html5-theora-video-codec-for-silverli… He says there that this will Just Work on ~40% of Windows boxes. Not bad. - d.

7 9

Developer Meet-Up in Berlin, April 14-16
by Daniel Kinzler 06 Feb '10

06 Feb '10

Hi all Wikimedia Germany invites all MediaWiki developers, Toolserver users, Gadget hackers, and other people interested in the technical side of Wikimedia projects to come to Berlin for a Developer Meet-Up on April 14.-16. Last year's meet-up in Berlin was a great success, and we hope to make it even better this time! This year we want to focus on structured (meta) data, search, and community building. The future of the Toolserver will also be a subject. The dates are set, but it's not clear yet if we start full throttle on Wednesday the 14th or if we have just an arrival event on that date and a full day on Friday the 16th instead - this depends on venue arrangements that are not sorted out yet. Note that registration in advance will be required - a website will be set up for this soon, we will announce it on blogs and mailing lists. On that Friday, April 16., the Wikimedia Chapters and Board start their convention in Berlin. This will be a great opportunity to meet, to discuss interesting topics, to network and to exchange ideas and thoughts! Wikimedia Germany will host the event, so we will organize the venue, the hotel(s), some fun things to do in Berlin, food & drinks and lots of other things - and there might even be a party at the c-base again... See you in Berlin! -- Daniel Kinzler

3 2

New SVN committer
by Brion Vibber 05 Feb '10

05 Feb '10

Added Jan Gerber ('j'). Jan is the developer of Firefogg, and will be helping out with some of the open video player & sequencer work with Michael Dale that Kaltura's sponsoring. -- brion

4 3

Chrome frame support?
by Nimish Gautam 04 Feb '10

04 Feb '10

Hey all, I really want to turn on Google chrome frame support for the mediawiki projects: http://code.google.com/chrome/chromeframe/ Basically, it would just involve us putting in a meta tag on our pages that would trigger an IE plugin Google wrote, assuming the IE user had that plugin installed. The plugin essentially causes IE to use google's HTML renderer and JS engine, which are much nicer to develop for than IE. This won't really solve IE development issues, but would be a good move in the right direction as far as I'm concerned. Any thoughts or compelling reasons why this might not be a good thing to do? -Nimish

7 9

Facebook introducing PHP compiler?
by David Gerard 03 Feb '10

03 Feb '10

http://www.sdtimes.com/blog/post/2010/01/30/Facebook-rewrites-PHP-runtime.a… Facebook is written in PHP. Unlike Wikimedia, they have money to pay people to speed it up. Looks like they're introducing a PHP compiler. Open source. Might be of interest to WMF and third-party MediaWiki users ... - d.

6 9

remove me from your mailing list
by Stefano Ronzoni 03 Feb '10

03 Feb '10

Remove me from your mailing list! Right here right now! It's 2 months I asked for that! ------------------------------------------------------------ Best Weight Loss Program - Click Here! Weight Loss Program http://tagline.excite.com/c?cp=SRruNMfZB97_s2ppl-MuGAAAKZTVS3uidXGi8As47ZJz…

3 2

Re: [Wikitech-l] "Google phases out support for IE6"
by Sam Reed 02 Feb '10

02 Feb '10

And in related news, the BBC have reported [1] that the UK Government have been petitioned to upgrade away from IE6 [2] Sam Reed [1] http://news.bbc.co.uk/1/hi/technology/8492862.stm [2] http://petitions.number10.gov.uk/ie6upgrade/

1 0

help about the extension about the URL's argument's value transfer to content's area.
by Evel liu 02 Feb '10

02 Feb '10

help about the extension about the URL's argument's value transfer to content's area: 1, the URL is http://localhost/wiki/index.php?title=ProjectSpin:your_project_name&action=… and I want to make the project name auto add into the editor project template's area (your project name) .so how should I do and and which extension I should use? Experience sharing * Edit and Put the Project Experience Sharing information into below link ProjectExperenice:your project name

2 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Wikitech-l February 2010