Re: [Wikidata-l] MediaWiki - User interface guidelines - Wikidata

List overview All Threads
Download

newer

Re: [Wikidata-l] MediaWiki - User interface guidelines

older

Re: [Wikidata-l] Deadlines -...

[Wikidata-l] Deadlines - phases...

Lukas Benedix

27 Nov 2012 27 Nov '12

7:14 a.m.

Hi, I wanted to ask how you implement the requirement that critical functions must also work with JavaScript disabled.[1] The Wikidata-Repository is allmost only Javascript and it is not possible to add, edit or delete something without JS. Btw: I have one notes on the HTML in the Repository [2]: * there is a stray end-tag div in line 76  </div>  [1]: http://www.mediawiki.org/wiki/User_interface_guidelines#JavaScript_and_jQue… [2]: http://www.wikidata.org/wiki/Q560 LB

Show replies by date

Marco Fleckinger

27 Nov 27 Nov

8:05 a.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Hi, On 27/11/12 08:14, Lukas Benedix wrote:

...

I wanted to ask how you implement the requirement that critical functions must also work with JavaScript disabled.[1] The Wikidata-Repository is allmost only Javascript and it is not possible to add, edit or delete something without JS.

Good question. It is possible to do that, but there is no graphical UI for it. My question on that is, if we really need this. Does anybody really want to use a browser without Javascript? All this HTML5 stuff does not work without Javascript-enabled. I know all banking stuff is more secure with JS disabled, but there are possibilities just enabling it for e.g. wikidata.org. Just also tried to test it on a small Android-display. There Javascript stuff sometimes seem too behave ab bit stanger than usual, because of the missing space, but here it works fine. There is not much space for the suggestions, when I hold my mobile landscape, but then the the Motorola (Droid) Pro uses the software-keyboard, which uses quite a lot of the display.

...

Btw: I have one notes on the HTML in the Repository [2]: * there is a stray end-tag div in line 76  </div>

As the comment says, this closes <div id="content">, which is at line 39.

...

[1]: http://www.mediawiki.org/wiki/User_interface_guidelines#JavaScript_and_jQue… [2]: http://www.wikidata.org/wiki/Q560

Marco

Lukas Benedix

9:01 a.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

...

Hi, On 27/11/12 08:14, Lukas Benedix wrote:

Good question. It is possible to do that, but there is no graphical UI for it. My question on that is, if we really need this. Does anybody really want to use a browser without Javascript?

I don't think that the guidelines leave any room for discussions. Guidelines are for avoiding discussions. ;)

...

All this HTML5 stuff does not work without Javascript-enabled. I know all banking stuff is more secure with JS disabled, but there are possibilities just enabling it for e.g. wikidata.org.

Of course, it may be possible to get a browser that supports JavaScript and use it for wikidata, but that is not the point. I don't think that it is necessary to be JavaScript only. The guidelines are clear.

...

Just also tried to test it on a small Android-display. There Javascript stuff sometimes seem too behave ab bit stanger than usual, because of the missing space, but here it works fine. There is not much space for the suggestions, when I hold my mobile landscape, but then the the Motorola (Droid) Pro uses the software-keyboard, which uses quite a lot of the display.

Btw: I have one notes on the HTML in the Repository [2]: * there is a stray end-tag div in line 76  </div>

As the comment says, this closes <div id="content">, which is at line 39.

The comment is wrong ;) The extra </div> is found in the  block

...

[1]: http://www.mediawiki.org/wiki/User_interface_guidelines#JavaScript_and_jQue… [2]: http://www.wikidata.org/wiki/Q560

Marco _______________________________________________ Wikidata-l mailing list Wikidata-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-l

Marco Fleckinger

9:59 a.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Hi, On 27/11/12 10:01, Lukas Benedix wrote:

...

On 27/11/12 08:14, Lukas Benedix wrote:

Good question. It is possible to do that, but there is no graphical UI for it. My question on that is, if we really need this. Does anybody really want to use a browser without Javascript?

I don't think that the guidelines leave any room for discussions. Guidelines are for avoiding discussions. ;)

That's true, sorry I didn't realize that this are guidelines because I didn't read the title of the page and had been confused of the word "may" which is quite unusual in guidelines ;-)

...

Btw: I have one notes on the HTML in the Repository [2]: * there is a stray end-tag div in line 76  </div>

As the comment says, this closes<div id="content">, which is at line 39.

The comment is wrong ;) The extra</div> is found in the block

You mean line 65? Yes, just found it as well, but – you're right here – the comments are wrong, should be "mw-content-text" and "/mw-content-text" in line 64 and 65.

...

>> >> [1]: >> http://www.mediawiki.org/wiki/User_interface_guidelines#JavaScript_and_jQue… >> [2]: http://www.wikidata.org/wiki/Q560 >>

Lukas Benedix

10:49 a.m.

New subject: [Wikidata-l] MediaWiki - stray </div>

...

Btw: I have one notes on the HTML in the Repository [2]: * there is a stray end-tag div in line 76  </div>

As the comment says, this closes<div id="content">, which is at line 39.

The comment is wrong ;) The extra</div> is found in the block

You mean line 65? Yes, just found it as well, but – you're right here – the comments are wrong, should be "mw-content-text" and "/mw-content-text" in line 64 and 65.

curl http://www.wikidata.org/wiki/Q560 | grep -o "</div" | wc -l 38 curl http://www.wikidata.org/wiki/Q560 | grep -o "</div" | wc -l 39

Anja Jentzsch

11:43 a.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Hi, On 27/11/2012 10:59 Marco Fleckinger wrote:

...

Btw: I have one notes on the HTML in the Repository [2]: * there is a stray end-tag div in line 76  </div>

As the comment says, this closes<div id="content">, which is at line 39.

The comment is wrong ;) The extra</div> is found in the block

You mean line 65? Yes, just found it as well, but – you're right here – the comments are wrong, should be "mw-content-text" and "/mw-content-text" in line 64 and 65.

we are constantly validating the HTML rendered by Wikidata on our dev system as well and this is the current status (updated daily): http://wikidata-docs.wikimedia.de/htmlvalidation/ Cheers, Anja -- -- Software Developer Wikidata Wikimedia Deutschland e.V. | Obentrautstraße 72 | 10963 Berlin Tel. +49-30-219 158 26-0 | http://wikimedia.de Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e.V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/681/51985.

Anja Jentzsch

11:53 a.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Hi, On 27/11/2012 10:59 Marco Fleckinger wrote:

...

Btw: I have one notes on the HTML in the Repository [2]: * there is a stray end-tag div in line 76  </div>

As the comment says, this closes<div id="content">, which is at line 39.

The comment is wrong ;) The extra</div> is found in the block

You mean line 65? Yes, just found it as well, but – you're right here – the comments are wrong, should be "mw-content-text" and "/mw-content-text" in line 64 and 65.

Lukas Benedix

1:01 p.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Am 27.11.2012 12:53, schrieb Anja Jentzsch:

...

Hi, On 27/11/2012 10:59 Marco Fleckinger wrote:

> Btw: I have one notes on the HTML in the Repository [2]: > > * there is a stray end-tag div in line 76 >  > </div> >  > As the comment says, this closes<div id="content">, which is at line 39.

The comment is wrong ;) The extra</div> is found in the block

You mean line 65? Yes, just found it as well, but – you're right here – the comments are wrong, should be "mw-content-text" and "/mw-content-text" in line 64 and 65.

we are constantly validating the HTML rendered by Wikidata on our dev system as well and this is the current status (updated daily): http://wikidata-docs.wikimedia.de/htmlvalidation/ Cheers, Anja

Denny Vrandečić

1:21 p.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Yes, there is something wrong with the divs. Need to investigate. 2012/11/27 Lukas Benedix <benedix(a)zedat.fu-berlin.de>

...

Am 27.11.2012 12:53, schrieb Anja Jentzsch: Hi,

On 27/11/2012 10:59 Marco Fleckinger wrote: Btw: I have one notes on the HTML in the Repository [2]:

>> >> * there is a stray end-tag div in line 76 >>  >> </div> >>  >> >> As the comment says, this closes<div id="content">, which is at line > 39. > The comment is wrong ;) The extra</div> is found in the block You mean line 65? Yes, just found it as well, but – you're right here

– the comments are wrong, should be "mw-content-text" and "/mw-content-text" in line 64 and 65.

we are constantly validating the HTML rendered by Wikidata on our dev system as well and this is the current status (updated daily): http://wikidata-docs.**wikimedia.de/htmlvalidation/<http://wikidata-docs… Cheers, Anja

I don't understand that and don't think wikidata.org, what I am talking about, is the dev-system. I have 38 opening div-tags and 39 closing. lb@vsrv41563:~$ curl http://www.wikidata.org/wiki/**Q560<http://www.wikidata.org/wiki/Q560>… /dev/null | grep -o "<div" | wc -l 38 lb@vsrv41563:~$ curl http://www.wikidata.org/wiki/**Q560<http://www.wikidata.org/wiki/Q560>… /dev/null | grep -o "</div" | wc -l 39 ______________________________**_________________ Wikidata-l mailing list Wikidata-l(a)lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikidata-l<https://lists.…

-- Project director Wikidata Wikimedia Deutschland e.V. | Obentrautstr. 72 | 10963 Berlin Tel. +49-30-219 158 26-0 | http://wikimedia.de Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e.V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/681/51985.

Denny Vrandečić

1:25 p.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Oh, I see now -- OK, this will be fixed with the next deployment. Thanks for noting! Cheers, Denny 2012/11/27 Denny Vrandečić <denny.vrandecic(a)wikimedia.de>

...

Yes, there is something wrong with the divs. Need to investigate. 2012/11/27 Lukas Benedix <benedix(a)zedat.fu-berlin.de>

Am 27.11.2012 12:53, schrieb Anja Jentzsch: Hi,

On 27/11/2012 10:59 Marco Fleckinger wrote: Btw: I have one notes on the HTML in the Repository [2]:

>>> >>> * there is a stray end-tag div in line 76 >>>  >>> </div> >>>  >>> >>> As the comment says, this closes<div id="content">, which is at >> line 39. >> > The comment is wrong ;) > > The extra</div> is found in the block > > You mean line 65? Yes, just found it as well, but – you're right here – the comments are wrong, should be "mw-content-text" and "/mw-content-text" in line 64 and 65.

Jeroen De Dauw

10:05 a.m.

New subject: [Wikidata-l] MediaWiki - User interface guidelines

Hey, The Wikidata-Repository is

...

allmost only Javascript and it is not possible to add, edit or delete something without JS.

We are well aware of the guidelines and agree the core functionality should work without JavaScript as well, and are thus putting quite some effort in a JavaScript-less UI. This is not done yet, then again neither is our JS UI, we're still working on both. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --

4169

days inactive

4169

days old

wikidata@lists.wikimedia.org

Manage subscription

10 comments

5 participants

tags (0)

participants (5)

Anja Jentzsch
Denny Vrandečić
Jeroen De Dauw
Lukas Benedix
Marco Fleckinger