Hi,
In my previous post, I mentioned that there are very few empty-map issues remaining in the JSON dumps as well. I think there are only two right now:
https://www.wikidata.org/wiki/Special:EntityData/Q2382164.json https://www.wikidata.org/wiki/Special:EntityData/Q4383128.json
Both have the empty reference problem (a statement has a reference which contains no data whatsoever; look for: "snaks":[]). Maybe somebody wants to look into this (this should not really happen, even if the JSON were serialized correctly).
Cheers,
Markus
On Fri, Feb 27, 2015 at 10:38 AM, Markus Kroetzsch markus.kroetzsch@tu-dresden.de wrote:
Hi,
In my previous post, I mentioned that there are very few empty-map issues remaining in the JSON dumps as well. I think there are only two right now:
https://www.wikidata.org/wiki/Special:EntityData/Q2382164.json https://www.wikidata.org/wiki/Special:EntityData/Q4383128.json
Both have the empty reference problem (a statement has a reference which contains no data whatsoever; look for: "snaks":[]). Maybe somebody wants to look into this (this should not really happen, even if the JSON were serialized correctly).
Those were empty in the UI as well. I deleted them. This should hopefully fix it. We need to investigate if adding those empty references is still possible.
Cheers Lydia
On Fri, Feb 27, 2015 at 5:33 PM, Lydia Pintscher lydia.pintscher@wikimedia.de wrote:
Those were empty in the UI as well. I deleted them. This should hopefully fix it. We need to investigate if adding those empty references is still possible.
For reference: The edits that introduced them were https://www.wikidata.org/w/index.php?title=Q4383128&diff=182364626&o... and https://www.wikidata.org/w/index.php?title=Q2382164&diff=190607412&o...
Cheers Lydia
Lydia, I think the serializer should just drop empty references. Shall we make a ticket for that?
I'm confused though why we still see issues in the XML. We *should* be re-serializing all output now. But it's hard to find out what's actually going on on the dump servers...
Am 27.02.2015 um 17:35 schrieb Lydia Pintscher:
On Fri, Feb 27, 2015 at 5:33 PM, Lydia Pintscher lydia.pintscher@wikimedia.de wrote:
Those were empty in the UI as well. I deleted them. This should hopefully fix it. We need to investigate if adding those empty references is still possible.
For reference: The edits that introduced them were https://www.wikidata.org/w/index.php?title=Q4383128&diff=182364626&o... and https://www.wikidata.org/w/index.php?title=Q2382164&diff=190607412&o...
Cheers Lydia
Hey,
I think the serializer should just drop empty references
This seems like the wrong place do to that. I suggest to do this in the model itself, very similar to what we are doing with empty alias groups in lists of alias groups: https://github.com/wmde/WikibaseDataModel/blob/5c78e35ee1a382d3b132ddfd76077...
Cheers
-- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Evil software architect at Wikimedia Germany ~=[,,_,,]:3
Am 28.02.2015 um 11:57 schrieb Jeroen De Dauw:
Hey,
I think the serializer should just drop empty references
This seems like the wrong place do to that. I suggest to do this in the model itself, very similar to what we are doing with empty alias groups in lists of alias groups: https://github.com/wmde/WikibaseDataModel/blob/5c78e35ee1a382d3b132ddfd76077...
Sure, the model should do that.
And if the serializer encounters an empty reference for some reason, it should drop it, too. It's not a valid reference. There is no JSON binding for it.
On Sat, Feb 28, 2015 at 12:20 PM, Daniel Kinzler daniel.kinzler@wikimedia.de wrote:
Am 28.02.2015 um 11:57 schrieb Jeroen De Dauw:
Hey,
I think the serializer should just drop empty references
This seems like the wrong place do to that. I suggest to do this in the model itself, very similar to what we are doing with empty alias groups in lists of alias groups: https://github.com/wmde/WikibaseDataModel/blob/5c78e35ee1a382d3b132ddfd76077...
Sure, the model should do that.
And if the serializer encounters an empty reference for some reason, it should drop it, too. It's not a valid reference. There is no JSON binding for it.
The interesting question for me: How did they get in in the first place? And how do we prevent that? Both edits are fairly recent and from two different editors. This looks fishy to me.
Cheers Lydia
On Sat, Feb 28, 2015 at 9:49 PM, Lydia Pintscher lydia.pintscher@wikimedia.de wrote:
The interesting question for me: How did they get in in the first place? And how do we prevent that? Both edits are fairly recent and from two different editors. This looks fishy to me.
Ticket for investigating this is now at https://phabricator.wikimedia.org/T92383 The ticket for fixing the serialization is https://phabricator.wikimedia.org/T73349
Cheers Lydia
Hey,
Last week a change to ignore empty references in lists of references was made: https://github.com/wmde/WikibaseDataModel/pull/399
This means that no new empty references can be added, and that existing ones will no longer be visible in most places. The one exception I can think of are dumps, since they use JSON generated before the change was made. Making a single edit to an entity that has an empty reference will fix it there as well though.
Note that this change has not yet been deployed to Wikidata.org.
Cheers
-- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Developer at Wikimedia Germany ~=[,,_,,]:3