On Wed, Jul 8, 2009 at 3:19 PM, Aude<aude.wiki(a)gmail.com> wrote:
On Wed, Jul 8, 2009 at 9:47 AM, Ævar Arnfjörð
Bjarmason <avarab(a)gmail.com>
wrote:
The changes look good. I saw that you added OpenLayers to the svn. With
OpenLayers licensed under a BSD-style license rather than GFDL, is it okay
to distribute the code with our extension?
Yes it's fine. We're just using it as a library but even if we weren't
the GPL and BSD license are compatible.
I expect to have time to work on the code over the
next few days. I might
work on developing custom OpenLayers controls that work suitably when the
maps are small, and work on how they are laid out. I can also work on the
pop-up map and on the WMS support.
OK good stuff. I look forward to seeing it.
I've been seeing some strange issues with the conditional adding of
the slippymap parser tag / the js/css headers. It might be that the
parsercache reacts badly to conditionally including it depending on
whether the article text includes "slippymap".
Hopefully this is something we can do away with completely once
Christian Becker can implement conditional loading of OpenLayers. Then
the JS required to display maps could just be included for the whole
site (and would hopefully only be ~10-20 lines) and when a map was
used in an article (and the user clicked on the map) the full OL
library could be pulled in and cached.
B.t.w. Aude you should set your editor to indent with tabs instead of
spaces, I fixed this in your most recent commit:
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/52919
This might help configure your editor correctly:
http://www.mediawiki.org/wiki/Manual:Coding_conventions
I don't care about coding styles one way or the other. But it should
be consistent so it doesn't look bad when rendering tabs as something
other than 8 spaces.