Hi design list,
You may remember me as the person who introduced the Erudite skin a few months ago. Since that time I've made lots of changes to it locally that are almost ready to go back up to the version on Mediawiki's servers.
Major changes include: - ability to set a top banner to an your own image in LocalSettings.php - ability to add extra content sections to the columns on the footer using system messages (the same way the main navigation can be customised; editing pages like MediaWiki:Erudite-extracontent-column2) - width is not fixed, but flexes to use the space appropriately - generally heaps of smaller style improvements
There are two issues I see in getting the changes upstream, though.
1) Any visible style change seems to have great difficulty being accepted. I found this with a few changes I submitted months ago: https://gerrit.wikimedia.org/r/#/c/32035/ https://gerrit.wikimedia.org/r/#/c/32036/ With the reviews always coming back "fine, needs approval from someone else". I think this may be a more general issue making design changes difficult to do.
2) Partly due to the above difficulties, partly due to my own time pressures, there are a large number of changes between the version currently in git and my current code. Moreover I would like to update the current code to conform to the Mediawiki style guide, but this would make the diff even more massive.
I could rejig my code into some separate patches, but they would each be quite large and interdependant. What would be the best way to contribute my improvements?
Nick
On 2013-05-02 5:07 AM, Nick White wrote:
Hi design list, [...]
- Any visible style change seems to have great difficulty being
accepted. I found this with a few changes I submitted months ago: https://gerrit.wikimedia.org/r/#/c/32035/ https://gerrit.wikimedia.org/r/#/c/32036/ With the reviews always coming back "fine, needs approval from someone else". I think this may be a more general issue making design changes difficult to do.
Part of the issue is that I'm the primary person with +2 here since I started the mediawiki/skins/* repos. But I don't have the time to checkout and test changes. Btw, note that " Looks good to me, but someone else must approve" is actually just something Gerrit says when you +1 something. It's not something anyone voluntarily says.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/]
On Thu, May 02, 2013 at 11:51:43AM -0700, Daniel Friesen wrote:
Part of the issue is that I'm the primary person with +2 here since I started the mediawiki/skins/* repos. But I don't have the time to checkout and test changes.
OK, I see, thanks for explaining. Is there anybody else who might be interested, do you know? Or is there somewhere else I should post to try to find developers?
Btw, note that " Looks good to me, but someone else must approve" is actually just something Gerrit says when you +1 something. It's not something anyone voluntarily says.
I did not know that, thanks for the info. It seems pretty weird to me for gerrit to say things like that on peoples' behalf, but oh well.
On Thu, May 02, 2013 at 11:51:43AM -0700, Daniel Friesen wrote:
Part of the issue is that I'm the primary person with +2 here since I started the mediawiki/skins/* repos. But I don't have the time to checkout and test changes.
Is there anybody else who might be interested in doing reviews and having +2 capabilities? If not I wonder whether the Erudite repository should be switched to "open push"? Though I do really love and value the code reviews; they make my code a million times better!
On 2013-05-08 2:35 AM, Nick White wrote:
On Thu, May 02, 2013 at 11:51:43AM -0700, Daniel Friesen wrote:
Part of the issue is that I'm the primary person with +2 here since I started the mediawiki/skins/* repos. But I don't have the time to checkout and test changes.
Is there anybody else who might be interested in doing reviews and having +2 capabilities? If not I wonder whether the Erudite repository should be switched to "open push"? Though I do really love and value the code reviews; they make my code a million times better!
It's best to avoid open push with gerrit. It'd be better to get +2 yourself.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/]
On Wed, May 08, 2013 at 03:37:09AM -0700, Daniel Friesen wrote:
On 2013-05-08 2:35 AM, Nick White wrote:
On Thu, May 02, 2013 at 11:51:43AM -0700, Daniel Friesen wrote:
Part of the issue is that I'm the primary person with +2 here since I started the mediawiki/skins/* repos. But I don't have the time to checkout and test changes.
Is there anybody else who might be interested in doing reviews and having +2 capabilities? If not I wonder whether the Erudite repository should be switched to "open push"? Though I do really love and value the code reviews; they make my code a million times better!
It's best to avoid open push with gerrit. It'd be better to get +2 yourself.
I like that idea better too, though it will lead to violations of the norm that you don't +2 your own changes. Can you Make It So?
On 2013-05-08 4:16 AM, Nick White wrote:
On Wed, May 08, 2013 at 03:37:09AM -0700, Daniel Friesen wrote:
On 2013-05-08 2:35 AM, Nick White wrote:
On Thu, May 02, 2013 at 11:51:43AM -0700, Daniel Friesen wrote:
Part of the issue is that I'm the primary person with +2 here since I started the mediawiki/skins/* repos. But I don't have the time to checkout and test changes.
Is there anybody else who might be interested in doing reviews and having +2 capabilities? If not I wonder whether the Erudite repository should be switched to "open push"? Though I do really love and value the code reviews; they make my code a million times better!
It's best to avoid open push with gerrit. It'd be better to get +2 yourself.
I like that idea better too, though it will lead to violations of the norm that you don't +2 your own changes. Can you Make It So?
That norm only applies to big repos like core, extensions used by WMF, and other extensions developed by lots of people that want that norm. Self reviewing stuff in your own repo is fine.
I only have +2 in mediawiki/skins/*. I don't think I have the rights to change the group stuff that would be needed. Try talking to ^demon/Chad.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/]
On Thu, May 02, 2013 at 01:07:26PM +0100, Nick White wrote:
You may remember me as the person who introduced the Erudite skin a few months ago. Since that time I've made lots of changes to it locally that are almost ready to go back up to the version on Mediawiki's servers.
OK, I've decided on a way forward. I've split the PHP & logic changes up into two patches (or changesets, or whatever gerrit calls them), and will try my best to split up the CSS changes into logical parts (though that will take a bit longer, and likely be less perfectly compartmentalised).
The two PHP changes have now been submitted to gerrit, at: - https://gerrit.wikimedia.org/r/#/c/62604/ - https://gerrit.wikimedia.org/r/#/c/62623/
If anybody has time it would be great if they could take a look. Should I post elsewhere to get reviewers as well, or ask on IRC?
I'll post here once the CSS changes are ready, but it will take me a bit longer.
Nick
On 05/07/2013 12:29 PM, Nick White wrote:
On Thu, May 02, 2013 at 01:07:26PM +0100, Nick White wrote:
You may remember me as the person who introduced the Erudite skin a few months ago. Since that time I've made lots of changes to it locally that are almost ready to go back up to the version on Mediawiki's servers.
OK, I've decided on a way forward. I've split the PHP & logic changes up into two patches (or changesets, or whatever gerrit calls them), and will try my best to split up the CSS changes into logical parts (though that will take a bit longer, and likely be less perfectly compartmentalised).
The two PHP changes have now been submitted to gerrit, at:
If anybody has time it would be great if they could take a look. Should I post elsewhere to get reviewers as well, or ask on IRC?
I'll post here once the CSS changes are ready, but it will take me a bit longer.
Nick
Here are some tips for getting reviews: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews Are those helpful at all?
Asking on IRC can also be helpful, especially if you can articulate the benefit of the merge -- how many users does the Erudite skin have?
On Tue, May 07, 2013 at 12:32:01PM -0400, Sumana Harihareswara wrote:
Here are some tips for getting reviews: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews Are those helpful at all?
Thanks. They are somewhat helpful, though not many people seem to work on interface stuff (at least as far as I can see). I found Matmarex and Krinkle and added them, though. I'll add Daniel too, though I know is likely to be too busy at the moment.
Asking on IRC can also be helpful, especially if you can articulate the benefit of the merge -- how many users does the Erudite skin have?
OK, I'll ask there soon. As far as I know the skin only currently has two users (myself [website soon to be made public] and the website "The Unified Republic of Stars"), but these changes are in part to make it more general, pretty, and easy to customise, so hopefully more people will be interested ;-)