On 2013-05-08 4:16 AM, Nick White wrote:
On Wed, May 08, 2013 at 03:37:09AM -0700, Daniel
Friesen wrote:
On 2013-05-08 2:35 AM, Nick White wrote:
On Thu, May 02, 2013 at 11:51:43AM -0700, Daniel
Friesen wrote:
Part of the issue is that I'm the primary
person with +2 here since I started
the mediawiki/skins/* repos. But I don't have the time to checkout and test
changes.
Is there anybody else who might be interested in doing reviews and
having +2 capabilities? If not I wonder whether the Erudite repository
should be switched to "open push"? Though I do really love and value
the code reviews; they make my code a million times better!
It's best to avoid
open push with gerrit. It'd be better to get +2 yourself.
I like that idea
better too, though it will lead to violations of
the norm that you don't +2 your own changes. Can you Make It So?
That norm only
applies to big repos like core, extensions used by WMF,
and other extensions developed by lots of people that want that norm.
Self reviewing stuff in your own repo is fine.
I only have +2 in mediawiki/skins/*. I don't think I have the rights to
change the group stuff that would be needed. Try talking to ^demon/Chad.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [
http://danielfriesen.name/]