Hi,
i'm working on cleaning the Kiwix Windows Compilation scripts... and have discovered a few new issues and discussion topics.
#1 in uuid.cpp, #ifdef WIN32 should be replaced by #ifdef _WIN32 which is the pp reserved name.
#2 Should we use _WIN32 or _MSC_VER as pp variable to trigger the MS only code ?
#3 unistd.h is a unix specific header and seems not to be mandatory in fileimpl.cpp. May we remove it?
#4 In zim.h there is an include of stdint.h. stdint.h is not include in MSVC. They are many solutions to workaround that and we started to redefine types in zim.h specifically for MS. Maybe a better solution would be to use a portable version of stdint.h. Like available here http://www.azillionmonkeys.com/qed/pstdint.h ?
Regards Emmanuel
Re #2 -- definitely use _WIN32 -- that's more generic, as it is platform-specific (which is what we mean) rather than vendor-specific.
Asaf
On Mon, Mar 22, 2010 at 11:32 AM, emmanuel@engelhart.org wrote:
Hi,
i'm working on cleaning the Kiwix Windows Compilation scripts... and have discovered a few new issues and discussion topics.
#1 in uuid.cpp, #ifdef WIN32 should be replaced by #ifdef _WIN32 which is the pp reserved name.
#2 Should we use _WIN32 or _MSC_VER as pp variable to trigger the MS only code ?
#3 unistd.h is a unix specific header and seems not to be mandatory in fileimpl.cpp. May we remove it?
#4 In zim.h there is an include of stdint.h. stdint.h is not include in MSVC. They are many solutions to workaround that and we started to redefine types in zim.h specifically for MS. Maybe a better solution would be to use a portable version of stdint.h. Like available here http://www.azillionmonkeys.com/qed/pstdint.h ?
Regards Emmanuel
dev-l mailing list dev-l@openzim.org https://intern.openzim.org/mailman/listinfo/dev-l
Hi Emmanuel,
I just checked in the suggsted changes. I chanted WIN32 to _WIN32 as Asaf suggested.
Looks like the header unistd.h is not really needed. I don't know, why it was there. I removed it.
For the stdint I copied another solution from the pt-framework. It is simple, straightforward and reliable.
Tommi
Am Montag 22 März 2010 10:32:44 schrieb emmanuel@engelhart.org:
Hi,
i'm working on cleaning the Kiwix Windows Compilation scripts... and have discovered a few new issues and discussion topics.
#1 in uuid.cpp, #ifdef WIN32 should be replaced by #ifdef _WIN32 which is the pp reserved name.
#2 Should we use _WIN32 or _MSC_VER as pp variable to trigger the MS only code ?
#3 unistd.h is a unix specific header and seems not to be mandatory in fileimpl.cpp. May we remove it?
#4 In zim.h there is an include of stdint.h. stdint.h is not include in MSVC. They are many solutions to workaround that and we started to redefine types in zim.h specifically for MS. Maybe a better solution would be to use a portable version of stdint.h. Like available here http://www.azillionmonkeys.com/qed/pstdint.h ?
Regards Emmanuel
dev-l mailing list dev-l@openzim.org https://intern.openzim.org/mailman/listinfo/dev-l