hey Pau, Thanks for doing this. One quick comment: the type color is fairly dark in the disabled state. IMO, desaturating the label is key to conveying 'This is disabled' On Thu, Aug 9, 2012 at 4:46 PM, Pau Giner <pginer(a)wikimedia.org> wrote: _______________________________________________ Design mailing list Design(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design

Hey Pau, Thanks for doing this! My major comments on the styling is that the disabled state text color is a bit light now (I'm guessing this is after you changed it per Vibha's comments because I'm seeing a later commit). In addition, I feel that the gray gradient is more pronounced than the others, which are aiming for a flatter style. One other thing: the code looks fine, but would you mind making things consistent with CSS style guidelines so things don't get messy over time? Things like no spacing after commas, hanging brackets, etc. are just going to make a lot of stuff inconsistent as the codebase grows. Here's a style guide I'm trying to follow: https://github.com/styleguide/css/ Regarding git-flow, here is all you need to know: $ git clone git@github.com:wikimedia/agora.git $ git flow feature start gray-buttons … make commits the normal git way … $ git flow feature finish gray-buttons All this does is create a branch called gray-buttons and stages it into a branch called develop. Then, it's my job to review the code and merge it into master if it's OK. But as a feature contributor, all you really ever have to do is start and finish feature branches and I can take care of the rest. It's pretty easy. Here is more documentation on git-flow: http://jeffkreeftmeijer.com/2010/why-arent-you-using-git-flow/ -- Munaf Assaf On Thursday, August 9, 2012 at 4:46 PM, Pau Giner wrote: I have been modifying the Agora Less stylesheet to include: gray (normal) buttons which where lacking, and disabled versions for all colors. The result can be seen in this example page: http://dl.dropbox.com/u/30377416/design/agora-design/gray-disabled-buttons/… I have pushed the changes to GitHub in the following pull request: https://github.com/wikimedia/agora/pull/1 Although I tried to use git-flow as it was suggested in the documentation, I ended up using plain git commands to submit the changes since I was not aware of the git-flow command to download an existing remote branch and update it. All information I found on git-flow was about creating new branches from scratch, not on how to improve work from others. It would be great to have some command examples illustrating this in the repository documentation. Pau -- Pau Giner Interaction Designer Wikimedia Foundation _______________________________________________ Design mailing list Design(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design _______________________________________________ Design mailing list Design(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design