Hi Munaf,<div><br></div><div>Regarding colors for disabled gray I tried to stick to the levels of gray from the Agora palette as much as possible, but maybe I should try some intermediate color in this case if one is too dark and the other to light. </div>
<div>I&#39;ll revisit the gradient but it looks less prominent than the red one ans similar to the blue (I&#39;ll look close to the numbers in any case).<br><br>Thanks for the git-flow clarifications. The only thing that is still not clear to me is how to start a feature branch based on another remote branch that is not master. </div>
<div>In this case, the master branch had no style for blue buttons, I would not be able to do &quot;<span style="font-family:&#39;Courier New&#39;;font-size:13px">git flow feature start gray-buttons&quot; </span>and  add the &quot;disabled&quot; state to blue buttons since they do not exist there.</div>
<div><br>Pau<br><br><div class="gmail_quote">On Fri, Aug 10, 2012 at 6:48 PM, Munaf Assaf <span dir="ltr">&lt;<a href="mailto:massaf@wikimedia.org" target="_blank">massaf@wikimedia.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

                <div style="font-size:13px">Hey Pau,<div style="font-family:Helvetica"><br></div><div style="font-family:Helvetica">Thanks for doing this! My major comments on the styling is that the disabled state text color is a bit light now (I&#39;m guessing this is after you changed it per Vibha&#39;s comments because I&#39;m seeing a later commit). In addition, I feel that the gray gradient is more pronounced than the others, which are aiming for a flatter style.</div>
<div style="font-family:Helvetica"><br></div><div style="font-family:Helvetica">One other thing: the code looks fine, but would you mind making things consistent with CSS style guidelines so things don&#39;t get messy over time? Things like no spacing after commas, hanging brackets, etc. are just going to make a lot of stuff inconsistent as the codebase grows. Here&#39;s a style guide I&#39;m trying to follow: <a href="https://github.com/styleguide/css/" target="_blank">https://github.com/styleguide/css/</a></div>
<div style="font-family:Helvetica"><br></div><div style="font-family:Helvetica">Regarding git-flow, here is all you need to know:</div><div><font face="&#39;Courier New&#39;">$ git clone git@github.com:wikimedia/agora.git</font></div>
<div><font face="&#39;Courier New&#39;">$ git flow feature start gray-buttons</font></div><div><font face="&#39;Courier New&#39;">… make commits the normal git way …</font></div><div><font face="&#39;Courier New&#39;">$ git flow feature finish gray-buttons</font></div>
<div style="font-family:Helvetica"><br></div></div>
                <div><div>All this does is create a branch called gray-buttons and stages it into a branch called develop. Then, it&#39;s my job to review the code and merge it into master if it&#39;s OK. But as a feature contributor, all you really ever have to do is start and finish feature branches and I can take care of the rest. It&#39;s pretty easy. Here is more documentation on git-flow: <a href="http://jeffkreeftmeijer.com/2010/why-arent-you-using-git-flow/" target="_blank">http://jeffkreeftmeijer.com/2010/why-arent-you-using-git-flow/</a></div>
<span class="HOEnZb"><font color="#888888"><div><br></div><div>-- </div><div>Munaf Assaf<br></div><div><br></div></font></span></div><div><div class="h5">
                 
                <p style="color:#a0a0a8">On Thursday, August 9, 2012 at 4:46 PM, Pau Giner wrote:</p>
                </div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px">
                    <span><div><div><div class="h5"><div><div>I have been modifying the Agora Less stylesheet to include: gray (normal) buttons which where lacking, and disabled versions for all colors.</div><div>The result can be seen in this example page: <a href="http://dl.dropbox.com/u/30377416/design/agora-design/gray-disabled-buttons/examples/buttons/button-disabled.html" target="_blank">http://dl.dropbox.com/u/30377416/design/agora-design/gray-disabled-buttons/examples/buttons/button-disabled.html</a></div>

<div><br></div><div>I have pushed the changes to GitHub in the following pull request: <a href="https://github.com/wikimedia/agora/pull/1" target="_blank">https://github.com/wikimedia/agora/pull/1</a></div><div>Although I tried to use git-flow as it was suggested in the documentation, I ended up using plain git commands to submit the changes since I was not aware of the git-flow command to download an existing remote branch and update it. </div>

<div>All information I found on git-flow was about creating new branches from scratch, not on how to improve work from others. It would be great to have some command examples illustrating this in the repository documentation.</div>

<div><br></div><div><div>Pau</div><div><br></div>-- <br><div>Pau Giner</div><div>Interaction Designer</div><div>Wikimedia Foundation</div><br>
</div>
</div></div></div><div class="im"><div><div>_______________________________________________</div><div>Design mailing list</div><div><a href="mailto:Design@lists.wikimedia.org" target="_blank">Design@lists.wikimedia.org</a></div>
<div><a href="https://lists.wikimedia.org/mailman/listinfo/design" target="_blank">https://lists.wikimedia.org/mailman/listinfo/design</a></div></div></div></div></span>
                 
                 
                 
                 
                </blockquote>
                 
                <div>
                    <br>
                </div>
            <br>_______________________________________________<br>
Design mailing list<br>
<a href="mailto:Design@lists.wikimedia.org">Design@lists.wikimedia.org</a><br>
<a href="https://lists.wikimedia.org/mailman/listinfo/design" target="_blank">https://lists.wikimedia.org/mailman/listinfo/design</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Pau Giner</div><div>Interaction Designer</div><div>Wikimedia Foundation</div><br>
</div>