A while back I made https://gerrit.wikimedia.org/r/#/c/65346/ to add the "vform" layout (vertically-stacked using Agora buttons) to the HTMLForm class, and Matt Walker just merged it (thanks!). Forms using HTMLForm can choose this layout and then they'll resemble the Login and Create account pages.
As a demonstration the patch changes Special:PasswordReset to use this layout. It only takes a couple of lines to convert a form: $form->setDisplayFormat( 'vform' ); // Turn the old-school line around the form off. $form->setWrapperLegend( false );
http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset
Cheers,
We wouldn't actually want to stack the buttons, we'd do something like the image below [image: Inline image 1]
* * * * *Jared Zimmerman * \ Director of User Experience \ Wikimedia Foundation M : +1 415 609 4043 | : @JaredZimmermanhttps://twitter.com/JaredZimmerman
On Wed, Oct 16, 2013 at 7:49 PM, S Page spage@wikimedia.org wrote:
A while back I made https://gerrit.wikimedia.org/r/#/c/65346/ to add the "vform" layout (vertically-stacked using Agora buttons) to the HTMLForm class, and Matt Walker just merged it (thanks!). Forms using HTMLForm can choose this layout and then they'll resemble the Login and Create account pages.
As a demonstration the patch changes Special:PasswordReset to use this layout. It only takes a couple of lines to convert a form: $form->setDisplayFormat( 'vform' ); // Turn the old-school line around the form off. $form->setWrapperLegend( false );
http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset
Cheers,
=S Page Features engineer
Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design
On Wed, Oct 16, 2013 at 7:49 PM, S Page spage@wikimedia.org wrote:
A while back I made https://gerrit.wikimedia.org/r/#/c/65346/ to add the "vform" layout (vertically-stacked using Agora buttons) to the HTMLForm class, and Matt Walker just merged it (thanks!). Forms using HTMLForm can choose this layout and then they'll resemble the Login and Create account pages.
As a demonstration the patch changes Special:PasswordReset to use this layout. It only takes a couple of lines to convert a form: $form->setDisplayFormat( 'vform' ); // Turn the old-school line around the form off. $form->setWrapperLegend( false );
http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset
Cool! Thanks S and Matthew. I assume this update will ride the train out to production today? If so, I'll announce.
Obviously this hints at future improvements we could make to this form. For instance: why don't we combine the fields and just say "Username or email address"? Having two fields where you really only need one stinks. If it's technically a bear to combine the fields to accept either type of input, perhaps a radio button to select email or username, with one input field?
Since my other email bounced (?) i'll send as a link, we probably wouldn't want to stack the action buttons, but do something closer to this. https://www.dropbox.com/s/n7t5utb5kavvag4/Screenshot%202013-10-17%2011.54.42...
Steven, if its an either or kind of think (which is unclear even though it says "fill one of the fields" ) then a combined field would certainly be a better plan.
What is the error state for when you do a password reset for an account with a username with no email associated?
* * * * *Jared Zimmerman * \ Director of User Experience \ Wikimedia Foundation M : +1 415 609 4043 | : @JaredZimmermanhttps://twitter.com/JaredZimmerman
On Thu, Oct 17, 2013 at 12:23 PM, Steven Walling swalling@wikimedia.orgwrote:
On Wed, Oct 16, 2013 at 7:49 PM, S Page spage@wikimedia.org wrote:
A while back I made https://gerrit.wikimedia.org/r/#/c/65346/ to add the "vform" layout (vertically-stacked using Agora buttons) to the HTMLForm class, and Matt Walker just merged it (thanks!). Forms using HTMLForm can choose this layout and then they'll resemble the Login and Create account pages.
As a demonstration the patch changes Special:PasswordReset to use this layout. It only takes a couple of lines to convert a form: $form->setDisplayFormat( 'vform' ); // Turn the old-school line around the form off. $form->setWrapperLegend( false );
http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset
Cool! Thanks S and Matthew. I assume this update will ride the train out to production today? If so, I'll announce.
Obviously this hints at future improvements we could make to this form. For instance: why don't we combine the fields and just say "Username or email address"? Having two fields where you really only need one stinks. If it's technically a bear to combine the fields to accept either type of input, perhaps a radio button to select email or username, with one input field?
-- Steven Walling, Product Manager https://wikimediafoundation.org/
Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design
On 10/17/2013 03:44 PM, Jared Zimmerman wrote:
Since my other email bounced (?) i'll send as a link, we probably wouldn't want to stack the action buttons, but do something closer to this. https://www.dropbox.com/s/n7t5utb5kavvag4/Screenshot%202013-10-17%2011.54.42...
No, I got the other one, and it hit the list: http://lists.wikimedia.org/pipermail/design/2013-October/000980.html
Steven, if its an either or kind of think (which is unclear even though it says "fill one of the fields" ) then a combined field would certainly be a better plan.
Let's continue this at https://bugzilla.wikimedia.org/show_bug.cgi?id=40040 , which is a pre-existing bug with relevant discussion.
What is the error state for when you do a password reset for an account with a username with no email associated?
It's disclosed with an explicit error (noemail), currently "There is no email address recorded for user "$USERNAME"."
I was just a tab surprised that's public. Although you can tell if a user can't be emailed, that's not the same as having no email (since there's a preference). Not a big deal, though.
Matt Flaschen
On Thu, Oct 17, 2013 at 12:44 PM, Jared Zimmerman < jared.zimmerman@wikimedia.org> wrote:
Steven, if its an either or kind of think (which is unclear even though it says "fill one of the fields" ) then a combined field would certainly be a better plan.
What is the error state for when you do a password reset for an account with a username with no email associated?
I've started https://www.mediawiki.org/wiki/Password_reset as a framework for us to document what's going on here. I'll fill it in as I can, and others (S, Jared?) if you could help that would be awesome.
Steven Walling wrote:
I've started https://www.mediawiki.org/wiki/Password_reset as a framework for us to document what's going on here.
Thanks for working on https://bugs.wikimedia.org/40040.
There's been inexplicable resistance to calling that page a requests for comment, though it certainly appears to fit the label.
MZMcBride
On 10/16/2013 10:49 PM, S Page wrote:
A while back I made https://gerrit.wikimedia.org/r/#/c/65346/ to add the "vform" layout (vertically-stacked using Agora buttons) to the HTMLForm class, and Matt Walker just merged it (thanks!). Forms using HTMLForm can choose this layout and then they'll resemble the Login and Create account pages.
Congratulations, S. This is a big deal, and a significant step forward towards reusable UI components.
Matt Flaschen
