On Wed, Oct 16, 2013 at 7:49 PM, S Page <spage(a)wikimedia.org> wrote:
A while back I made
https://gerrit.wikimedia.org/r/#/c/65346/ to add the
"vform" layout (vertically-stacked using Agora buttons) to the HTMLForm
class, and Matt Walker just merged it (thanks!). Forms using HTMLForm can
choose this layout and then they'll resemble the Login and Create account
pages.
As a demonstration the patch changes Special:PasswordReset to use this
layout. It only takes a couple of lines to convert a form:
$form->setDisplayFormat( 'vform' );
// Turn the old-school line around the form off.
$form->setWrapperLegend( false );
http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset
Cool! Thanks S and Matthew. I assume this update will ride the train out to
production today? If so, I'll announce.
Obviously this hints at future improvements we could make to this form. For
instance: why don't we combine the fields and just say "Username or email
address"? Having two fields where you really only need one stinks. If it's
technically a bear to combine the fields to accept either type of input,
perhaps a radio button to select email or username, with one input field?
--
Steven Walling,
Product Manager
https://wikimediafoundation.org/