That's partly (but not strongly) why I think both should be quiet destructive. But
since both would be quiet, either quiet neutral (cancel) or quiet destructive (discard)
the user won't actually see a color change or appearance when they enter text.
For non-JS I'll say what I always say. We should have a graceful controlled
degradation for these users. In this can they will see no change. eg. the button will
always say cancel , and not change based on their actions.
Sent while mobile
On Mar 5, 2014, at 7:22 AM, Shahyar Ghobadpour <sghobadpour(a)wikimedia.org> wrote:
Do we really want to change the button from something else to destructive once text has
been entered? What do we do about users whose browsers don't support JavaScript?
We need to be careful with setting too strict of rules in situations like this. I find the
color of the button is important for many users to distinguish the difference between
actions at first glance. In the case of Flow, where we have Cancel (or Discard -- the
wording of which actually makes more sense), Preview, and Reply/Add topic, I don't
want to have two buttons side-by-side of the exact same color that perform drastically
different actions (Preview and Cancel).
--Shahyar
On Wed, Mar 5, 2014 at 8:51 AM, Steven Walling
<swalling(a)wikimedia.org> wrote:
On Wed, Mar 5, 2014 at 8:20 AM, Matthew Flaschen
<mflaschen(a)wikimedia.org> wrote:
The current proposed change to use mw-ui-button for save/preview/show changes/cancel (on
the edit screen) uses mw-ui-destructive (with quiet) for the cancel button. This directly
contradicts the style guide, which says, "This should not be used for cancel
buttons.".
As noted at
https://gerrit.wikimedia.org/r/#/c/116725/ , my understanding of destructive
is that you are deleting something that was already publicly visible, or at least has an
impact beyond your own personal session.
The cancel button doesn't seem to fit that. Cancel is a common concept, and
semantically clear, so perhaps we should simply add mw-ui-cancel.
In addition to that... the author is asking if Save page should be mw-ui-constructive
(green). That's correct right? mw-ui-primary is actually deprecated in the new
version, and save is not a multi-step action so it's not mw-ui-progressive (blue).
Jared?
--
Steven Walling,
Product Manager
https://wikimediafoundation.org/
_______________________________________________
Design mailing list
Design(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/design
_______________________________________________
Design mailing list
Design(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/design