On 09/21/2012 01:28 PM, Daniel Friesen wrote:
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
On 12-09-21 10:05 AM, Yury Katkov wrote:
Hi Daniel!
Honestly we generally don't include any theme someone just comes up with into core.
...and that's very bad. I don't have the proper statistics about what themes are in use on the MediaWiki installation, but I saw a lot of MW-wikis, and remember none of them that use Modern, Chickpea, Cologneblue, Standard, Simple or Nostalgia skin. My personal opinion that this is because those skins looks too Web1.0-ish or ugly.
They look Web1.0-ish because they were built when web was at 1.0 ;). They're just around for compat right now. In fact, they're not just compat. They're tucked away in a set of code called legacy so that all I have to do to remove them from MW forever is git rm a few files.
I think we might have gotten to the point where this conversation ought to be on wikitech-l instead.
But just to clarify how the skins and legacy stuff works, for the benefit of Nick and other folks on this list who may be less familiar: the older skins such as "CologneBlue", "Nostalgia", and "Standard" are stored alongside Vector, etc. in the [mediawiki/core.git]/skins/ directory. Those older skins all extend SkinLegacy, which you can see in [mediawiki/core.git]/includes/SkinLegacy.php [0].
MediaWiki's core codebase gets changed when one of the MediaWiki core owners approves a change. (The list of people who can do that is in Gerrit [1].) So to remove those legacy skins from MediaWiki, Daniel would have to submit a changeset removing those skins and SkinLegacy.php, and then have that removal approved. But likely, for a substantive change like that, we'd want a discussion on the wikitech-l list or an RfC on mediawiki.org.
Nick, one more thing -- have you already tested your skin on various mobile devices?
[0] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes... [1] https://gerrit.wikimedia.org/r/#/admin/groups/11,members