Hey,
The commit moving the files in the DataValues repo around finally has been merged \o/. We can thus now create the 2 new git repos that still need to be created (the ValueView one is already there). We however still do not have settled on names for these. Currently we have:
* DataValues(.git) (Composer: data-values/data-values): the DataValues interface and trivial implementations (ie BooleanValue). * DataValuesInterfaces(.git) (Composer: data-values/interfaces): ValueParser/Formatter/Validator interfaces and trivial implementations * DataValuesCommon(.git) (Composer: data-values/common): All currently existing non-trivial implementations of the interfaces defined by the above two packages that are not in Wikibase. Things might be split from this at a later point if we deem this to be of use (for instance having a DataValuesGeo data-values/geo with GlobeCoordinateValue, LatLongValue and all the parsing and formatting code).
We will not be able to change these names without a lot of hassle later on, so if you do not agree with one of the later two, speak up now. Unless there are better suggestions, I'll be requesting repos with said names this weekend.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --
Am 04.09.2013 22:17, schrieb Jeroen De Dauw:
- DataValues(.git) (Composer: data-values/data-values): the DataValues
interface and trivial implementations (ie BooleanValue).
- DataValuesInterfaces(.git) (Composer: data-values/interfaces):
ValueParser/Formatter/Validator interfaces and trivial implementations
I don't really like this. If I see DataValues and DataValuesInterfaces side by side, i'd assume that DataValuesInterfaces contains the interfaces and DataValues the implementations - while, if I understand correctly, DataValues contains the interfaces and DataValuesInterfaces contains *more* interfaces.
I can't think of a very good name... "DataValueHelpers" isn't too gereat :)
- DataValuesCommon(.git) (Composer: data-values/common): All currently
existing non-trivial implementations of the interfaces defined by the above two packages that are not in Wikibase. Things might be split from this at a later point if we deem this to be of use (for instance having a DataValuesGeo data-values/geo with GlobeCoordinateValue, LatLongValue and all the parsing and formatting code).
CommonDataValues sounds better, and is clearer, I think.
-- daniel
Hey,
I don't really like this. If I see DataValues and DataValuesInterfaces side
by side, i'd assume that DataValuesInterfaces contains the interfaces and DataValues the implementations - while, if I understand correctly, DataValues contains the interfaces and DataValuesInterfaces contains *more* interfaces.
That is true. Perhaps this is somewhat hard to avoid without renaming DataValues itself. Something like "DataValuesCore" or "DataValuesBase" can help to avoid confusion. At this point we cannot really change the repo name, change the namespace, or change the Composer package name without causing lots of hassle though. We can still rename it, but then should hold into account the name will not be fully reflected at all places, which might in itself cause confusion.
Improving DataValuesInterfaces in such a way that it does not cause the kind of confusion described would be preferred. Still have not seen any better suggestions though.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --
Not good, but just to make a suggestion...
DataValues DataServices DataValuesExt
2013/9/5 Jeroen De Dauw jeroendedauw@gmail.com
Hey,
I don't really like this. If I see DataValues and DataValuesInterfaces
side by side, i'd assume that DataValuesInterfaces contains the interfaces and DataValues the implementations - while, if I understand correctly, DataValues contains the interfaces and DataValuesInterfaces contains *more* interfaces.
That is true. Perhaps this is somewhat hard to avoid without renaming DataValues itself. Something like "DataValuesCore" or "DataValuesBase" can help to avoid confusion. At this point we cannot really change the repo name, change the namespace, or change the Composer package name without causing lots of hassle though. We can still rename it, but then should hold into account the name will not be fully reflected at all places, which might in itself cause confusion.
Improving DataValuesInterfaces in such a way that it does not cause the kind of confusion described would be preferred. Still have not seen any better suggestions though.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --
Wikidata-tech mailing list Wikidata-tech@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
Hey,
As there where no better suggestions further then CommonDataValues, I requested the new repos to be created with the current names: https://www.mediawiki.org/wiki/Git/New_repositories/Requests
Until the actual move is in progress, suggestions with better names are still helpful.
Somewhat off topic: as you can see there, I also requested a Wikidata git repo, which seems the most obvious name for the one in which be put a Wikidata specific build.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --
I would prefer "DataValueImplementations" over "CommonDataValues".
2013/9/7 Jeroen De Dauw jeroendedauw@gmail.com:
Hey,
As there where no better suggestions further then CommonDataValues, I requested the new repos to be created with the current names: https://www.mediawiki.org/wiki/Git/New_repositories/Requests
Until the actual move is in progress, suggestions with better names are still helpful.
Somewhat off topic: as you can see there, I also requested a Wikidata git repo, which seems the most obvious name for the one in which be put a Wikidata specific build.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --
Wikidata-tech mailing list Wikidata-tech@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
Hey,
I would prefer "DataValueImplementations" over "CommonDataValues".
Why?
One argument for this is that it will be more consistent with the Composer package name, which will be in the form of data-values/something.
An argument against is that CommonDataValues better describes the package (it does not contain all implementations, just the "common" ones), and is probably easier to understand when you've not come across it before.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --
Why:
Exactly for the first argument you brought. Also because "CommonDataValues" sounds even more like it only contains DataValue implementations in my ears, while there is other stuff inside (parsers, etc.). It also just came to me that "common" might be quite meaningless, what does it refer to, what do these implementations have in common, or why do they come in common? The answer is, they are complex. So "ComplexDataValues" could also be a possibility if you don't like "DataValueImplementations".
Your argument against "DataValueImplementations" is no good for me, the name does not really imply that it could be the only component with implementations.
2013/9/7 Jeroen De Dauw jeroendedauw@gmail.com:
Hey,
I would prefer "DataValueImplementations" over "CommonDataValues".
Why?
One argument for this is that it will be more consistent with the Composer package name, which will be in the form of data-values/something.
An argument against is that CommonDataValues better describes the package (it does not contain all implementations, just the "common" ones), and is probably easier to understand when you've not come across it before.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --
Wikidata-tech mailing list Wikidata-tech@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
wikidata-tech@lists.wikimedia.org