commonElements (one of the screen stylesheets for both Monobook and Vector) has:
a:hover, a:focus { text-decoration: underline; }
Do you think it makes sense to turn this underline off for all a.mw-ui-buttons (Agora buttons using an a element)?
We're doing this for GuidedTour buttons (e.g. https://commons.wikimedia.org/wiki/File:Guiders-Agorastyle.png), but I thought it might be of broader use.
Thanks,
Matt Flaschen
Aye, it would - underlines normally don't make a whole lot of sense for buttons because it's just not something buttons traditionally do, so if there is a reason for one to have an underline, it should be the exception, not the default.
On 27/04/13 21:56, Matthew Flaschen wrote:
commonElements (one of the screen stylesheets for both Monobook and Vector) has:
a:hover, a:focus { text-decoration: underline; }
Do you think it makes sense to turn this underline off for all a.mw-ui-buttons (Agora buttons using an a element)?
We're doing this for GuidedTour buttons (e.g. https://commons.wikimedia.org/wiki/File:Guiders-Agorastyle.png), but I thought it might be of broader use.
Thanks,
Matt Flaschen
Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design
On Saturday, April 27, 2013, Isarra Yos wrote:
Aye, it would - underlines normally don't make a whole lot of sense for buttons because it's just not something buttons traditionally do, so if there is a reason for one to have an underline, it should be the exception, not the default.
Agreed.
On 27/04/13 21:56, Matthew Flaschen wrote:
commonElements (one of the screen stylesheets for both Monobook and Vector) has:
a:hover, a:focus { text-decoration: underline; }
Do you think it makes sense to turn this underline off for all a.mw-ui-buttons (Agora buttons using an a element)?
We're doing this for GuidedTour buttons (e.g. https://commons.wikimedia.org/**wiki/File:Guiders-Agorastyle.**pnghttps://commons.wikimedia.org/wiki/File:Guiders-Agorastyle.png), but I thought it might be of broader use.
Thanks,
Matt Flaschen
______________________________**_________________ Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/designhttps://lists.wikimedia.org/mailman/listinfo/design
-- -— Isarra
______________________________**_________________ Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/designhttps://lists.wikimedia.org/mailman/listinfo/design
On 04/27/2013 06:57 PM, Steven Walling wrote:
On Saturday, April 27, 2013, Isarra Yos wrote:
Aye, it would - underlines normally don't make a whole lot of sense for buttons because it's just not something buttons traditionally do, so if there is a reason for one to have an underline, it should be the exception, not the default.Agreed.
Thank you both for the feedback. Up at https://gerrit.wikimedia.org/r/#/c/61247/
Matt Flaschen
On Sat, Apr 27, 2013 at 1:56 PM, Matthew Flaschen mflaschen@wikimedia.org wrote:
commonElements (one of the screen stylesheets for both Monobook and Vector) has:
a:hover, a:focus { text-decoration: underline; }
Do you think it makes sense to turn this underline off for all a.mw-ui-buttons (Agora buttons using an a element)?
The hover is unnecessary, but we need something for focus. Otherwise you can't tell that button has the focus when you tab through items. Try it on http://en.wikipedia.org/wiki/Special:UserLogin?useNew=1 , tab through until you get to the [ Join Wikipedia ] button. Chromium outlines the button in black, but Firefox does nothing. I think it needs the same focus glow that's in agora-field-styling. I filed bug 47901.
Also, I just noticed in Chromium that the Remember checkbox doesn't show a focus highlight, bug 47902.
-- =S Page software engineer on E3