I've merged Bartosz's patch (https://gerrit.wikimedia.org/r/#/c/82828/) for rolling out the boxes to all forms, not just vforms.
He used the same colors as the vform styles. It seems to me that the success and error boxes might be better with a little more color contrast.
You can test on Beta (http://en.wikipedia.beta.wmflabs.org/) by editing your preferences (success), going to Special:UserLogin while logged in (warning), and entering the wrong password for login (error).
Matt Flaschen
On Tue, Oct 29, 2013 at 12:25 PM, Matthew Flaschen mflaschen@wikimedia.orgwrote:
I've merged Bartosz's patch (https://gerrit.wikimedia.org/**r/#/c/82828/https://gerrit.wikimedia.org/r/#/c/82828/) for rolling out the boxes to all forms, not just vforms.
He used the same colors as the vform styles. It seems to me that the success and error boxes might be better with a little more color contrast.
You can test on Beta (http://en.wikipedia.beta.**wmflabs.org/http://en.wikipedia.beta.wmflabs.org/) by editing your preferences (success), going to Special:UserLogin while logged in (warning), and entering the wrong password for login (error).
These changes have been backported to the current MediaWiki release, and they're visible on production now, including mobile versions of the examples Matt pointed to above.
For a bit more background: IIRC Bartosz generated the palette here based on the error message style, which Munaf designed in vform for the login and signup redesign. I agree we should make sure the contrast is enough to meet accessibility guidelines, but the nicest thing about the new styles are that it is more cohesive than previous, and we should make sure to retain that. :)
Nice work!
On Tue, Oct 29, 2013 at 12:25 PM, Matthew Flaschen mflaschen@wikimedia.orgwrote:
You can test on Beta (http://en.wikipedia.beta.wmflabs.org/) by editing your preferences (success), going to Special:UserLogin while logged in (warning), and entering the wrong password for login (error).
Nice, but then I tried a random form :) Go to http://en.wikipedia.beta.wmflabs.org/wiki/Special:ChangeEmail and enter an invalid password. It's an easy fix.
For grins, enter valid/invalid e-mail... you get weird green and pink client-side validation "strips" (and the browser's own type="email" HTM5 validation warning when you submit).
I filed bug 56363. Improving this ancient form could be a nice OPW job.
On 10/30/2013 02:38 AM, S Page wrote:
Nice work!
Bartosz gets the credit. I just reviewed it.
Nice, but then I tried a random form :) Go to http://en.wikipedia.beta.wmflabs.org/wiki/Special:ChangeEmail and enter an invalid password. It's an easy fix.
Yep, this is pre-existing, but it should use errorbox.
Matt Flaschen