On 08/19/2014 06:29 PM, Jared Zimmerman wrote:
Then let's make a Beta feature to allow people to
test and see
medaiwiki.ui in context in vector(at least) and report problems.
I don't have a strong position either way on this yet. However, we need
to be clear that not every incremental improvement to the UI is going to
go through the Beta Feature cycle.
For example, say we do those three controls (plus what we already have)
as part of the big rollout. I would not think e.g. a new <input
type="number"> control, or enhancements to the existing MW UI controls,
should have a whole Beta Feature cycle.
I'd love to be able to provide a fixed element on
screen that allows
someone to quickly and easily report problems with a control on a
particular page (isn't using mediawiki.ui style, isn't using right type
(progressive, constructive, destructive) and right style normal, quiet,
etc. and any issues around order or logic, e.g. on WTE Save should be
the rightmost according to mediawiki.ui guidelines and there are too
many Primary style buttons.
If we want to work on this, I suggest we improve the existing
mediawiki.feedback.
This won't be our first Beta feature that is more
for learning and
testing with no plans to graduate but we should be clear that that's
what its for in the description on the beta page, so people can give
helpful and constructive feedback knowing that it will be an iterative
process.
To be clear, I do intend this to be finalized or be rolled back
relatively soon. We are currently using a global variable, and two code
paths in various places. This is a compromise we arrived at as an
incremental solution (so we can work on it without continually amending
one big patch).
However, I want to get rid of $wgUseMediaWikiUIEverywhere (keeping the
new MW UI controls). Also, I don't support doing such a global for all
cases. It was appropriate in this case (which has major impacts on e.g.
the edit form), but that doesn't mean it necessarily would be in a
future case (where e.g. we add one or two controls).
Matt Flaschen