As a general rule, we've not added widgets to OOjs UI until we had an actual use for them, so indeed there are some missing pieces, which when an application starts using the library should be added.
Any differences between OOjs UI and MediaWiki UI should be reported as bugs and assigned to Prateek, who I've added to this thread. Again, I got him started, but the OOjs UI theme is not intended to diverge from, but rather be perfectly in step with, the latest from the design team. If one of the libraries is being neglected that's a bug not a design.
We, as an organization, need to converge our engineering practices so that all of our products are written using the same libraries, use the same patterns, are documented in the same places and share as much of everything as possible between them. The state of things suggests that the lack of one-true-standard has not led us to converge naturally, so we've now instated one. We need everyone to participate in improving it so it can serve more use cases, run on more devices, look better, load faster and generally suck less.
Ryan has done a great job of identifying some of the steps that will be involved here. It would be really excellent if we could start seeing some boards in Phabricator around steps to get each product to that point.
- Trevor
On Mon, Feb 2, 2015 at 4:05 PM, Ryan Kaldari rkaldari@wikimedia.org wrote:
Forget to mention that CentralNotice is also using jQuery UI date-picker.
On Mon, Feb 2, 2015 at 4:03 PM, Ryan Kaldari rkaldari@wikimedia.org wrote:
Here's a quick audit of potential issues/blockers for OOJS migration:
Elements in mediawiki-ui that are missing in OOJS UI:
- stackable "block" buttons (needed for MobileFrontend)
- big buttons (used by UploadWizard)
- large inputs (used in Flow)
- anchors (used in MobileFrontend)
Elements in jQueryUI that are missing in OOJS UI:
- datepicker (used by UploadWizard)
- multi-select (used by CentralNotice)
Styles which do not match between mediawiki-ui and OOJS UI:
- constructive, destructive, progressive buttons - Which styles do we
want to use?
- frameless constructive, destructive, progressive buttons - Which styles
do we want to use?
- disabled buttons - The disabled buttons in OOJS UI are difficult to
read. They should probably adopt mediawiki-ui's disabled style.
- standalone icon buttons - much smaller in OOJS UI, we probably need two
different size options.
Can't tell if styles match due to OOjs living style guide entries that aren't actually living (uses screenshots instead):
- ButtonGroupWidget
- PopupButtonWidget
- ButtonInputWidget
- FormLayout
- PanelLayout
- Dialog
- ProcessDialog
- MessageDialog
Kaldari
On Mon, Feb 2, 2015 at 2:07 PM, Trevor Parscal tparscal@wikimedia.org wrote:
Replies inline. Hopefully some useful clarification.
On Mon, Feb 2, 2015 at 1:48 PM, Ryan Kaldari rkaldari@wikimedia.org wrote:
<snip> * OOjs UI styles (i.e. Trevor's styles) * mediawiki-ui styles (i.e. Jared and May's styles)
MediaWiki UI is a transitional system which has allowed interfaces to be modernized and the design work to be iterated on, in context, before OOjs UI was ready for use. There shouldn't be any significant differences between MediaWiki UI and OOjs UI, but where there is a difference we should seek to make both systems look the same where possible until MediaWiki UI is no longer in use. OOjs UI within MediaWiki is using the theme designed by May, implemented by Prateek with some help from me. They are not my styles.
- jQuery UI/old-Agora styles (i.e. Brandon's styles)
The new styles have not been back-ported to jQuery UI, and I don't believe there's any plan to do so. The objective is instead to stop using jQuery UI and replace those interfaces with their OOjs UI equivalents over time. Unfortunately jQuery UI is difficult to theme, which is actually one of the many reasons we have decided to move away from it.
- default MediaWiki element styling (skins)
Default MediaWiki styling (per skin) is really the lack of styling in practice because none of our skins provide styled form controls or other reusable widgets.
- Trevor
Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design
Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design