On 05/07/2013 12:29 PM, Nick White wrote:
On Thu, May 02, 2013 at 01:07:26PM +0100, Nick White wrote:
You may remember me as the person who introduced the Erudite skin a few months ago. Since that time I've made lots of changes to it locally that are almost ready to go back up to the version on Mediawiki's servers.
OK, I've decided on a way forward. I've split the PHP & logic changes up into two patches (or changesets, or whatever gerrit calls them), and will try my best to split up the CSS changes into logical parts (though that will take a bit longer, and likely be less perfectly compartmentalised).
The two PHP changes have now been submitted to gerrit, at:
If anybody has time it would be great if they could take a look. Should I post elsewhere to get reviewers as well, or ask on IRC?
I'll post here once the CSS changes are ready, but it will take me a bit longer.
Nick
Here are some tips for getting reviews: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews Are those helpful at all?
Asking on IRC can also be helpful, especially if you can articulate the benefit of the merge -- how many users does the Erudite skin have?