On Sat, Apr 27, 2013 at 1:56 PM, Matthew Flaschen mflaschen@wikimedia.org wrote:
commonElements (one of the screen stylesheets for both Monobook and Vector) has:
a:hover, a:focus { text-decoration: underline; }
Do you think it makes sense to turn this underline off for all a.mw-ui-buttons (Agora buttons using an a element)?
The hover is unnecessary, but we need something for focus. Otherwise you can't tell that button has the focus when you tab through items. Try it on http://en.wikipedia.org/wiki/Special:UserLogin?useNew=1 , tab through until you get to the [ Join Wikipedia ] button. Chromium outlines the button in black, but Firefox does nothing. I think it needs the same focus glow that's in agora-field-styling. I filed bug 47901.
Also, I just noticed in Chromium that the Remember checkbox doesn't show a focus highlight, bug 47902.
-- =S Page software engineer on E3