On Mon, Jan 6, 2014 at 1:36 PM, May Tee-Galloway mgalloway@wikimedia.orgwrote:
- Quiet buttons. I remember clearly from talking to May that we wanted
them to be colored in their default state and make them slightly darker in hover. I don't remember what they were supposed to look like when disabled. Right now they're slightly lighter but maybe they should be all gray?
Thats not quite right, unless May changes it the quite buttons should be black normally, their action color on hover, and the action color click state (darker version) on click. https://www.dropbox.com/s/amh0gfgc1p2i6c6/Screenshot%202014-01-03%2010.24.45... for the neutral state which is normal:black -> hover:#747474 -> click:black
The change in colors is not documented anywhere, unfortunately. But I'm pretty sure they were meant to have color without hovering, at least because there is no hover state on mobile. Let's double check on Monday.
••
The only times when quiet buttons have color by default is when it's an action we want to emphasize. For example.. "Thank," or when going through a certain workflow, highlighting the next progressive action like "Next", especially when it's destructive like "Overwrite edit". These examples don't exist currently because we don't have a "Thank" action on Flow or do we use quiet buttons for progressive actions within workflows. But when we do, they will be colored. All other instances will be black.
When quiet buttons are colored by default, what color is it? If it's the same as the second row of https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Agora_Control_Lib..., then the button has no mouseover state, so we've improved mobile and degraded desktop.
Please add this to https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Agora_Control_Lib..., thanks. [1]
We have to name this new kind, is it mw-ui-quiet-colored instead of mw-ui-quiet, or another modifier style? class="mw-ui-button mw-ui-progressive mw-ui-quiet mw-colored-default" is getting a bit long.
Cheers.
[1] We have a big problem with out-of-date design documents, cf. * https://www.mediawiki.org/wiki/File:Agora_specs.pdf * https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Patterns_and_comp... * https://www.mediawiki.org/wiki/Style_guide If people won't update them we need to rename them all "2013 NN Design Proposal", and let the code comments that produce the living style guide be authoritative.