Since my other email bounced (?) i'll send as a link, we probably wouldn't want to stack the action buttons, but do something closer to this. https://www.dropbox.com/s/n7t5utb5kavvag4/Screenshot%202013-10-17%2011.54.42...
Steven, if its an either or kind of think (which is unclear even though it says "fill one of the fields" ) then a combined field would certainly be a better plan.
What is the error state for when you do a password reset for an account with a username with no email associated?
* * * * *Jared Zimmerman * \ Director of User Experience \ Wikimedia Foundation M : +1 415 609 4043 | : @JaredZimmermanhttps://twitter.com/JaredZimmerman
On Thu, Oct 17, 2013 at 12:23 PM, Steven Walling swalling@wikimedia.orgwrote:
On Wed, Oct 16, 2013 at 7:49 PM, S Page spage@wikimedia.org wrote:
A while back I made https://gerrit.wikimedia.org/r/#/c/65346/ to add the "vform" layout (vertically-stacked using Agora buttons) to the HTMLForm class, and Matt Walker just merged it (thanks!). Forms using HTMLForm can choose this layout and then they'll resemble the Login and Create account pages.
As a demonstration the patch changes Special:PasswordReset to use this layout. It only takes a couple of lines to convert a form: $form->setDisplayFormat( 'vform' ); // Turn the old-school line around the form off. $form->setWrapperLegend( false );
http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset
Cool! Thanks S and Matthew. I assume this update will ride the train out to production today? If so, I'll announce.
Obviously this hints at future improvements we could make to this form. For instance: why don't we combine the fields and just say "Username or email address"? Having two fields where you really only need one stinks. If it's technically a bear to combine the fields to accept either type of input, perhaps a radio button to select email or username, with one input field?
-- Steven Walling, Product Manager https://wikimediafoundation.org/
Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design