Yeh that was my fault. The issue with MobileFrontend is there are various places, login form included that monkey patch core functionality. One of my goals this year is to eradicate those, so styling for mobile becomes less difficult. I've submitted a patch to fix that [1]. Echo is another one and I'm working with BSitu to sort this out.
This bug [2]] is also another great example of where mobile is currently doing its own thing and not using MediaWiki UI where it possibly should be.
/me imagines a situation where all the teams put their rings together and become code merging power rangers
[1] https://gerrit.wikimedia.org/r/154979 [2] https://bugzilla.wikimedia.org/show_bug.cgi?id=69487
On Mon, Aug 18, 2014 at 5:10 PM, Matthew Flaschen mflaschen@wikimedia.org wrote:
On 08/18/2014 07:44 PM, Maryana Pinchuk wrote:
Always good to get at least one MFE engineer's eyes on any change likely to affect mobile before it gets merged; it's either that or the much more ambitious goal of getting every WMF engineer to remember to test user-facing changes vigorously on phones and tablets (which I do hope we'll get to one day...) ;)
It's Jon's change (https://gerrit.wikimedia.org/r/#/c/149173/). However, I do respect your point about testing on mobile.
Matt Flaschen
Design mailing list Design@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design