On Wed, Nov 14, 2012 at 5:47 AM, Steven Walling swalling@wikimedia.org wrote:
In the interest of not waiting any more, my instinct is to deploy the first JS-reliant version, and defer perfecting the implementation based on when patches get submitted. :)
I would prefer that we not get too much in the habit of accepting degradation of front-end performance and long term maintainability of our codebase in order to push features out the door more quickly -- especially where it concerns code that gets loaded on every pageview. Existing poor practices and problems are not a good reason for exacerbating the issue (and indeed setting a poor example will reduce our ability to set standards for others).
As you yourself say, site performance really matters, and that includes flashes of unstyled content and DOM changes that shouldn't be necessary. Moreover, JS cruft leads to maintenance burden down the road.
I'm very accepting of doing this when our objective is to learn whether something is working or not (cf. ACUX). But the moment we actually decide that a change makes sense, we should implement it at a reasonable level of quality instead of layering on cruft.
So if you want to make the decision now that this change makes sense based on the data we already have, please do a clean implementation first. It can't become someone else's problem to do so.
Thanks, Erik