Brad Jorsch schreef:
On Wed, Feb 11, 2009 at 05:05:05PM +0100, Roan Kattouw wrote:
Yeah, you can either do array_keys() then sort(), or ksort() then array_keys(). I seem to have thought the other way.
At the moment, you have array_keys() then asort()/ksort().
- You may or may not try to process 'Bdoesnotexist'. If so, it fails too. Do you set incontinue=0 now? Or leave it as 2?
The continue parameter can never be set twice; trying to do that throws a fatal error. I added a guard against processing missing pages when the existing pages didn't fit in my working copy, which I'll commit today.
That's good.
Did that just now in r47189.
And you don't set incontinue=0 in this case, but incontinue=3 (because $count isn't reset).
That would still be broken, but it can't happen as you said above so it doesn't matter.
** Someone creates Bdoesnotexist.
Yes, that sucks. I'm still thinking about how to handle this best (because creating a page could cause another page to be skipped entirely).
[...]
** Someone deletes A.
Yes, like I said above, page creations can cause trouble too.
I don't think there is a way while still keeping the continue parameter offset-based.
Even title-based continue parameters have that problem. I'm thinking I might wanna merge $titles and $missing and use a more generic handler for them. The prop=info module needs some cleanup anyway (mostly splitting stuff into different functions), so I guess that's gonna be my project for the weekend.
Roan Kattouw (Catrope)