There've been some worries expressed on the changeset comments, namely:

* changing the JSON OpenSearch behavior changes MediaWiki's search box suggestion behavior, and right now it may be unclear just what's going on

Possibilities are:

a) do this change, but also change the search suggestion module that uses the JSON OpenSearch to use the old behavior

b) do a similar change that switches the XML default to the old JSON default instead

c) cancel this changeset and go improve the search dropdown frontend before tweaking this again?

Thoughts?

-- brion

On Thu, Feb 12, 2015 at 2:29 PM, Brion Vibber bvibber@wikimedia.org wrote:

I've got a changeset in code review to make the default redirect resolution behavior of action=opensearch consistent between JSON and XML-mode requests.

Bug: https://phabricator.wikimedia.org/T19142 Patch: https://gerrit.wikimedia.org/r/#/c/190290

Originally the JSON version did not resolve redirects as it was easier to implement that way, while the XML implementation was separately written and did resolution in order to improve display of content snippets. Content snippets are now included in JSON as well as XML since the implementations were merged, and in general it seems to be better behavior to be consistent across data formats for the same requests.

The original behavior can be obtained by supplying an explicit 'redirects=return' parameter to the API request.

Are there any compatibility worries here?

-- brion