*Matthias*:
Worked on bugs today, merged some patches. Back to search after this.
*Shahyar*:
Wrote code for handlers on history page (H-8), but it got messy. This would be a good time to start implementing OOJS. Today -- start modifying our base classes, so they use OOJS to initialize. Then they can inherit off of one another, and it'll help us clean up the JS code on the Flow board later. This should be a one-day project, although Erik isn't sure. S suggests -- split up into discrete patches For new modal -- create a new card for changing modal dialog in core, and declare victory on G-11. I-4: Adding Flow topic actions menu in no-JS. Put up a patch for it, add
*Erik*:
Mostly working on fixing bugs yesterday. A bunch in code review, including new topic notifications linking to the board page. Working on 1-1: Hide updates. Working on adding a way to handle calling the moderated topics. It means denormalizing the current moderation state. We'll deploy the new topic notifications fixes tomorrow, to backport and get the bugs fixed before it goes to enwiki.
Shahyar let me know if you need any help on the OOJS side of things. On 23 Sep 2014 11:08, "Danny Horn" dhorn@wikimedia.org wrote:
*Matthias*:
Worked on bugs today, merged some patches. Back to search after this.
*Shahyar*:
Wrote code for handlers on history page (H-8), but it got messy. This would be a good time to start implementing OOJS. Today -- start modifying our base classes, so they use OOJS to initialize. Then they can inherit off of one another, and it'll help us clean up the JS code on the Flow board later. This should be a one-day project, although Erik isn't sure. S suggests -- split up into discrete patches For new modal -- create a new card for changing modal dialog in core, and declare victory on G-11. I-4: Adding Flow topic actions menu in no-JS. Put up a patch for it, add
*Erik*:
Mostly working on fixing bugs yesterday. A bunch in code review, including new topic notifications linking to the board page. Working on 1-1: Hide updates. Working on adding a way to handle calling the moderated topics. It means denormalizing the current moderation state. We'll deploy the new topic notifications fixes tomorrow, to backport and get the bugs fixed before it goes to enwiki.
EE mailing list EE@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ee
On Tue, Sep 23, 2014 at 11:07 AM, Danny Horn dhorn@wikimedia.org wrote:
*Shahyar*:
... For new modal -- create a new card for changing modal dialog in core, and declare victory on G-11.
I misspoke, I meant declare victory on G-5 "Spike-ish: mw-ui standardization (the stuff Shahyar worked on around his visit)."
May and Shahyar need to nail down the Flow moderation dialog appearance, AIUI it's a "not so simple" modal with a title but no ✕ ✓. We need patches for this by Wednesday, otherwise the dialog we have now goes out on Thursday to mediawiki.org
Modal dialog for core is tracked on the Mediawiki.ui Trello board, https://trello.com/c/uAoYLKf1
Shahyar needs to send e-mail to the design list about the new modal.