Chris, where do you see Lock not requiring a reason?
Here's a screenshot from https://www.mediawiki.org/wiki/Talk:Sandbox -- choosing Lock in the action menu gives you a box to write the reason. The "Lock topic" button is grayed out until you type a reason.
On Tue, Jan 13, 2015 at 12:29 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Tue, Jan 13, 2015 at 11:42 AM, Danny Horn dhorn@wikimedia.org wrote:
Erik will be the release readiness review ranger this week. S says that some of the tests have been fataling for a while -- he has a writeup of Jenkins tips that the team says would be helpful.
I fixed the no-javascript test, it was a minor update to the locator for the Topic. https://gerrit.wikimedia.org/r/#/c/184732/1
Before fixing the lock-unlock test, I'd like to have some idea of whether Locking a topic should require a reason: https://phabricator.wikimedia.org/T86579. I'm content to let those tests fail until we know. -Chris
EE mailing list EE@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ee
