Hello, Per stats https://www.mediawiki.org/wiki/Gerrit/Reports/Changesets_by_project. There are 305 open change sets in pywikibot/core which make us the second project after mediawiki/core in number of open change sets. Open change sets won't do any harm but sometimes it's hard to find good patches in pool of out-of-date-or-not-needed-anymore patches.
Some projects have rules like "if a change set has -2 for more than N weeks, it can be abandoned" it can work for us. Also I think if we look into our own old patches we might find several patches that are not needed anymore due to several reasons such as being implemented another way, too big schema change in pywikibot, etc. We can abandon them. Please check your old patches.
Best
A better way would be to commit some patches. There are a lot of proposals which have minor changes and could be approved quickly.
best
xqt
----- Original Nachricht ---- Von: Amir Ladsgroup ladsgroup@gmail.com An: Pywikibot discussion list pywikibot@lists.wikimedia.org Datum: 09.02.2016 18:10 Betreff: [pywikibot] Number of open changesets
Hello, Per stats https://www.mediawiki.org/wiki/Gerrit/Reports/Changesets_by_project. There are 305 open change sets in pywikibot/core which make us the second project after mediawiki/core in number of open change sets. Open change sets won't do any harm but sometimes it's hard to find good patches in pool of out-of-date-or-not-needed-anymore patches.
Some projects have rules like "if a change set has -2 for more than N weeks, it can be abandoned" it can work for us. Also I think if we look into our own old patches we might find several patches that are not needed anymore due to several reasons such as being implemented another way, too big schema change in pywikibot, etc. We can abandon them. Please check your old patches.
Best
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
I'm in favor of +2ing patches but most of open patches have -1 or -2 in their code review part.
Best
On Wed, Feb 10, 2016 at 4:54 PM info@gno.de wrote:
A better way would be to commit some patches. There are a lot of proposals which have minor changes and could be approved quickly.
best
xqt
----- Original Nachricht ---- Von: Amir Ladsgroup ladsgroup@gmail.com An: Pywikibot discussion list pywikibot@lists.wikimedia.org Datum: 09.02.2016 18:10 Betreff: [pywikibot] Number of open changesets
Hello, Per stats https://www.mediawiki.org/wiki/Gerrit/Reports/Changesets_by_project. There are 305 open change sets in pywikibot/core which make us the second project after mediawiki/core in number of open change sets. Open change sets won't do any harm but sometimes it's hard to find good patches in
pool
of out-of-date-or-not-needed-anymore patches.
Some projects have rules like "if a change set has -2 for more than N weeks, it can be abandoned" it can work for us. Also I think if we look into our own old patches we might find several patches that are not
needed
anymore due to several reasons such as being implemented another way, too big schema change in pywikibot, etc. We can abandon them. Please check
your
old patches.
Best
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
On first 4 pages we have more than 50 patches to review or to submit whereas additional 40 has to be improved and are waiting for the committer or author (or any other coder who adopts that code ;)
Best xqt
----- Original Nachricht ---- Von: Amir Ladsgroup ladsgroup@gmail.com An: info@gno.de, pywikibot@lists.wikimedia.org Datum: 10.02.2016 16:17 Betreff: Re: [pywikibot] Number of open changesets
I'm in favor of +2ing patches but most of open patches have -1 or -2 in their code review part.
Best
On Wed, Feb 10, 2016 at 4:54 PM info@gno.de wrote:
A better way would be to commit some patches. There are a lot of
proposals
which have minor changes and could be approved quickly.
best
xqt
----- Original Nachricht ---- Von: Amir Ladsgroup ladsgroup@gmail.com An: Pywikibot discussion list pywikibot@lists.wikimedia.org Datum: 09.02.2016 18:10 Betreff: [pywikibot] Number of open changesets
Hello, Per stats https://www.mediawiki.org/wiki/Gerrit/Reports/Changesets_by_project. There are 305 open change sets in pywikibot/core which make us the
second
project after mediawiki/core in number of open change sets. Open change sets won't do any harm but sometimes it's hard to find good patches in
pool
of out-of-date-or-not-needed-anymore patches.
Some projects have rules like "if a change set has -2 for more than N weeks, it can be abandoned" it can work for us. Also I think if we look into our own old patches we might find several patches that are not
needed
anymore due to several reasons such as being implemented another way,
too
big schema change in pywikibot, etc. We can abandon them. Please check
your
old patches.
Best
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
As someone who can just +/-1, where would my help be of most use to decrease the number of open changesets?
I know that for some of the MediaWiki repos +1 is ignored (or is even interpreted as a signal that something is wrong) so it would be nice to know before I invest time in going through changesets.
/André On 10 Feb 2016 17:03, info@gno.de wrote:
On first 4 pages we have more than 50 patches to review or to submit whereas additional 40 has to be improved and are waiting for the committer or author (or any other coder who adopts that code ;)
Best xqt
----- Original Nachricht ---- Von: Amir Ladsgroup ladsgroup@gmail.com An: info@gno.de, pywikibot@lists.wikimedia.org Datum: 10.02.2016 16:17 Betreff: Re: [pywikibot] Number of open changesets
I'm in favor of +2ing patches but most of open patches have -1 or -2 in their code review part.
Best
On Wed, Feb 10, 2016 at 4:54 PM info@gno.de wrote:
A better way would be to commit some patches. There are a lot of
proposals
which have minor changes and could be approved quickly.
best
xqt
----- Original Nachricht ---- Von: Amir Ladsgroup ladsgroup@gmail.com An: Pywikibot discussion list pywikibot@lists.wikimedia.org Datum: 09.02.2016 18:10 Betreff: [pywikibot] Number of open changesets
Hello, Per stats <https://www.mediawiki.org/wiki/Gerrit/Reports/Changesets_by_project
.
There are 305 open change sets in pywikibot/core which make us the
second
project after mediawiki/core in number of open change sets. Open
change
sets won't do any harm but sometimes it's hard to find good patches
in
pool
of out-of-date-or-not-needed-anymore patches.
Some projects have rules like "if a change set has -2 for more than N weeks, it can be abandoned" it can work for us. Also I think if we
look
into our own old patches we might find several patches that are not
needed
anymore due to several reasons such as being implemented another way,
too
big schema change in pywikibot, etc. We can abandon them. Please
check
your
old patches.
Best
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
Le 13/02/2016 11:29, André Costa a écrit :
As someone who can just +/-1, where would my help be of most use to decrease the number of open changesets?
I know that for some of the MediaWiki repos +1 is ignored (or is even interpreted as a signal that something is wrong) so it would be nice to know before I invest time in going through changesets.
/André
Hello,
I see the +2 as merely an approval of over +1 votes. So any feedback you can leave on changes will be a step toward having it merged. The more people think a patch is fine via comments and +1 the more confidence people will have to get it merged :-)
There might be change that had a -1 just for a typo or a lack of comment. Usually you should be able to get the patch, fix the tiny issue and send it back. Not necessarily the funniest tasks to do, but I am sure it helps.
Sometime -1 are landed asking for a change to be tested. If you conduct the test and report back with your finding that would help as well. Ie: I tested it this way, works fine to me. Or I ran it and got that error : xxx.
So in short, don't be afraid about commenting and voting +1/-1 as you may fit.
On Wed, Feb 10, 2016 at 4:10 AM, Amir Ladsgroup ladsgroup@gmail.com wrote:
Hello, Per stats. There are 305 open change sets in pywikibot/core which make us the second project after mediawiki/core in number of open change sets.
However pywikibot is different, in that we are all volunteers, unlike all of the other projects of roughly equivalent size which are heavily staffed.
Also, you will find that most of the pending changes are by the core developers. IMO the simplest solution, and I have said this before to you, if for you to have a Gerrit query that removes pending patches from people who have lots of old patches that you dont want to see.
I would be much more interested in stats that shows only non-core (i.e. not +2 rights) developers, as that shows whether we're treating patches by newcomers respectfully.
Open change sets won't do any harm but sometimes it's hard to find good patches in pool of out-of-date-or-not-needed-anymore patches.
Some projects have rules like "if a change set has -2 for more than N weeks, it can be abandoned" it can work for us.
No thank you. Fixing a stat only helps the stat. it does not help the developers.
Most of them are WIP for hard problems that we have not yet solved. Gerrit is not a very helpful interface; if they are abandoned, it is hard to find them. We have lots of abandoned patches because they were a solution which was not the best.
Unless you solve those problems, the current patch is useful for discussion. Most of them hold very valuable discussions already, indicating what has yet to be done.
Also I think if we look into our own old patches we might find several patches that are not needed anymore due to several reasons such as being implemented another way, too big schema change in pywikibot, etc. We can abandon them. Please check your old patches.
I doubt that you would find many like that. Last year we would regularly look through them all to see what could be re-reviewed or abandoned, and if I felt they needed to be abandoned I would note that on the gerrit discussion. I dont have time to do that now, but it would be great if someone did.
As a decent number of these changesets are mine, or I was a -1'er, please be advised that I will start to have more time to work on them again after a few weeks.