Happy Monday,
There are strange people who make such links (kindof urlencoded?):
[[Második világháború#Partrasz.C3.A1ll.C3.A1s Szic.C3.ADli.C3.A1ban
.28Huskey hadm.C5.B1velet.29|Huskey hadműveletben]]
So the section title must have been copied from the URL.
Do we have a ready tool to fix these?
--
Bináris
Hello all
>From one of my assignments as a bot operator I have some code which
does template parsing and general text parsing (e.g. Image/File tags).
It is not using regex and thus able to correctly parse nested
templates and other such nasty things. I have written those as library
classes and written tests for them which cover almost all of the code.
I would now really like to contribute that code back to the community.
Would you be interested in adding this code to the pywikibot
framework? If yes, can I send the code to someone for code review or
how do you usually operate?
Greetings
Hannes
PS: wiki userpage is http://en.wikipedia.org/wiki/User:Hannes_R%C3%B6st
Hallo Pyfisch,
ich finde es großartig, wie Du Dich beim pwb als Coder einbringst und es ist immer doof, beim Review ein -1 oder -2 zu vergeben, weil es immer den Eindruck hinterläßt, daß Deine Arbeit nicht geschätzt wird. Sei versichert, ic schätze sie sehr und da CR ist rein technischer Natur, das der Verbesserung dient. Das mal so vorweg.
Jetzt zu einigen Punkten:
Deine Änderungen in category_redirekt fand ich sehr elegant, weshalb ich sie auch in das Framework übernommen habe. Leider hat dies in bestimmte Fällen zu Fehlern geführt [1], was ich auch übersehen habe. Daher habe ich Deine Änderungen wieder zurücknehmen müssen [2]. Vielleicht findest Du noch einen Weg, der die lokale Methode weitgehend überflüssig macht ohne die fehlerhafte Log-Funktion.
category.py sollte erst dann ein Rewrite bekommen, sobald alle Funktionen aus der compat-Branch übernommen worden sind. Sonst wird das später umso schwieriger. Deshalb hier erstmal ein CR-2. Außerdem solltest Du die Änderungen mehr dokumentieren (Siebrand kommentierte das auch). Sonst ist der Review enorm schwierig, weil man sich in das Programm reindenken muß. Du hast da auch einen Breaking change beim Construktor. Bitte noch überprüfen, ob der Bot nicht anderweitig benutzt wird, ggf. mit dem @deprecate_arg decorator umbiegen.
LG und guten Rutsch morgen
xqt
[1] https://bugzilla.wikimedia.org/process_bug.cgi
[2] https://gerrit.wikimedia.org/r/#/c/104505/
Hello,
Currently in setup.py, we call generate_user_files.py, which requires
interactive input. This is bad for package managers like the bug
report mentions, and also for pypi/pip.
Removing it is a little more difficult for users, they need to now run
both setup.py and generate_user_files.py, but I think that's an ok
tradeoff. Most users will be using the pwb.py script anyways, so this
wouldn't even affect them.
Thoughts?
Bug link: https://bugzilla.wikimedia.org/555843
What Arch is using:
https://aur.archlinux.org/packages/py/python2-pywikibot-git/PKGBUILD
-- Legoktm
PS: bug 55584 is blocking packaging too, if someone wants to fix that :)
Hi,
Should I log a task for porting from compat to core all functions not
implemented in site.py (like ancientpages_address)?
I see a comment saying "unsupported methods from version 1" and it's
unclear to me if these are useless or just not implemented.
Thanks,
Strainu
# noqa works? I saw your last mail where you had doubts or I interpreted it in this way.
Anyway, a lot of pyflakes reported messages are wrong and I would like to ignore these parts line by line if it is really wrong.
----- Ursprüngliche Nachricht -----
Von: Merlijn van Deen
Gesendet: 03.11.2013 21:50
An: Pywikipedia discussion list
Betreff: Re: [Pywikipedia-l] python styling (pep8/pyflakes)
Some of them (I think mainly the line breaking ones) can be ignored by adding # noqa
to the end of the line. If we really need something more than that, we can look at a custom
solution. What was the line that was giving you trouble?
Merlijn
On 3 November 2013 13:30, <info(a)gno.de> wrote:
Hi folks,
is there any ability now to ignore pep8 or pyflake testing from a specific code line?
Greetings
xqt
----- Original Nachricht ----
Von: Antoine Musso <hashar+wmf(a)free.fr>
An: pywikipedia-l(a)lists.wikimedia.org
Datum: 29.07.2013 21:41
Betreff: Re: [Pywikipedia-l] python styling (pep8/pyflakes)
> Le 29/07/13 21:19, Merlijn van Deen a écrit :
> > Hm, indeed. # noqa is only supported in v1.4.1+; # nopep8 was introduced
> > in v1.4+, and thus is also not available in 1.3. Would it be possible to
> > upgrade to a more recent version? Ubuntu Saucy has 1.4.5 available.
> >
> > Merlijn
>
> I apparently managed to backport pep8 1.4.5 from Saucy to Precise using
> the tutorial at:
>
> https://wikitech.wikimedia.org/wiki/Backport_packages
>
> I have installed the package on the instance and it seems to be running
> fine. I have filled https://bugzilla.wikimedia.org/52239 to record the
> log of the build and track the backporting itself.
>
> I will have to announce the upgrade ahead of time since it will
> introduce new failures that might makes some repos to suddenly fail
> their pep8 check.
>
>
> --
> Antoine "hashar" Musso
>
>
> _______________________________________________
> Pywikipedia-l mailing list
> Pywikipedia-l(a)lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
>
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l