jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/487657 )
Change subject: [tests] Test for UnknownExtension if 'Linter' is not available ......................................................................
[tests] Test for UnknownExtension if 'Linter' is not available
test for UnknownExtension if 'Linter' extension is not available for a given site inside TestFactoryGenerator.test_linter_generator_show() test method.
Bug: T215124 Change-Id: I92d3c4b013639948df6af04da50f2beaa6d0fbcf --- M tests/pagegenerators_tests.py 1 file changed, 6 insertions(+), 3 deletions(-)
Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index 72f4673..a32debf 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -1220,9 +1220,12 @@ def test_linter_generator_show(self): """Test generator of pages with lint errors.""" gf = pagegenerators.GeneratorFactory(site=self.site) - with self.assertRaises(SystemExit) as cm: - gf.handleArg('-linter:show') - self.assertEqual(cm.exception.code, 0) + if self.site.has_extension('Linter'): + with self.assertRaises(SystemExit) as cm: + gf.handleArg('-linter:show') + self.assertEqual(cm.exception.code, 0) + else: + self.assertRaises(UnknownExtension, gf.handleArg, '-linter:show')
def test_querypage_generator_with_valid_page(self): """Test generator of pages with lint errors."""
pywikibot-commits@lists.wikimedia.org