Pywikibot-commits April 2024

pywikibot-commits@lists.wikimedia.org

1 participants
74 discussions

[Gerrit] ...core[master]: [tests] move OAuthEditTest from edit_tests.py to oauth_tests.py
by jenkins-bot (Code Review) 30 Apr '24

30 Apr '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1025771?usp=email ) Change subject: [tests] move OAuthEditTest from edit_tests.py to oauth_tests.py ...................................................................... [tests] move OAuthEditTest from edit_tests.py to oauth_tests.py Change-Id: I10a827744d7344114b03752b64ad34b510210477 --- M tests/edit_tests.py M tests/oauth_tests.py 2 files changed, 42 insertions(+), 40 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/edit_tests.py b/tests/edit_tests.py index 93e6cdb..415be0a 100755 --- a/tests/edit_tests.py +++ b/tests/edit_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """Tests for editing pages.""" # -# (C) Pywikibot team, 2015-2022 +# (C) Pywikibot team, 2015-2024 # # Distributed under the terms of the MIT license. # @@ -12,10 +12,9 @@ from contextlib import suppress import pywikibot -from pywikibot import config, page_put_queue +from pywikibot import page_put_queue from pywikibot.exceptions import Error from tests.aspects import TestCase, require_version -from tests.oauth_tests import OAuthSiteTestCase called_back = False @@ -176,42 +175,6 @@ self.assertEqual(dest.revision_count(), 2) -class OAuthEditTest(OAuthSiteTestCase): - - """Run edit test with OAuth enabled.""" - - family = 'wikipedia' - code = 'test' - - write = True - - def setUp(self): - """Set up test by checking site and initialization.""" - super().setUp() - self._authenticate = config.authenticate - oauth_tokens = self.consumer_token + self.access_token - config.authenticate[self.site.hostname()] = oauth_tokens - - def tearDown(self): - """Tear down test by resetting config.authenticate.""" - super().tearDown() - config.authenticate = self._authenticate - - def test_edit(self): - """Test editing to a page.""" - self.site.login() - self.assertTrue(self.site.logged_in()) - ts = str(time.time()) - p = pywikibot.Page(self.site, - f'User:{self.site.username()}/edit test') - p.site.editpage(p, appendtext=ts) - revision_id = p.latest_revision_id - p = pywikibot.Page(self.site, - f'User:{self.site.username()}/edit test') - self.assertEqual(revision_id, p.latest_revision_id) - self.assertTrue(p.text.endswith(ts)) - - if __name__ == '__main__': with suppress(SystemExit): unittest.main() diff --git a/tests/oauth_tests.py b/tests/oauth_tests.py index 345d4f3..836b91a 100755 --- a/tests/oauth_tests.py +++ b/tests/oauth_tests.py @@ -1,15 +1,18 @@ #!/usr/bin/env python3 """Test OAuth functionality.""" # -# (C) Pywikibot team, 2015-2023 +# (C) Pywikibot team, 2015-2024 # # Distributed under the terms of the MIT license. # from __future__ import annotations import os +import time from contextlib import suppress +import pywikibot +from pywikibot import config from pywikibot.login import OauthLoginManager from tests.aspects import ( DefaultSiteTestCase, @@ -46,6 +49,42 @@ self.access_token = tokens[2:] +class OAuthEditTest(OAuthSiteTestCase): + + """Run edit test with OAuth enabled.""" + + family = 'wikipedia' + code = 'test' + + write = True + + def setUp(self): + """Set up test by checking site and initialization.""" + super().setUp() + self._authenticate = config.authenticate + oauth_tokens = self.consumer_token + self.access_token + config.authenticate[self.site.hostname()] = oauth_tokens + + def tearDown(self): + """Tear down test by resetting config.authenticate.""" + super().tearDown() + config.authenticate = self._authenticate + + def test_edit(self): + """Test editing to a page.""" + self.site.login() + self.assertTrue(self.site.logged_in()) + ts = str(time.time()) + p = pywikibot.Page(self.site, + f'User:{self.site.username()}/edit test') + p.site.editpage(p, appendtext=ts) + revision_id = p.latest_revision_id + p = pywikibot.Page(self.site, + f'User:{self.site.username()}/edit test') + self.assertEqual(revision_id, p.latest_revision_id) + self.assertTrue(p.text.endswith(ts)) + + class TestOauthLoginManger(DefaultSiteTestCase, OAuthSiteTestCase): """Test OAuth login manager.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1025771?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I10a827744d7344114b03752b64ad34b510210477 Gerrit-Change-Number: 1025771 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [IMPR] Improvements for interwiki.py
by jenkins-bot (Code Review) 30 Apr '24

30 Apr '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1025788?usp=email ) Change subject: [IMPR] Improvements for interwiki.py ...................................................................... [IMPR] Improvements for interwiki.py - update documentation - add typing hints - raise RuntimeError in whatsNextPageBatch without preleading 'BUG: because 'RuntimeError:' is already shown - site objects are processed not languages Change-Id: I56984020c20a3c691ad5f40b73aac376b1797416 --- M scripts/interwiki.py 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/interwiki.py b/scripts/interwiki.py index 33102ef..61a13fe 100755 --- a/scripts/interwiki.py +++ b/scripts/interwiki.py @@ -750,19 +750,19 @@ """ return self.todo.iter_values_len() - def whatsNextPageBatch(self, site): - """ - Return the next page batch. + def whatsNextPageBatch(self, site) -> list[pywikibot.Page]: + """Return the next page batch. - By calling this method, you 'promise' this instance that you will - preload all the 'site' Pages that are in the todo list. + By calling this method, you 'promise' this instance that you + will preload all the *site* Pages that are in the todo list. - This routine will return a list of pages that can be treated. + :return: This routine will return a list of pages that can be + treated. """ # Bug-check: Isn't there any work still in progress? We can't work on # different sites at a time! if self.pending: - raise RuntimeError(f"BUG: Can't start to work on {site}; still " + raise RuntimeError(f"Can't start to work on {site}; still " f'working on {self.pending}') # Prepare a list of suitable pages result = [] @@ -1402,8 +1402,7 @@ pywikibot.info(f'Found link to {page2} in:') self.whereReport(page2, indent=4) - # TODO: allow answer to repeat previous or go back - # after a mistake + # TODO: allow answer to repeat previous or go back after a mistake answer = 'a' if acceptall else pywikibot.input_choice( 'What should be done?', [('accept', 'a'), ('reject', 'r'), ('give up', 'g'), @@ -1921,7 +1920,7 @@ Return the site that has the most open queries plus the number. If there is nothing left, return None. - Only languages that are TODO for the first Subject are returned. + Only sites that are todo for the first Subject are returned. """ if not self.firstSubject(): return None -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1025788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I56984020c20a3c691ad5f40b73aac376b1797416 Gerrit-Change-Number: 1025788 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <dalangi-ctr(a)wikimedia.org> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] use subTest in xmlreader_tests.py and avoid code duplication
by jenkins-bot (Code Review) 30 Apr '24

30 Apr '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1025782?usp=email ) Change subject: [tests] use subTest in xmlreader_tests.py and avoid code duplication ...................................................................... [tests] use subTest in xmlreader_tests.py and avoid code duplication Change-Id: I0f4b801aac2b72c6166d33457aaa1eebe06f1f0d --- M tests/xmlreader_tests.py 1 file changed, 22 insertions(+), 37 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/xmlreader_tests.py b/tests/xmlreader_tests.py index 758d921..8bf6daa 100755 --- a/tests/xmlreader_tests.py +++ b/tests/xmlreader_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """Tests for xmlreader module.""" # -# (C) Pywikibot team, 2009-2022 +# (C) Pywikibot team, 2009-2024 # # Distributed under the terms of the MIT license. # @@ -11,6 +11,7 @@ from contextlib import suppress from pywikibot import xmlreader +from pywikibot.tools import suppress_warnings from tests import join_xml_data_path from tests.aspects import TestCase @@ -40,42 +41,26 @@ self.assertEqual('Quercusrobur', pages[1].username) self.assertEqual('Pear', pages[0].title) - def test_XmlDumpFirstFoundRev(self): - """Test loading the first found revision. - - To be deprecated. - :phab: `T340804` - """ - pages = get_entries('article-pear.xml', revisions='first_found') - self.assertLength(pages, 1) - self.assertEqual('Automated conversion', pages[0].comment) - self.assertEqual('Pear', pages[0].title) - self.assertEqual('24278', pages[0].id) - self.assertEqual('185185', pages[0].revisionid) - self.assertTrue(pages[0].text.startswith('Pears are [[tree]]s of')) - self.assertTrue(not pages[0].isredirect) - - def test_XmlDumpEarliestRev(self): - """Test loading the earliest revision.""" - pages = get_entries('article-pear.xml', revisions='earliest') - self.assertLength(pages, 1) - self.assertEqual('Automated conversion', pages[0].comment) - self.assertEqual('Pear', pages[0].title) - self.assertEqual('24278', pages[0].id) - self.assertEqual('185185', pages[0].revisionid) - self.assertTrue(pages[0].text.startswith('Pears are [[tree]]s of')) - self.assertTrue(not pages[0].isredirect) - - def test_XmlDumpLatestRev(self): - """Test loading the latest revision.""" - pages = get_entries('article-pear.xml', revisions='latest') - self.assertLength(pages, 1) - self.assertEqual('sp', pages[0].comment) - self.assertEqual('Pear', pages[0].title) - self.assertEqual('24278', pages[0].id) - self.assertEqual('188924', pages[0].revisionid) - self.assertTrue(pages[0].text.startswith('Pears are [[tree]]s of')) - self.assertTrue(not pages[0].isredirect) + def test_XmlDumpFoundRev(self): + """Test loading the first, earliest and latest revision.""" + tests = { + 'first_found': ('Automated conversion', '185185'), + 'earliest': ('Automated conversion', '185185'), + 'latest': ('sp', '188924'), + } + for revisions, (comment, revid) in tests.items(): + with suppress_warnings( + r".+'allrevisions' is deprecated since release 9\.0\.0"): + pages = get_entries('article-pear.xml', revisions=revisions) + with self.subTest(revisions=revisions): + self.assertLength(pages, 1) + page = pages[0] + self.assertEqual(comment, page.comment) + self.assertEqual('Pear', page.title) + self.assertEqual('24278', page.id) + self.assertEqual(revid, page.revisionid) + self.assertTrue(page.text.startswith('Pears are [[tree]]s of')) + self.assertTrue(not page.isredirect) def test_XmlDumpRedirect(self): """Test XmlDump correctly parsing whether a page is a redirect.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1025782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I0f4b801aac2b72c6166d33457aaa1eebe06f1f0d Gerrit-Change-Number: 1025782 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] update copyright string
by jenkins-bot (Code Review) 28 Apr '24

28 Apr '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024957?usp=email ) Change subject: [doc] update copyright string ...................................................................... [doc] update copyright string Change-Id: I9139080fc23b061ec94da976722acec958a30ddd --- M pywikibot/__metadata__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/__metadata__.py b/pywikibot/__metadata__.py index 22070e6..0eae51b 100644 --- a/pywikibot/__metadata__.py +++ b/pywikibot/__metadata__.py @@ -14,4 +14,4 @@ __version__ = '9.2.0.dev1' __url__ = 'https://www.mediawiki.org/wiki/Manual:Pywikibot' -__copyright__ = '(C) Pywikibot team, 2003-' + strftime('%Y') +__copyright__ = f'2003-{strftime("%Y")}, Pywikibot team' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I9139080fc23b061ec94da976722acec958a30ddd Gerrit-Change-Number: 1024957 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] update sphinx requirements
by Xqt (Code Review) 28 Apr '24

28 Apr '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024942?usp=email ) Change subject: [doc] update sphinx requirements ...................................................................... [doc] update sphinx requirements Change-Id: Idb580cadd038c417d6c4ca20089935470f41c3aa --- M docs/conf.py M docs/requirements.txt 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/docs/conf.py b/docs/conf.py index 2ccabf7..5efdf3b 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -46,7 +46,7 @@ # If your documentation needs a minimal Sphinx version, state it here. # -needs_sphinx = '7.2.6' +needs_sphinx = '7.3.7' # Add any Sphinx extension module names here, as strings. They can be # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom diff --git a/docs/requirements.txt b/docs/requirements.txt index ba511c6..32bfea7 100644 --- a/docs/requirements.txt +++ b/docs/requirements.txt @@ -1,10 +1,10 @@ # This is a PIP requirements file for building Sphinx documentation of Pywikibot # ../requirements.txt is also needed. -# Note: Python 3.9 is required for sphinx 7.2.6 -sphinx >= 7.2.6 -rstcheck >=6.2.0 -sphinxext-opengraph >= 0.9.0 +# Note: Python 3.9 is required for sphinx 7.2 +sphinx >= 7.3.7 +rstcheck >=6.2.1 +sphinxext-opengraph >= 0.9.1 sphinx-copybutton >= 0.5.2 sphinx-notfound-page >= 1.0.0 -furo >= 2023.9.10 +furo >= 2024.4.27 tomli -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Idb580cadd038c417d6c4ca20089935470f41c3aa Gerrit-Change-Number: 1024942 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Add login information to write_tests-ci.yml
by Xqt (Code Review) 28 Apr '24

28 Apr '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024938?usp=email ) Change subject: [tests] Add login information to write_tests-ci.yml ...................................................................... [tests] Add login information to write_tests-ci.yml Change-Id: I70a0177f63412f9a05f957f6fdcb64685c627632 --- M .github/workflows/write_tests-ci.yml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/write_tests-ci.yml b/.github/workflows/write_tests-ci.yml index 74bd211..d5bbf07 100644 --- a/.github/workflows/write_tests-ci.yml +++ b/.github/workflows/write_tests-ci.yml @@ -50,9 +50,13 @@ run: | python -Werror::UserWarning -m pwb generate_user_files -site:${{matrix.site}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; echo "usernames['wikipedia']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py + echo "usernames['wikidata']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "noisysleep = float('inf')" >> user-config.py echo "maximum_GET_length = 5000" >> user-config.py echo "console_encoding = 'utf8'" >> user-config.py + echo "import os" >> user-config.py + echo "password_file = os.path.expanduser('passwordfile')" >> user-config.py + echo "('${{ env.PYWIKIBOT_USERNAME }}', '${{ secrets.PYWIKIBOT_USERPWD }}')" > passwordfile - name: Write tests with pytest id: ci_test -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I70a0177f63412f9a05f957f6fdcb64685c627632 Gerrit-Change-Number: 1024938 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] run write tests with Pywikibot-test account
by Xqt (Code Review) 28 Apr '24

28 Apr '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024936?usp=email ) Change subject: [tests] run write tests with Pywikibot-test account ...................................................................... [tests] run write tests with Pywikibot-test account Pywikibot-test account has more rights than Pywikibot-oauth. Bug: T363190 Change-Id: Id0852b6179bc15088c86ff8d2b74df45b1b82f88 --- R .github/workflows/write_tests-ci.yml 1 file changed, 8 insertions(+), 27 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/sysop_write_tests-ci.yml b/.github/workflows/write_tests-ci.yml similarity index 60% rename from .github/workflows/sysop_write_tests-ci.yml rename to .github/workflows/write_tests-ci.yml index ca3f527..74bd211 100644 --- a/.github/workflows/sysop_write_tests-ci.yml +++ b/.github/workflows/write_tests-ci.yml @@ -1,5 +1,5 @@ -name: Sysop write test CI -# Run Pywikibot write tests on test wiki using sysop rights +name: Write test CI +# Run Pywikibot write tests on test wiki on: push: @@ -11,11 +11,11 @@ env: PYWIKIBOT_TEST_RUNNING: 1 - PYWIKIBOT_USERNAME: Pywikibot-oauth + PYWIKIBOT_USERNAME: Pywikibot-test jobs: build: - runs-on: ${{ matrix.os || 'ubuntu-latest' }} + runs-on: 'ubuntu-latest' continue-on-error: ${{ matrix.experimental || false }} timeout-minutes: 100 @@ -25,9 +25,7 @@ matrix: python-version: ["3.7"] - family: ['wikipedia'] - code: ['test'] - domain: ['test.wikipedia.org'] + site: ['wikipedia:test'] experimental: [true] steps: @@ -41,21 +39,6 @@ with: python-version: ${{ matrix.python-version }} - - name: Get token name - env: - _oauth_token: OAUTH_TOKEN_${{ matrix.family }}_${{ matrix.code }} - uses: ASzc/change-string-case-action@v6 - id: token - with: - string: ${{ env._oauth_token }} - - - name: Split OAuth Token - uses: jungwinter/split@v2 - id: split - with: - msg: ${{ secrets[format('{0}', steps.token.outputs.uppercase)] }} - separator: ":" - - name: Install dependencies run: | python -m pip install --upgrade pip @@ -65,20 +48,18 @@ - name: Generate user files run: | - python -Werror::UserWarning -m pwb generate_user_files -family:${{matrix.family}} -lang:${{matrix.code}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; - echo "authenticate['${{ matrix.domain }}'] = ('${{ steps.split.outputs._0 }}', '${{ steps.split.outputs._1 }}', '${{ steps.split.outputs._2 }}', '${{ steps.split.outputs._3 }}')" >> user-config.py + python -Werror::UserWarning -m pwb generate_user_files -site:${{matrix.site}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; echo "usernames['wikipedia']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "noisysleep = float('inf')" >> user-config.py echo "maximum_GET_length = 5000" >> user-config.py echo "console_encoding = 'utf8'" >> user-config.py - - name: Sysop and write tests with pytest + - name: Write tests with pytest id: ci_test continue-on-error: true timeout-minutes: 90 env: - PYWIKIBOT_TEST_OAUTH: ${{ secrets[format('{0}', steps.token.outputs.uppercase)] }} - PYWIKIBOT_TEST_WRITE: ${{ matrix.domain == 'test.wikipedia.org' && 1 || 0}} + PYWIKIBOT_TEST_WRITE: ${{ matrix.site == 'wikipedia:test' && 1 || 0}} run: | python pwb.py version pytest -s -r A -a "rights or write" --cov=.; -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Id0852b6179bc15088c86ff8d2b74df45b1b82f88 Gerrit-Change-Number: 1024936 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] fix spelling mistakes
by jenkins-bot (Code Review) 28 Apr '24

28 Apr '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024934?usp=email ) Change subject: [doc] fix spelling mistakes ...................................................................... [doc] fix spelling mistakes Change-Id: I06bc7c07d5b2e4cb344730dc45ee1c6a6e132a93 --- M HISTORY.rst M pywikibot/tools/_deprecate.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/HISTORY.rst b/HISTORY.rst index d8d60f1..3415a6d 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -5,8 +5,8 @@ ----- *27 April 2024* -* Add support for new wikis - (:phab:`T363272`, :phab:`T363265`, :phab:`T363258`, :phab:`T363251`, :phab:`T363245`, :phab:`T360312`, :phab:`T360305`) +* Add support for new wikis (:phab:`T363272`, :phab:`T363265`, :phab:`T363258`, + :phab:`T363251`, :phab:`T363245`, :phab:`T360312`, :phab:`T360305`) * i18n updates @@ -1094,7 +1094,7 @@ * Property.getType() method has been removed * Family.server_time() method was removed; it is still available from Site object (:phab:`T89451`) * All HttpRequest parameters except of charset has been dropped (:phab:`T265206`) -* A lot of methods and properties of HttpRequest are deprecared in favour of requests.Resonse attributes +* A lot of methods and properties of HttpRequest are deprecated in favour of requests.Resonse attributes (:phab:`T265206`) * Method and properties of HttpRequest are delegated to requests.Response object (:phab:`T265206`) * comms.threadedhttp.HttpRequest.raw was replaced by HttpRequest.content property (:phab:`T265206`) diff --git a/pywikibot/tools/_deprecate.py b/pywikibot/tools/_deprecate.py index 74e2bcf..58409ac 100644 --- a/pywikibot/tools/_deprecate.py +++ b/pywikibot/tools/_deprecate.py @@ -313,7 +313,7 @@ def my_function(bar='baz'): pass # replaces 'foo' keyword by 'bar' used by my_function - @deprecare_arg('foo', None) + @deprecate_arg('foo', None) def my_function(): pass # ignores 'foo' keyword no longer used by my_function -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I06bc7c07d5b2e4cb344730dc45ee1c6a6e132a93 Gerrit-Change-Number: 1024934 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] add site informaton to UserRightsError
by jenkins-bot (Code Review) 28 Apr '24

28 Apr '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024933?usp=email ) Change subject: [tests] add site informaton to UserRightsError ...................................................................... [tests] add site informaton to UserRightsError Change-Id: I8ff7a1db8c87529b10b9e8a15c182dafbd7d732e --- M pywikibot/site/_decorators.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/_decorators.py b/pywikibot/site/_decorators.py index 6539355..5d1a31b 100644 --- a/pywikibot/site/_decorators.py +++ b/pywikibot/site/_decorators.py @@ -89,7 +89,7 @@ rights = '.' raise UserRightsError( f'User "{self.user()}" does not have required user right ' - f'"{right}"{rights}') + f'"{right}" on site {self}{rights}') return fn(self, *args, **kwargs) manage_wrapping(callee, fn) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I8ff7a1db8c87529b10b9e8a15c182dafbd7d732e Gerrit-Change-Number: 1024933 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] add missing commas
by jenkins-bot (Code Review) 27 Apr '24

27 Apr '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024715?usp=email ) Change subject: [doc] add missing commas ...................................................................... [doc] add missing commas Change-Id: I8133de1267206184b4e753710f885d9621134cef Signed-off-by: Xqt <info(a)gno.de> --- M HISTORY.rst 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/HISTORY.rst b/HISTORY.rst index 504d1b3..d8d60f1 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -6,7 +6,7 @@ *27 April 2024* * Add support for new wikis - (:phab:`T363272`, :phab:`T363265`:phab:`T363258`:phab:`T363251`:phab:`T363245`:phab:`T360312`:phab:`T360305`) + (:phab:`T363272`, :phab:`T363265`, :phab:`T363258`, :phab:`T363251`, :phab:`T363245`, :phab:`T360312`, :phab:`T360305`) * i18n updates -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1024715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I8133de1267206184b4e753710f885d9621134cef Gerrit-Change-Number: 1024715 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits April 2024