jenkins-bot has submitted this change and it was merged.
Change subject: [cleanup] code cleanup for interwikidata_tests.py
......................................................................
[cleanup] code cleanup for interwikidata_tests.py
- when super() is the only call of a inherited method it can be omitted.
Change-Id: I530def17e44d6ba2d781a55c1f581b09a09f58ef
---
M tests/interwikidata_tests.py
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/interwikidata_tests.py b/tests/interwikidata_tests.py
index b65134b..df30ded 100644
--- a/tests/interwikidata_tests.py
+++ b/tests/interwikidata_tests.py
@@ -22,10 +22,6 @@
"""A dummy bot to prevent editing in production wikis."""
- def __init__(self, *args, **kwargs):
- """Initiate the class."""
- super(DummyBot, self).__init__(*args, **kwargs)
-
def put_current(self):
"""Prevent editing."""
return False
--
To view, visit https://gerrit.wikimedia.org/r/291582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I530def17e44d6ba2d781a55c1f581b09a09f58ef
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: flake8-future-import 0.4.0 support
......................................................................
flake8-future-import 0.4.0 support
flake8-future-import 0.4.0 introduces two new codes FI16 and FI17
for future features nested_scopes and generators that are mandatory
on Python 2.6, and thus have not been listed in each file.
These two can be deactivated by setting the flake8-future-import
option min-version = 2.6.
with_statement should also be deactivated by min-version = 2.6,
however that doesnt appear to work.
Rather than forcing all devs to upgrade, also add the new
codes to the ignore list.
Change-Id: I71a05cec2077ab07190c2286107ad70f475daa71
---
M tox.ini
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tox.ini b/tox.ini
index eb77d65..319e354 100644
--- a/tox.ini
+++ b/tox.ini
@@ -126,8 +126,9 @@
# E402: module level import not at top of file; see T87409
# H201: Except: format
# P102,P103: string does contain unindexed parameters; see I36355923
-ignore = E402,D105,D211,FI10,FI12,FI13,FI15,FI5,H101,H201,H236,H301,H404,H405,I100,I101
+ignore = E402,D105,D211,FI10,FI12,FI13,FI15,FI16,FI17,FI5,H101,H201,H236,H301,H404,H405,I100,I101
exclude = .tox,.git,./*.egg,ez_setup.py,build,externals,user-config.py,./scripts/i18n/*
+min-version = 2.6
max_line_length = 100
accept-encodings = utf-8
require-code = true
--
To view, visit https://gerrit.wikimedia.org/r/291729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71a05cec2077ab07190c2286107ad70f475daa71
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Improve diff algorithm
......................................................................
Improve diff algorithm
Use format indication for added lines only once.
Bug: T136511
Change-Id: I608f2c97565abe897404af2ccd33dc59e6a4619d
---
M pywikibot/diff.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/diff.py b/pywikibot/diff.py
index 5c86c5d..6ea3acd 100644
--- a/pywikibot/diff.py
+++ b/pywikibot/diff.py
@@ -125,6 +125,10 @@
continue
if line2.startswith('?'):
yield self.color_line(line1, line2)
+ # do not try to reuse line2 as format at next iteration
+ # if already used for an added line.
+ if line1.startswith('+'):
+ line2 = ''
continue
if line1.startswith('-'):
# Color whole line to be removed.
--
To view, visit https://gerrit.wikimedia.org/r/291587
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I608f2c97565abe897404af2ccd33dc59e6a4619d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: [fix] fix docstring
......................................................................
[fix] fix docstring
Bug: T136510
Change-Id: I11cae2c4edc816f331f1759e6896d17264abeeda
---
M scripts/delete.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/delete.py b/scripts/delete.py
index 52a3bc7..4fbe618 100755
--- a/scripts/delete.py
+++ b/scripts/delete.py
@@ -31,12 +31,12 @@
-orphansonly: Specified namespaces. Separate multiple namespace
numbers or names with commas.
Examples:
- -ns:0,2,4
- -ns:Help,MediaWiki
+ -orphansonly:0,2,4
+ -orphansonly:Help,MediaWiki
Note that Main ns can be indicated either with a 0 or a ',':
- -ns:0,1
- -ns:,Talk
+ -orphansonly:0,1
+ -orphansonly:,Talk
Usage:
--
To view, visit https://gerrit.wikimedia.org/r/291580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11cae2c4edc816f331f1759e6896d17264abeeda
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>
Build Update for wikimedia/pywikibot-core
-------------------------------------
Build: #3477
Status: Errored
Duration: 43 minutes and 18 seconds
Commit: eba4d95 (2.0)
Author: Stanislav Malyshev
Message: Add asteroids that are being used as locations
Used as globes for other items on Wikidata.
Source:
SELECT (count(?item) as ?c) ?globe ?globeLabel
WHERE
{
?item wdt:P376 ?globe .
?item wdt:P625 ?location .
SERVICE wikibase:label {
bd:serviceParam wikibase:language "en" .
}
}
GROUP BY ?globe ?globeLabel
ORDER BY DESC(?c)
Change-Id: I049866d40d8ad4903f2445b6bf1fdf8a164202a3
(cherry picked from commit 9192099fb51570251e440e0be39959b0c8c7c465)
View the changeset: https://github.com/wikimedia/pywikibot-core/compare/76fa79cf433f...eba4d951…
View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/133625708
--
You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications