jenkins-bot merged this change.

View Change

Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified
[tests] Test for UnknownExtension if 'Linter' is not available

test for UnknownExtension if 'Linter' extension is not available
for a given site inside TestFactoryGenerator.test_linter_generator_show()
test method.

Bug: T215124
Change-Id: I92d3c4b013639948df6af04da50f2beaa6d0fbcf
---
M tests/pagegenerators_tests.py
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 72f4673..a32debf 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1220,9 +1220,12 @@
def test_linter_generator_show(self):
"""Test generator of pages with lint errors."""
gf = pagegenerators.GeneratorFactory(site=self.site)
- with self.assertRaises(SystemExit) as cm:
- gf.handleArg('-linter:show')
- self.assertEqual(cm.exception.code, 0)
+ if self.site.has_extension('Linter'):
+ with self.assertRaises(SystemExit) as cm:
+ gf.handleArg('-linter:show')
+ self.assertEqual(cm.exception.code, 0)
+ else:
+ self.assertRaises(UnknownExtension, gf.handleArg, '-linter:show')

def test_querypage_generator_with_valid_page(self):
"""Test generator of pages with lint errors."""

To view, visit change 487657. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I92d3c4b013639948df6af04da50f2beaa6d0fbcf
Gerrit-Change-Number: 487657
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki@gmail.com>
Gerrit-Reviewer: jenkins-bot (75)