Pywikibot-commits

pywikibot-commits@lists.wikimedia.org

1 participants
14392 discussions

[Gerrit] ...core[master]: unicodedata: Update tools/_unidata.py to unicode version 17.0.0
by jenkins-bot (Code Review) 10 Nov '25

10 Nov '25

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203277?usp=email ) Change subject: unicodedata: Update tools/_unidata.py to unicode version 17.0.0 ...................................................................... unicodedata: Update tools/_unidata.py to unicode version 17.0.0 Change-Id: I5bcb27f57e33b37f5ada20845741772231e03400 --- M pywikibot/tools/_unidata.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/tools/_unidata.py b/pywikibot/tools/_unidata.py index f698ea2..3d85468 100644 --- a/pywikibot/tools/_unidata.py +++ b/pywikibot/tools/_unidata.py @@ -1,6 +1,6 @@ """Helper function which holds data from unicodedata library.""" # -# (C) Pywikibot team, 2018-2022 +# (C) Pywikibot team, 2018-2025 # # Distributed under the terms of the MIT license. # @@ -273,7 +273,7 @@ # codepoint it takes longer especially when working with UCS2. The lists also # differ between Python versions which can be avoided by this static list. # -# This frozenset was created using Python 3.14 (Unicode version 16.0.0): +# This frozenset was created using Python 3.15 (Unicode version 17.0.0): # list(c for c in (chr(i) for i in range(sys.maxunicode)) # if unicodedata.category(c) == 'Cf') _category_cf = frozenset([ -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I5bcb27f57e33b37f5ada20845741772231e03400 Gerrit-Change-Number: 1203277 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: tests: always use actions/setup-python to install Python releases
by Xqt (Code Review) 09 Nov '25

09 Nov '25

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203269?usp=email ) Change subject: tests: always use actions/setup-python to install Python releases ...................................................................... tests: always use actions/setup-python to install Python releases For development releases allow-prereleases switch is used; drop deadsnakes/action. Change-Id: I40dcb2986efe03a8234c2336d2e641b2721ec091 --- M .github/workflows/doctest.yml M .github/workflows/login_tests-ci.yml M .github/workflows/oauth_tests-ci.yml M .github/workflows/pre-commit.yml M .github/workflows/pywikibot-ci.yml M .github/workflows/sysop_write_tests-ci.yml M .github/workflows/windows_tests.yml 7 files changed, 15 insertions(+), 46 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/.github/workflows/doctest.yml b/.github/workflows/doctest.yml index 0828db4..95d1287 100644 --- a/.github/workflows/doctest.yml +++ b/.github/workflows/doctest.yml @@ -32,16 +32,9 @@ submodules: true - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v6 - if: "!endsWith(matrix.python-version, '-dev')" with: python-version: ${{ matrix.python-version }} - - # use deadsnakes/action for development releases - - name: Set up development Python ${{ matrix.python-version }} - uses: deadsnakes/action(a)v3.2.0 - if: endsWith(matrix.python-version, '-dev') - with: - python-version: ${{ matrix.python-version }} + allow-prereleases: ${{ endsWith(matrix.python-version, '-dev') }} - name: Install dependencies run: | python -m pip install --upgrade pip diff --git a/.github/workflows/login_tests-ci.yml b/.github/workflows/login_tests-ci.yml index 702d9bf..25068f5 100644 --- a/.github/workflows/login_tests-ci.yml +++ b/.github/workflows/login_tests-ci.yml @@ -37,7 +37,7 @@ name: Run Login/Logout Tests runs-on: ${{ matrix.os || 'ubuntu-latest' }} needs: wait_for_all - timeout-minutes: 30 + timeout-minutes: 45 strategy: fail-fast: false max-parallel: 1 @@ -77,16 +77,9 @@ submodules: true - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v6 - if: "!endsWith(matrix.python-version, '-dev')" with: python-version: ${{ matrix.python-version }} - - # use deadsnakes/action for development releases - - name: Set up development Python ${{ matrix.python-version }} - uses: deadsnakes/action(a)v3.2.0 - if: endsWith(matrix.python-version, '-dev') - with: - python-version: ${{ matrix.python-version }} + allow-prereleases: ${{ endsWith(matrix.python-version, '-dev') }} - name: Install dependencies run: | python -m pip install --upgrade pip diff --git a/.github/workflows/oauth_tests-ci.yml b/.github/workflows/oauth_tests-ci.yml index 6584f05..5b3a902 100644 --- a/.github/workflows/oauth_tests-ci.yml +++ b/.github/workflows/oauth_tests-ci.yml @@ -44,16 +44,9 @@ submodules: true - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v6 - if: "!endsWith(matrix.python-version, '-dev')" with: python-version: ${{ matrix.python-version }} - - # use deadsnakes/action for development releases - - name: Set up development Python ${{ matrix.python-version }} - uses: deadsnakes/action(a)v3.2.0 - if: endsWith(matrix.python-version, '-dev') - with: - python-version: ${{ matrix.python-version }} + allow-prereleases: ${{ endsWith(matrix.python-version, '-dev') }} - name: Get token name env: _oauth_token: OAUTH_TOKEN_${{ matrix.family }}_${{ matrix.code }} diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index d2880f0..3e6479d 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -17,6 +17,7 @@ jobs: pre-commit: + timeout-minutes: 10 runs-on: ${{ matrix.os || 'ubuntu-latest' }} continue-on-error: ${{ matrix.experimental || false }} strategy: @@ -35,15 +36,10 @@ - python-version: 3.15-dev steps: - name: set up python ${{ matrix.python-version }} - if: "!endsWith(matrix.python-version, '-dev')" uses: actions/setup-python@v6 with: python-version: ${{ matrix.python-version }} - - name: set up development python ${{ matrix.python-version }} - if: endsWith(matrix.python-version, '-dev') - uses: deadsnakes/action(a)v3.2.0 - with: - python-version: ${{ matrix.python-version }} + allow-prereleases: ${{ endsWith(matrix.python-version, '-dev') }} - name: checkout uses: actions/checkout@v5 with: @@ -53,4 +49,3 @@ env: SKIP: copyright timeout-minutes: 5 - timeout-minutes: 100 diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index de0939d..e704cd0 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -20,7 +20,7 @@ build: runs-on: ${{ matrix.os || 'ubuntu-latest' }} continue-on-error: ${{ matrix.experimental || false }} - timeout-minutes: 100 + timeout-minutes: 90 strategy: fail-fast: false matrix: @@ -65,16 +65,9 @@ submodules: true - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v6 - if: "!endsWith(matrix.python-version, '-dev')" with: python-version: ${{ matrix.python-version }} - - # use deadsnakes/action for development releases - - name: Set up development Python ${{ matrix.python-version }} - uses: deadsnakes/action(a)v3.2.0 - if: endsWith(matrix.python-version, '-dev') - with: - python-version: ${{ matrix.python-version }} + allow-prereleases: ${{ endsWith(matrix.python-version, '-dev') }} - name: Install dependencies run: | python -m pip install --upgrade pip @@ -115,7 +108,7 @@ - name: Test with unittest or pytest id: ci_test continue-on-error: true - timeout-minutes: 90 + timeout-minutes: 45 env: PYWIKIBOT_TEST_NO_RC: ${{ (matrix.site == 'wikisource:zh' || matrix.test_no_rc) && 1 || 0 }} run: | diff --git a/.github/workflows/sysop_write_tests-ci.yml b/.github/workflows/sysop_write_tests-ci.yml index 2645b80..2ae6b6f 100644 --- a/.github/workflows/sysop_write_tests-ci.yml +++ b/.github/workflows/sysop_write_tests-ci.yml @@ -18,7 +18,7 @@ build: runs-on: ubuntu-latest continue-on-error: ${{ matrix.experimental || false }} - timeout-minutes: 100 + timeout-minutes: 30 strategy: fail-fast: false matrix: @@ -34,6 +34,7 @@ uses: actions/setup-python@v6 with: python-version: ${{ matrix.python-version }} + allow-prereleases: ${{ endsWith(matrix.python-version, '-dev') }} - name: Install dependencies run: | python -m pip install --upgrade pip @@ -54,7 +55,7 @@ - name: Sysop and write tests with pytest id: ci_test continue-on-error: true - timeout-minutes: 90 + timeout-minutes: 25 env: PYWIKIBOT_TEST_WRITE: ${{ matrix.site == 'wikipedia:test' && 1 || 0 }} run: | diff --git a/.github/workflows/windows_tests.yml b/.github/workflows/windows_tests.yml index 9eac771..cccc1ff 100644 --- a/.github/workflows/windows_tests.yml +++ b/.github/workflows/windows_tests.yml @@ -18,7 +18,7 @@ build: runs-on: windows-latest continue-on-error: ${{ matrix.experimental || false }} - timeout-minutes: 100 + timeout-minutes: 45 strategy: fail-fast: false matrix: @@ -34,6 +34,7 @@ uses: actions/setup-python@v6 with: python-version: ${{ matrix.python-version }} + allow-prereleases: ${{ endsWith(matrix.python-version, '-dev') }} architecture: ${{ matrix.python-arch }} - name: Install dependencies shell: powershell @@ -67,7 +68,7 @@ - name: Test with unittest id: ci_test continue-on-error: true - timeout-minutes: 90 + timeout-minutes: 40 env: PYTHONIOENCODING: utf-8 run: | -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203269?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I40dcb2986efe03a8234c2336d2e641b2721ec091 Gerrit-Change-Number: 1203269 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [IMPR] Update Dockerfile to Python 3.12
by Xqt (Code Review) 09 Nov '25

09 Nov '25

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1201015?usp=email ) Change subject: [IMPR] Update Dockerfile to Python 3.12 ...................................................................... [IMPR] Update Dockerfile to Python 3.12 Bump to Python 3.12 which currently seems to be the most used Python version fpr Pywikibot. Bug: T408997 Change-Id: Ie4c6f87d570e7baefbcc36df35f3097f59d90023 --- M Dockerfile M Dockerfile-dev 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/Dockerfile b/Dockerfile index 656071a..45d9628 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM python:3.8-slim +FROM python:3.12-slim WORKDIR /code @@ -6,7 +6,7 @@ RUN pip install -r requirements.txt COPY . . -RUN pip3 install . +RUN pip install . ENV PYTHONPATH=/code:/code/scripts diff --git a/Dockerfile-dev b/Dockerfile-dev index b68f42f..1869d66 100644 --- a/Dockerfile-dev +++ b/Dockerfile-dev @@ -1,4 +1,4 @@ -FROM python:3.8 +FROM python:3.12 WORKDIR /code @@ -8,7 +8,7 @@ RUN pip install -r dev-requirements.txt COPY . . -RUN pip3 install . +RUN pip install . ENV PYTHONPATH=/code:/code/scripts ENTRYPOINT ["python", "/code/pwb.py"] -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1201015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ie4c6f87d570e7baefbcc36df35f3097f59d90023 Gerrit-Change-Number: 1201015 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: tests: remove experimental run for pre-commit with Python 3.15
by Xqt (Code Review) 09 Nov '25

09 Nov '25

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203265?usp=email ) Change subject: tests: remove experimental run for pre-commit with Python 3.15 ...................................................................... tests: remove experimental run for pre-commit with Python 3.15 Bug: T408718 Change-Id: I81bd2e88a42acc55502fcd0d4e1856365aaf2f29 --- M .github/workflows/pre-commit.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 389028b..d2880f0 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -33,7 +33,6 @@ - python-version: '3.14' os: ubuntu-latest - python-version: 3.15-dev - experimental: true steps: - name: set up python ${{ matrix.python-version }} if: "!endsWith(matrix.python-version, '-dev')" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I81bd2e88a42acc55502fcd0d4e1856365aaf2f29 Gerrit-Change-Number: 1203265 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: tests: update pre-commit hooks
by Xqt (Code Review) 09 Nov '25

09 Nov '25

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203262?usp=email ) Change subject: tests: update pre-commit hooks ...................................................................... tests: update pre-commit hooks Also drop pre-commit tests with EOL Python 3.9 which isn't supported by some hooks anymore e.g. pyupgrade. Bug: T408718 Change-Id: Ic189775d63441c1a1d540211d5552a21f7633b74 --- M .github/workflows/pre-commit.yml M .pre-commit-config.yaml M tox.ini 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: jenkins-bot: Verified Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 9372a93..389028b 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -23,7 +23,7 @@ fail-fast: false matrix: python-version: - - '3.9' + - '3.10' - '3.13' - '3.14' os: diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 84c6fab..8d37634 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -63,14 +63,14 @@ language: python require_serial: true - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.14.3 + rev: v0.14.4 hooks: - id: ruff-check alias: ruff args: - --fix - repo: https://github.com/asottile/pyupgrade - rev: v3.21.0 + rev: v3.21.1 hooks: - id: pyupgrade args: @@ -87,7 +87,7 @@ - --remove-unused-variables exclude: ^pywikibot/backports\.py$ - repo: https://github.com/PyCQA/isort - rev: 6.1.0 + rev: 7.0.0 hooks: - id: isort exclude: ^pwb\.py$ diff --git a/tox.ini b/tox.ini index 7a4de34..73d628e 100644 --- a/tox.ini +++ b/tox.ini @@ -4,7 +4,7 @@ skip_missing_interpreters = True envlist = commit-message - lint-py{39,313} + lint-py{310,313} [params] # Note: tox 4 does not support multiple lines when doing parameters -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ic189775d63441c1a1d540211d5552a21f7633b74 Gerrit-Change-Number: 1203262 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: superset: add attention admonition for account requirements
by jenkins-bot (Code Review) 09 Nov '25

09 Nov '25

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203214?usp=email ) Change subject: superset: add attention admonition for account requirements ...................................................................... superset: add attention admonition for account requirements Bug: T408287 Change-Id: Icd2668ee401dd0b578802779f61580108e05bd93 --- M AUTHORS.rst M pywikibot/data/superset.py 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved Zache-tool: Looks good to me, approved diff --git a/AUTHORS.rst b/AUTHORS.rst index 61bd9d2..d8492a0 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -98,6 +98,7 @@ Eric Pien Erwin Evrifaessa + Ezra Yendau F - diff --git a/pywikibot/data/superset.py b/pywikibot/data/superset.py index 0c72a79..d07ade8 100644 --- a/pywikibot/data/superset.py +++ b/pywikibot/data/superset.py @@ -1,5 +1,9 @@ """Superset Query interface. +.. attention:: + This module only works with a *client login* (including 2FA). + It does **not** work with BotPassword or OAuth accounts. + .. versionadded:: 9.2 """ # -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Icd2668ee401dd0b578802779f61580108e05bd93 Gerrit-Change-Number: 1203214 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zache-tool <kimmo.virtanen(a)gmail.com> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: pre-commit: remove markdown-linebreak-ext=rst option
by jenkins-bot (Code Review) 09 Nov '25

09 Nov '25

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1200624?usp=email ) Change subject: pre-commit: remove markdown-linebreak-ext=rst option ...................................................................... pre-commit: remove markdown-linebreak-ext=rst option Multiple line breaks are a better approach than hard linebreaks with spaces. See: https://github.github.com/gfm/#hard-line-break Change-Id: I0fd781f0d8ce2fc9e3d9c1da88f32e5a98e3ed6e --- M .pre-commit-config.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 9f40df6..84c6fab 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -42,8 +42,6 @@ # list required for tab args: [--autofix, --indent, "\t", --no-ensure-ascii] - id: trailing-whitespace - args: - - --markdown-linebreak-ext=rst exclude: ^tests/data/ - repo: https://github.com/pre-commit/pygrep-hooks rev: v1.10.0 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1200624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I0fd781f0d8ce2fc9e3d9c1da88f32e5a98e3ed6e Gerrit-Change-Number: 1200624 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: tests: avoid Pytest 9.0.0
by jenkins-bot (Code Review) 09 Nov '25

09 Nov '25

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203261?usp=email ) Change subject: tests: avoid Pytest 9.0.0 ...................................................................... tests: avoid Pytest 9.0.0 Do not use Pytest 9.0.0 for tests due to known issues: https://github.com/pytest-dev/pytest/issues/13895 Bug: T409656 Change-Id: I4e214530a4c7f0eb43a0fbac8d63e7580951731c --- M .github/workflows/doctest.yml M dev-requirements.txt M tests/README.rst M tox.ini 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/.github/workflows/doctest.yml b/.github/workflows/doctest.yml index bb7e9f4..0828db4 100644 --- a/.github/workflows/doctest.yml +++ b/.github/workflows/doctest.yml @@ -51,7 +51,7 @@ pip install mwparserfromhell pip install packaging pip install PyMySQL - pip install pytest + pip install "pytest != 9.0.0" pip install requests-sse pip install wikitextparser - name: Generate user files diff --git a/dev-requirements.txt b/dev-requirements.txt index dd0dbbe..1c96116 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -1,7 +1,7 @@ # This is a requirements file for development dependencies # -pytest >= 8.4.2 +pytest >= 8.4.2, != 9.0.0 pytest-subtests >= 0.15.0 pytest-attrib >= 0.1.3 pytest-xvfb>=3.1.1 diff --git a/tests/README.rst b/tests/README.rst index 297c4e7..503b397 100644 --- a/tests/README.rst +++ b/tests/README.rst @@ -32,7 +32,7 @@ :: - pip install pytest + pip install "pytest != 9.0.0" pytest **tox** diff --git a/tox.ini b/tox.ini index 22e8154..7a4de34 100644 --- a/tox.ini +++ b/tox.ini @@ -46,7 +46,7 @@ deps = lint: pre-commit - fasttest: pytest + fasttest: pytest != 9.0.0 fasttest: pytest-attrib fasttest: pytest-subtests fasttest: mock @@ -58,7 +58,7 @@ deeptest: .[html] deeptest: .[scripts] deeptest-py313: .[wikitextparser] - deeptest-py313: pytest + deeptest-py313: pytest != 9.0.0 deeptest-py313: pytest-subtests [testenv:typing] @@ -93,7 +93,7 @@ python -m pytest pywikibot --doctest-modules {[params]DOCTEST_IGNORES} deps = - pytest + pytest != 9.0.0 wikitextparser .[eventstreams] .[mysql] @@ -106,7 +106,7 @@ python -m pytest pywikibot --doctest-modules {[params]DOCTEST_IGNORES} deps = - pytest + pytest != 9.0.0 wikitextparser .[eventstreams] .[mysql] @@ -251,6 +251,6 @@ [pytest] -minversion = 7.0.1 +minversion = 8.4.2 testpaths = tests python_files = *_tests.py -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I4e214530a4c7f0eb43a0fbac8d63e7580951731c Gerrit-Change-Number: 1203261 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: mypy: fix mypy issues in tools/itertools.py
by jenkins-bot (Code Review) 09 Nov '25

09 Nov '25

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203213?usp=email ) Change subject: mypy: fix mypy issues in tools/itertools.py ...................................................................... mypy: fix mypy issues in tools/itertools.py Change-Id: Ia2067365f6ea44050f46fbe5d247dc7b3d577bca --- M .pre-commit-config.yaml M conftest.py M pywikibot/tools/itertools.py 3 files changed, 4 insertions(+), 3 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 0447dc4..9f40df6 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -135,6 +135,6 @@ pagegenerators/(__init__|_filters)| scripts/(?:i18n/)?__init__| site/(__init__|_basesite|_decorators|_interwikimap|_tokenwallet|_upload)| - tools/(_deprecate|_logging|_unidata|chars|formatter)| + tools/(_deprecate|_logging|_unidata|chars|formatter|itertools)| userinterfaces/(__init__|_interface_base|buffer_interface|terminal_interface|transliteration) )\.py$ diff --git a/conftest.py b/conftest.py index b4a7b8d..544f800 100644 --- a/conftest.py +++ b/conftest.py @@ -27,7 +27,7 @@ r'scripts/(i18n/)?__init__|' r'site/(__init__|_basesite|_decorators|_interwikimap|' r'_tokenwallet|_upload)|' - r'tools/(_deprecate|_logging|_unidata|chars|formatter)|' + r'tools/(_deprecate|_logging|_unidata|chars|formatter|itertools)|' r'userinterfaces/(__init__|_interface_base|buffer_interface|' r'terminal_interface|transliteration)' r')\.py' diff --git a/pywikibot/tools/itertools.py b/pywikibot/tools/itertools.py index b06f6bf..7937989 100644 --- a/pywikibot/tools/itertools.py +++ b/pywikibot/tools/itertools.py @@ -13,7 +13,7 @@ import collections import heapq import itertools -from collections.abc import Callable, Generator, Iterable, Iterator +from collections.abc import Callable, Generator, Hashable, Iterable, Iterator from contextlib import suppress from typing import Any @@ -152,6 +152,7 @@ # Item is cached to check that it is found n_gen times # before being yielded. + cache: collections.defaultdict[Hashable, collections.Counter[int]] cache = collections.defaultdict(collections.Counter) n_gen = len(iterables) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ia2067365f6ea44050f46fbe5d247dc7b3d577bca Gerrit-Change-Number: 1203213 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: Fix(superset): Prevent login loop with unsupported auth methods
by Xqt (Code Review) 09 Nov '25

09 Nov '25

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1202211?usp=email ) Change subject: Fix(superset): Prevent login loop with unsupported auth methods ...................................................................... Fix(superset): Prevent login loop with unsupported auth methods Superset enters an HTTP redirect loop when OAuth or BotPassword auth methods are used. this PR introduces error handling by checking for TooManyRedirects exception in the last response, indicating a redirect loop and raise a UserRightsE` error. Bug: T408287 Change-Id: I77f710bb195125ac50112bdec6d7c4b9ea707921 --- M pywikibot/data/superset.py 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/pywikibot/data/superset.py b/pywikibot/data/superset.py index 9f49509..0c72a79 100644 --- a/pywikibot/data/superset.py +++ b/pywikibot/data/superset.py @@ -13,9 +13,11 @@ from textwrap import fill from typing import TYPE_CHECKING, Any +import requests + import pywikibot from pywikibot.comms import http -from pywikibot.exceptions import NoUsernameError, ServerError +from pywikibot.exceptions import NoUsernameError, ServerError, UserRightsError if TYPE_CHECKING: @@ -88,7 +90,15 @@ # Test if uset has been successfully logged in url = f'{self.superset_url}/api/v1/me/' - self.last_response = http.fetch(url) + try: + self.last_response = http.fetch(url) + except requests.TooManyRedirects: + raise UserRightsError( + 'Superset authentication does not support OAuth' + ' or BotPassword. Please use standard username/password' + ' authentication in user-config.py:' + ' usernames["meta"]["meta"] = "WIKIMEDIA_USERNAME"' + ) # Handle error cases if self.last_response.status_code == HTTPStatus.OK: -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1202211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I77f710bb195125ac50112bdec6d7c4b9ea707921 Gerrit-Change-Number: 1202211 Gerrit-PatchSet: 8 Gerrit-Owner: Ezra yendau <ezrayendau2000(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zache-tool <kimmo.virtanen(a)gmail.com> Gerrit-Reviewer: jenkins-bot

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits