jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/400205 )
Change subject: download_dump: Use response.iter_content
......................................................................
download_dump: Use response.iter_content
Use `response.iter_content` instead of `response.raw`
and add `stream=True` when fetching the dump file.
Bug: T183666
Change-Id: I92ae2cef5b6f43b0be689e498f1c0b530d197b4a
---
M scripts/maintenance/download_dump.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Zhuyifei1999: Looks good to me, but someone else must approve
Framawiki: Looks good to me, but someone else must approve
Dalba: Looks good to me, approved
jenkins-bot: Verified
Eflyjason: Looks good to me, but someone else must approve
diff --git a/scripts/maintenance/download_dump.py b/scripts/maintenance/download_dump.py
index febf342..d3a5123 100644
--- a/scripts/maintenance/download_dump.py
+++ b/scripts/maintenance/download_dump.py
@@ -18,12 +18,10 @@
#
from __future__ import absolute_import, division, unicode_literals
-import io
import os.path
import sys
from os import remove, symlink
-from shutil import copyfileobj
import pywikibot
@@ -82,11 +80,12 @@
os.path.join(self.getOption('wikiname'),
'latest', download_filename)
pywikibot.output('Downloading file from ' + url)
- response = fetch(url)
+ response = fetch(url, stream=True)
if response.status == 200:
try:
with open(file_storepath, 'wb') as result_file:
- copyfileobj(io.BytesIO(response.raw), result_file)
+ for chunk in response.data.iter_content(100 * 1024):
+ result_file.write(chunk)
except IOError:
pywikibot.exception()
return False
--
To view, visit
https://gerrit.wikimedia.org/r/400205
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92ae2cef5b6f43b0be689e498f1c0b530d197b4a
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Rafidaslam <rafidteam(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Eflyjason <eflyjason(a)gmail.com>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Rafidaslam <rafidteam(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>